Title: [283813] trunk/Source
- Revision
- 283813
- Author
- [email protected]
- Date
- 2021-10-08 11:08:01 -0700 (Fri, 08 Oct 2021)
Log Message
defaultAlternateFormControlDesignEnabled() can't read UIUserInterfaceIdiom in the Web Content process
https://bugs.webkit.org/show_bug.cgi?id=231416
<rdar://problem/84009054>
Reviewed by Anders Carlsson.
Source/WebKit:
It turns out WebPreferences default getters are run in the Web Content process,
which is a problem for defaultAlternateFormControlDesignEnabled because
it needs to consult with application state.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
Explicitly initialize this preference in the UI process.
Source/WTF:
* Scripts/Preferences/WebPreferences.yaml:
Remove the autogenerated default.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (283812 => 283813)
--- trunk/Source/WTF/ChangeLog 2021-10-08 18:05:11 UTC (rev 283812)
+++ trunk/Source/WTF/ChangeLog 2021-10-08 18:08:01 UTC (rev 283813)
@@ -1,3 +1,14 @@
+2021-10-08 Tim Horton <[email protected]>
+
+ defaultAlternateFormControlDesignEnabled() can't read UIUserInterfaceIdiom in the Web Content process
+ https://bugs.webkit.org/show_bug.cgi?id=231416
+ <rdar://problem/84009054>
+
+ Reviewed by Anders Carlsson.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+ Remove the autogenerated default.
+
2021-10-08 Dean Jackson <[email protected]>
Disable SYSTEM_PREVIEW when UIKit internals is enabled
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (283812 => 283813)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-08 18:05:11 UTC (rev 283812)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-08 18:08:01 UTC (rev 283813)
@@ -239,7 +239,7 @@
WebKitLegacy:
default: false
WebKit:
- default: WebKit::defaultAlternateFormControlDesignEnabled()
+ default: false
WebCore:
default: false
Modified: trunk/Source/WebKit/ChangeLog (283812 => 283813)
--- trunk/Source/WebKit/ChangeLog 2021-10-08 18:05:11 UTC (rev 283812)
+++ trunk/Source/WebKit/ChangeLog 2021-10-08 18:08:01 UTC (rev 283813)
@@ -1,3 +1,19 @@
+2021-10-08 Tim Horton <[email protected]>
+
+ defaultAlternateFormControlDesignEnabled() can't read UIUserInterfaceIdiom in the Web Content process
+ https://bugs.webkit.org/show_bug.cgi?id=231416
+ <rdar://problem/84009054>
+
+ Reviewed by Anders Carlsson.
+
+ It turns out WebPreferences default getters are run in the Web Content process,
+ which is a problem for defaultAlternateFormControlDesignEnabled because
+ it needs to consult with application state.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _setupPageConfiguration:]):
+ Explicitly initialize this preference in the UI process.
+
2021-10-08 Michael Catanzaro <[email protected]>
REGRESSION(r283802): broke Apple ports
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (283812 => 283813)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-10-08 18:05:11 UTC (rev 283812)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2021-10-08 18:08:01 UTC (rev 283813)
@@ -564,6 +564,10 @@
if (!linkedOnOrAfter(WebCore::SDKVersion::FirstWhereSiteSpecificQuirksAreEnabledByDefault))
pageConfiguration->preferences()->setNeedsSiteSpecificQuirks(false);
+
+#if PLATFORM(IOS_FAMILY)
+ pageConfiguration->preferences()->setAlternateFormControlDesignEnabled(WebKit::defaultAlternateFormControlDesignEnabled());
+#endif
}
- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
