[webkit-changes] [283875] trunk

Sun, 10 Oct 2021 09:06:35 -0700

Title: [283875] trunk
Revision
283875
Author
[email protected]
Date
2021-10-10 09:05:45 -0700 (Sun, 10 Oct 2021)

Log Message

[LFC][IFC] Do no bail out on boundary neutral characters
https://bugs.webkit.org/show_bug.cgi?id=231485

Reviewed by Antti Koivisto.

Source/WebCore:

They don't affect directionality (no bidi impact), no need to take the legacy codepath.

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForText):

LayoutTests:

* TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (283874 => 283875)


--- trunk/LayoutTests/ChangeLog	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/LayoutTests/ChangeLog	2021-10-10 16:05:45 UTC (rev 283875)
@@ -1,3 +1,12 @@
+2021-10-10  Alan Bujtas  <[email protected]>
+
+        [LFC][IFC] Do no bail out on boundary neutral characters
+        https://bugs.webkit.org/show_bug.cgi?id=231485
+
+        Reviewed by Antti Koivisto.
+
+        * TestExpectations:
+
 2021-10-09  Alan Bujtas  <[email protected]>
 
         Ideographic space behaves as breaking space

Modified: trunk/LayoutTests/TestExpectations (283874 => 283875)


--- trunk/LayoutTests/TestExpectations	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/LayoutTests/TestExpectations	2021-10-10 16:05:45 UTC (rev 283875)
@@ -2530,12 +2530,6 @@
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-last-001.xht [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-strict-011.xht [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-strict-012.xht [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-002.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-004.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-006.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-007.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-009.html [ ImageOnlyFailure ]
-webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-011.html [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-breaking/line-breaking-ic-003.html [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-001.html [ ImageOnlyFailure ]
 webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-002.html [ ImageOnlyFailure ]

Modified: trunk/LayoutTests/fast/parser/entities-in-xhtml-expected.txt (283874 => 283875)


--- trunk/LayoutTests/fast/parser/entities-in-xhtml-expected.txt	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/LayoutTests/fast/parser/entities-in-xhtml-expected.txt	2021-10-10 16:05:45 UTC (rev 283875)
@@ -20,7 +20,7 @@
 170	AA	ordf	ª	ª	ª
 171	AB	laquo	«	«	«
 172	AC	not	¬	¬	¬
-173	AD	shy			
+173	AD	shy	­	­	­
 174	AE	reg	®	®	®
 175	AF	macr	¯	¯	¯
 176	B0	deg	°	°	°

Modified: trunk/LayoutTests/fast/text/text-underline-first-line-decoration-expected.html (283874 => 283875)


--- trunk/LayoutTests/fast/text/text-underline-first-line-decoration-expected.html	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/LayoutTests/fast/text/text-underline-first-line-decoration-expected.html	2021-10-10 16:05:45 UTC (rev 283875)
@@ -8,6 +8,6 @@
 </p>
 
 <p class="decorate" style="font-size:24px; float:left;-webkit-text-underline-position:under; border:1px dotted orange">
-<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration,</span> but not </span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline"> under the image.<span style="vertical-align:-20px">&ZeroWidthSpace;</span></span><br>
+<span style="text-decoration:underline">The first line <span style="vertical-align:-20px">has a decoration, but not </span></span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"><span style="text-decoration:underline; vertical-align:-20px"> under the image.&ZeroWidthSpace;</span></span><br>
 The second line should not.
 </p>

Modified: trunk/LayoutTests/fast/text/text-underline-first-line-decoration.html (283874 => 283875)


--- trunk/LayoutTests/fast/text/text-underline-first-line-decoration.html	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/LayoutTests/fast/text/text-underline-first-line-decoration.html	2021-10-10 16:05:45 UTC (rev 283875)
@@ -11,6 +11,6 @@
 </p>
 
 <p class="decorate" style="font-size:24px; float:left;-webkit-text-underline-position:under; border:1px dotted orange">
-The first line <span style="vertical-align:-20px">has a decoration,</span> but not <img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"> under the image.<br>
+The first line <span style="vertical-align:-20px">has a decoration, but not </span><img style="vertical-align:-100px; height:20px;width:20px;background-color:lime"> <span style="vertical-align:-20px">under the image.</span><br>
 The second line should not.
 </p>

Modified: trunk/Source/WebCore/ChangeLog (283874 => 283875)


--- trunk/Source/WebCore/ChangeLog	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/Source/WebCore/ChangeLog	2021-10-10 16:05:45 UTC (rev 283875)
@@ -1,3 +1,15 @@
+2021-10-10  Alan Bujtas  <[email protected]>
+
+        [LFC][IFC] Do no bail out on boundary neutral characters
+        https://bugs.webkit.org/show_bug.cgi?id=231485
+
+        Reviewed by Antti Koivisto.
+
+        They don't affect directionality (no bidi impact), no need to take the legacy codepath.
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForText):
+
 2021-10-10  Jer Noble  <[email protected]>
 
         [Build-time perf] Speed up the WebCore null build

Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (283874 => 283875)


--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-10-10 08:49:45 UTC (rev 283874)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-10-10 16:05:45 UTC (rev 283875)
@@ -386,7 +386,7 @@
             return direction == U_RIGHT_TO_LEFT || direction == U_RIGHT_TO_LEFT_ARABIC
                 || direction == U_RIGHT_TO_LEFT_EMBEDDING || direction == U_RIGHT_TO_LEFT_OVERRIDE
                 || direction == U_LEFT_TO_RIGHT_EMBEDDING || direction == U_LEFT_TO_RIGHT_OVERRIDE
-                || direction == U_POP_DIRECTIONAL_FORMAT || direction == U_BOUNDARY_NEUTRAL;
+                || direction == U_POP_DIRECTIONAL_FORMAT;
         };
         if (isRTLDirectional(character))
             SET_REASON_AND_RETURN_IF_NEEDED(FlowTextHasDirectionCharacter, reasons, includeReasons);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to