Title: [283909] branches/safari-612-branch/Tools
Revision
283909
Author
[email protected]
Date
2021-10-11 10:46:05 -0700 (Mon, 11 Oct 2021)

Log Message

Cherry-pick r281709. <rdar://83953401>

Modified Paths

Diff

Modified: branches/safari-612-branch/Tools/ChangeLog (283908 => 283909)


--- branches/safari-612-branch/Tools/ChangeLog	2021-10-11 17:41:58 UTC (rev 283908)
+++ branches/safari-612-branch/Tools/ChangeLog	2021-10-11 17:46:05 UTC (rev 283909)
@@ -1,3 +1,12 @@
+2021-08-27  Chris Dumez  <[email protected]>
+
+        Extend API test coverage to make sure didFailProvisionalLoad is not called upon COOP process swap
+        https://bugs.webkit.org/show_bug.cgi?id=229610
+
+        Reviewed by Alex Christensen.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
 2021-08-24  Chris Dumez  <[email protected]>
 
         [WK2] Implement process-swapping based on Cross-Origin-Opener-Policy HTTP header

Modified: branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (283908 => 283909)


--- branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2021-10-11 17:41:58 UTC (rev 283908)
+++ branches/safari-612-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2021-10-11 17:46:05 UTC (rev 283909)
@@ -7232,6 +7232,7 @@
     auto uiDelegate = adoptNS([[PSONUIDelegate alloc] initWithNavigationDelegate:navigationDelegate.get()]);
     [webView setUIDelegate:uiDelegate.get()];
 
+    failed = false;
     serverRedirected = false;
     numberOfDecidePolicyCalls = 0;
     NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/main.html"]];
@@ -7253,6 +7254,7 @@
         EXPECT_FALSE(serverRedirected);
     }
     EXPECT_EQ(2U, numberOfProvisionalLoads); // One in each view.
+    EXPECT_FALSE(failed); // There should be no didFailProvisionalLoad call.
 
     auto pid1 = [webView _webProcessIdentifier];
     EXPECT_TRUE(!!pid1);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to