Title: [284147] trunk/Source/WebCore
- Revision
- 284147
- Author
- [email protected]
- Date
- 2021-10-13 22:14:32 -0700 (Wed, 13 Oct 2021)
Log Message
Compilation error: error: definition of implicit copy assignment operator in AppHighlightRangeData.h
https://bugs.webkit.org/show_bug.cgi?id=231717
rdar://problem/84230745
Reviewed by Tim Horton.
Per C++11 and later:
“The generation of the implicitly-defined copy assignment operator is
deprecated if T has a user-declared destructor or user-declared copy
constructor.”
A copy constructor is defined, so we need to declare a copy assignement operator.
* Modules/highlight/AppHighlightRangeData.h: Add copy assignment operator.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (284146 => 284147)
--- trunk/Source/WebCore/ChangeLog 2021-10-14 04:09:59 UTC (rev 284146)
+++ trunk/Source/WebCore/ChangeLog 2021-10-14 05:14:32 UTC (rev 284147)
@@ -1,3 +1,19 @@
+2021-10-13 Jean-Yves Avenard <[email protected]>
+
+ Compilation error: error: definition of implicit copy assignment operator in AppHighlightRangeData.h
+ https://bugs.webkit.org/show_bug.cgi?id=231717
+ rdar://problem/84230745
+
+ Reviewed by Tim Horton.
+
+ Per C++11 and later:
+ “The generation of the implicitly-defined copy assignment operator is
+ deprecated if T has a user-declared destructor or user-declared copy
+ constructor.”
+ A copy constructor is defined, so we need to declare a copy assignement operator.
+
+ * Modules/highlight/AppHighlightRangeData.h: Add copy assignment operator.
+
2021-10-13 Simon Fraser <[email protected]>
Use PlatformKeyboardEvent in KeyboardScrollingAnimator to fix a layering violation
Modified: trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.h (284146 => 284147)
--- trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.h 2021-10-14 04:09:59 UTC (rev 284146)
+++ trunk/Source/WebCore/Modules/highlight/AppHighlightRangeData.h 2021-10-14 05:14:32 UTC (rev 284147)
@@ -99,6 +99,8 @@
{
}
+ AppHighlightRangeData& operator=(const AppHighlightRangeData&) = default;
+
const String& identifier() const { return m_identifier; }
const String& text() const { return m_text; }
const NodePath& startContainer() const { return m_startContainer; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
