Title: [284180] trunk/Tools
- Revision
- 284180
- Author
- [email protected]
- Date
- 2021-10-14 11:18:14 -0700 (Thu, 14 Oct 2021)
Log Message
[ iOS Release ] TestWebKitAPI.WebKit.TryUsingPrewarmedProcessThatJustCrashed is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=229260
<rdar://problem/82100254>
Reviewed by Youenn Fablet.
WebKit's default crash handler simply calls [webview reload] which does not reliably work
here because the WebProcess gets terminated so early in the page load. To make the test pass
reliably, it now provides its own crash handler which loads the same request again.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284179 => 284180)
--- trunk/Tools/ChangeLog 2021-10-14 18:06:10 UTC (rev 284179)
+++ trunk/Tools/ChangeLog 2021-10-14 18:18:14 UTC (rev 284180)
@@ -1,3 +1,18 @@
+2021-10-14 Chris Dumez <[email protected]>
+
+ [ iOS Release ] TestWebKitAPI.WebKit.TryUsingPrewarmedProcessThatJustCrashed is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=229260
+ <rdar://problem/82100254>
+
+ Reviewed by Youenn Fablet.
+
+ WebKit's default crash handler simply calls [webview reload] which does not reliably work
+ here because the WebProcess gets terminated so early in the page load. To make the test pass
+ reliably, it now provides its own crash handler which loads the same request again.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
+ (TEST):
+
2021-10-14 Jonathan Bedard <[email protected]>
[git-webkit] Reset author time when editing commits (Follow-up fix)
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm (284179 => 284180)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm 2021-10-14 18:06:10 UTC (rev 284179)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm 2021-10-14 18:18:14 UTC (rev 284180)
@@ -162,6 +162,12 @@
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
configuration.get().processPool = pool.get();
auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
+ auto delegate = adoptNS([[TestNavigationDelegate alloc] init]);
+ delegate.get().webContentProcessDidTerminate = ^(WKWebView *view) {
+ [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:loadableURL]]];
+ };
+ [webView setNavigationDelegate:delegate.get()];
+
[webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:loadableURL]]];
- [webView _test_waitForDidFinishNavigation];
+ [delegate waitForDidFinishNavigation];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
