Title: [284193] trunk
Revision
284193
Author
[email protected]
Date
2021-10-14 13:30:11 -0700 (Thu, 14 Oct 2021)

Log Message

All the SDKVariant.xcconfig files should match
https://bugs.webkit.org/show_bug.cgi?id=231663

Reviewed by Youenn Fablet.

PerformanceTests:

* MediaTime/Configurations/SDKVariant.xcconfig:

Source/bmalloc:

* Configurations/SDKVariant.xcconfig:

Source/_javascript_Core:

The linter says they're all supposed to match.
Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig has an extra section,
and if you delete that section the build fails, so this patch broadcasts that extra
section to all the other SDKVariant.xcconfig files.

* Configurations/SDKVariant.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/SDKVariant.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/SDKVariant.xcconfig:

Source/WebCore:

No new tests because there was no behavior change.

* Configurations/SDKVariant.xcconfig:

Source/WebCore/PAL:

* Configurations/SDKVariant.xcconfig:

Source/WebInspectorUI:

* Configurations/SDKVariant.xcconfig:

Source/WebKit:

* Configurations/SDKVariant.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/SDKVariant.xcconfig:

Source/WTF:

* Configurations/SDKVariant.xcconfig:

Tools:

* ContentExtensionTester/Configurations/SDKVariant.xcconfig:
* DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
* ImageDiff/cg/Configurations/SDKVariant.xcconfig:
* MiniBrowser/Configurations/SDKVariant.xcconfig:
* MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
* TestWebKitAPI/Configurations/SDKVariant.xcconfig:
* WebEditingTester/Configurations/SDKVariant.xcconfig:
* WebKitTestRunner/Configurations/SDKVariant.xcconfig:
* lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (284192 => 284193)


--- trunk/PerformanceTests/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/PerformanceTests/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * MediaTime/Configurations/SDKVariant.xcconfig:
+
 2021-09-07  Myles C. Maxfield  <[email protected]>
 
         Add a PerformanceTest for some common FontFaceSet style update operations

Modified: trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/_javascript_Core/ChangeLog (284192 => 284193)


--- trunk/Source/_javascript_Core/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,17 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        The linter says they're all supposed to match.
+        Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig has an extra section,
+        and if you delete that section the build fails, so this patch broadcasts that extra
+        section to all the other SDKVariant.xcconfig files.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-14  Chris Dumez  <[email protected]>
 
         Unreviewed build fix with recent SDKs.

Modified: trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (284192 => 284193)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-13  Kyle Piddington  <[email protected]>
 
         Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands

Modified: trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/ThirdParty/ChangeLog (284192 => 284193)


--- trunk/Source/ThirdParty/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/ThirdParty/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * gtest/xcode/Config/SDKVariant.xcconfig:
+
 2021-05-29  Sam Weinig  <[email protected]>
 
         Remove selective compilation of libwebrtc as TestWebKitAPI depends on it for boringssl, so it is always needed

Modified: trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WTF/ChangeLog (284192 => 284193)


--- trunk/Source/WTF/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WTF/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-14  Chris Dumez  <[email protected]>
 
         Unreviewed build fix with recent SDKs.

Modified: trunk/Source/WTF/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WTF/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WTF/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WebCore/ChangeLog (284192 => 284193)


--- trunk/Source/WebCore/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebCore/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,14 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        No new tests because there was no behavior change.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-14  Alan Bujtas  <[email protected]>
 
         [LFC][IFC] tryBreakingTextRun should not take std::nullopt "available width" to indicate that the run is not overflowing

Modified: trunk/Source/WebCore/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WebCore/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebCore/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WebCore/PAL/ChangeLog (284192 => 284193)


--- trunk/Source/WebCore/PAL/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-13  Wenson Hsieh  <[email protected]>
 
         Support both VK and VKC-prefixed SPI when softlinking VisionKitCore classes

Modified: trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WebInspectorUI/ChangeLog (284192 => 284193)


--- trunk/Source/WebInspectorUI/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-13  Carlos Garcia Campos  <[email protected]>
 
         HTTP method in web inspector network tab is not what WebKit actually sent after a redirect from POST to GET

Modified: trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WebKit/ChangeLog (284192 => 284193)


--- trunk/Source/WebKit/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebKit/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-14  Chris Dumez  <[email protected]>
 
         [WKWebView _loadServiceWorkerURL] ends up lowercasing URL host

Modified: trunk/Source/WebKit/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WebKit/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebKit/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (284192 => 284193)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-10-14  David Kilzer  <[email protected]>
 
         Modernize WebDatabaseManagerClient

Modified: trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Source/bmalloc/ChangeLog (284192 => 284193)


--- trunk/Source/bmalloc/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/bmalloc/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,12 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * Configurations/SDKVariant.xcconfig:
+
 2021-09-30  Filip Pizlo  <[email protected]>
 
         [libpas] Change the names of libpas heap runtime configs to something simpler (intrinsic, primitive, typed, and flex) and add comments describing what they are (update to 32abc1fd5489e01aa1c504ae4654967047d3f072)

Modified: trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/ChangeLog (284192 => 284193)


--- trunk/Tools/ChangeLog	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/ChangeLog	2021-10-14 20:30:11 UTC (rev 284193)
@@ -1,3 +1,20 @@
+2021-10-14  Myles C. Maxfield  <[email protected]>
+
+        All the SDKVariant.xcconfig files should match
+        https://bugs.webkit.org/show_bug.cgi?id=231663
+
+        Reviewed by Youenn Fablet.
+
+        * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
+        * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
+        * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
+        * MiniBrowser/Configurations/SDKVariant.xcconfig:
+        * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
+        * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
+        * WebEditingTester/Configurations/SDKVariant.xcconfig:
+        * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
+        * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
+
 2021-10-14  Chris Dumez  <[email protected]>
 
         [WKWebView _loadServiceWorkerURL] ends up lowercasing URL host

Modified: trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 

Modified: trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig (284192 => 284193)


--- trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:20:52 UTC (rev 284192)
+++ trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig	2021-10-14 20:30:11 UTC (rev 284193)
@@ -37,6 +37,10 @@
 WK_ALTERNATE_PLATFORM_NAME_iosmac = maccatalyst;
 WK_USE_ALTERNATE_PLATFORM_NAME = $(WK_NOT_$(WK_EMPTY_$(WK_ALTERNATE_PLATFORM_NAME)));
 
+WK_CHECK_CATALYST = $(WK_CHECK_CATALYST_$(SDK_VARIANT));
+WK_CHECK_CATALYST_iosmac = YES;
+WK_IS_CATALYST = $(WK_NOT_$(WK_EMPTY_$(WK_CHECK_CATALYST)));
+
 WK_ALTERNATE_WEBKIT_SDK_PATH = $(WK_ALTERNATE_WEBKIT_SDK_PATH_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
 WK_ALTERNATE_WEBKIT_SDK_PATH_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to