Title: [284201] trunk/Source/WebCore
Revision
284201
Author
[email protected]
Date
2021-10-14 15:22:05 -0700 (Thu, 14 Oct 2021)

Log Message

[AppleWin] Controls are not being rendered
https://bugs.webkit.org/show_bug.cgi?id=231769
<rdar://problem/83670287>

Reviewed by Fujii Hironori.

Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.

* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (284200 => 284201)


--- trunk/Source/WebCore/ChangeLog	2021-10-14 22:04:33 UTC (rev 284200)
+++ trunk/Source/WebCore/ChangeLog	2021-10-14 22:22:05 UTC (rev 284201)
@@ -1,3 +1,17 @@
+2021-10-14  Per Arne Vollan  <[email protected]>
+
+        [AppleWin] Controls are not being rendered
+        https://bugs.webkit.org/show_bug.cgi?id=231769
+        <rdar://problem/83670287>
+
+        Reviewed by Fujii Hironori.
+
+        Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
+        The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
+
+        * platform/graphics/win/GraphicsContextWin.cpp:
+        (WebCore::GraphicsContext::getWindowsContext):
+
 2021-10-14  Antti Koivisto  <[email protected]>
 
         [LFC][Integration] Enable inline boxes with background

Modified: trunk/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp (284200 => 284201)


--- trunk/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp	2021-10-14 22:04:33 UTC (rev 284200)
+++ trunk/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp	2021-10-14 22:22:05 UTC (rev 284201)
@@ -56,7 +56,7 @@
     HDC hdc = nullptr;
 #if !USE(CAIRO)
     hdc = deprecatedPrivateContext()->m_hdc;
-    if (hdc && isInTransparencyLayer()) {
+    if (hdc && !isInTransparencyLayer()) {
         deprecatedPrivateContext()->flush();
         deprecatedPrivateContext()->save();
         return deprecatedPrivateContext()->m_hdc;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to