Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (106712 => 106713)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-02-04 01:18:23 UTC (rev 106713)
@@ -69,6 +69,6 @@
config.kUpdateFrequency = kTenMinutesInMilliseconds;
config.kRelativeTimeUpdateFrequency = 1000 * 60;
+config.kExperimentalFeatures = window.location.search.search('enableExperiments=1') != -1;
-
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (106712 => 106713)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-02-04 01:18:23 UTC (rev 106713)
@@ -99,11 +99,17 @@
updateButton.addEventListener("click", update);
updateButton.textContent = 'update';
- var summary = onebar.summary();
- summary.appendChild(updateButton);
- summary.appendChild(g_info);
- summary.appendChild(unexpectedFailuresView);
+ var unexpected = onebar.unexpected();
+ unexpected.appendChild(updateButton);
+ unexpected.appendChild(g_info);
+ unexpected.appendChild(unexpectedFailuresView);
+ var expected = onebar.expected();
+ if (expected) {
+ var expectedFailuresView = new ui.failures.List();
+ expected.appendChild(expectedFailuresView);
+ }
+
update();
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (106712 => 106713)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2012-02-04 01:18:23 UTC (rev 106713)
@@ -127,4 +127,11 @@
}
});
+ui.failures.List = base.extends('div', {
+ init: function()
+ {
+ this.textContent = "TODO: List failures here.";
+ }
+});
+
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (106712 => 106713)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-02-04 01:18:23 UTC (rev 106713)
@@ -63,18 +63,23 @@
this.id = 'onebar';
this.innerHTML =
'<ul>' +
- '<li><a href="" +
+ '<li><a href="" Failures</a></li>' +
+ '<li><a href="" Failures</a></li>' +
'<li><a href="" +
'</ul>' +
- '<div id="summary"></div>' +
+ '<div id="unexpected"></div>' +
+ '<div id="expected"></div>' +
'<div id="results"></div>';
this._tabNames = [
- 'summary',
+ 'unexpected',
+ 'expected',
'results',
]
this._tabs = $(this).tabs({
- disabled: [1],
+ disabled: [2],
});
+ if (!config.kExperimentalFeatures)
+ this._tabs.tabs('remove', 1);
},
attach: function()
{
@@ -83,6 +88,8 @@
tabNamed: function(tabName)
{
tab = document.getElementById(tabName);
+ if (!tab)
+ return null;
// We perform this sanity check below to make sure getElementById
// hasn't given us a node in some other unrelated part of the document.
// that shouldn't happen normally, but it could happen if an attacker
@@ -91,10 +98,14 @@
return null;
return tab;
},
- summary: function()
+ unexpected: function()
{
- return this.tabNamed('summary');
+ return this.tabNamed('unexpected');
},
+ expected: function()
+ {
+ return this.tabNamed('expected');
+ },
results: function()
{
return this.tabNamed('results');
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css (106712 => 106713)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css 2012-02-04 01:18:23 UTC (rev 106713)
@@ -40,10 +40,10 @@
border-radius: 0px;
}
-#summary {
+#unexpected {
min-height: 550px;
}
-#onebar.partytime #summary {
+#onebar.partytime #unexpected {
background: url(../images/partytime.gif) center center no-repeat;
}
Modified: trunk/Tools/ChangeLog (106712 => 106713)
--- trunk/Tools/ChangeLog 2012-02-04 01:09:05 UTC (rev 106712)
+++ trunk/Tools/ChangeLog 2012-02-04 01:18:23 UTC (rev 106713)
@@ -1,3 +1,21 @@
+2012-02-03 Adam Barth <[email protected]>
+
+ Add a blank "Expected Failures" tab to garden-o-matic
+ https://bugs.webkit.org/show_bug.cgi?id=77793
+
+ Reviewed by Eric Seidel.
+
+ This tab will help us explore and manage our expected failures. The
+ tab is hidden by default via a new "experimental features" flag.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
+ (#unexpected):
+ (#onebar.partytime #unexpected):
+
2012-02-03 Lucas Forschler <[email protected]>
update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
