Title: [284229] trunk/Tools
- Revision
- 284229
- Author
- [email protected]
- Date
- 2021-10-14 19:55:32 -0700 (Thu, 14 Oct 2021)
Log Message
TestWebKitAPI.PrivateClickMeasurement.FraudPrevention is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=231393
<rdar://problem/84000081>
Reviewed by Alex Christensen and Kate Cheney as part of https://bugs.webkit.org/show_bug.cgi?id=231553.
* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::TEST):
PrivateClickMeasurement.FraudPrevention fixed. It was missing a call to
_setPrivateClickMeasurementAppBundleIDForTesting() so that the app bundle ID
for the triggering event matches the app bundle ID where the click happened.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284228 => 284229)
--- trunk/Tools/ChangeLog 2021-10-15 02:21:54 UTC (rev 284228)
+++ trunk/Tools/ChangeLog 2021-10-15 02:55:32 UTC (rev 284229)
@@ -1,3 +1,17 @@
+2021-10-14 John Wilander <[email protected]>
+
+ TestWebKitAPI.PrivateClickMeasurement.FraudPrevention is a constant timeout
+ https://bugs.webkit.org/show_bug.cgi?id=231393
+ <rdar://problem/84000081>
+
+ Reviewed by Alex Christensen and Kate Cheney as part of https://bugs.webkit.org/show_bug.cgi?id=231553.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
+ (TestWebKitAPI::TEST):
+ PrivateClickMeasurement.FraudPrevention fixed. It was missing a call to
+ _setPrivateClickMeasurementAppBundleIDForTesting() so that the app bundle ID
+ for the triggering event matches the app bundle ID where the click happened.
+
2021-10-14 Lauro Moura <[email protected]>
[webkitpy] Occasional exception thrown in change_result_to_failure when repeating flaky layout tests
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm (284228 => 284229)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-10-15 02:21:54 UTC (rev 284228)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-10-15 02:55:32 UTC (rev 284229)
@@ -317,8 +317,10 @@
[webView _setPrivateClickMeasurementOverrideTimerForTesting:YES completionHandler:^{
[webView _setPrivateClickMeasurementAttributionTokenPublicKeyURLForTesting:serverURL completionHandler:^{
[webView _setPrivateClickMeasurementAttributionTokenSignatureURLForTesting:serverURL completionHandler:^{
- NSString *html = [NSString stringWithFormat:@"<script>setTimeout(function(){ fetch('%@conversionRequestBeforeRedirect',{mode:'no-cors'}); }, 100);</script>", serverURL];
- [webView loadHTMLString:html baseURL:exampleURL()];
+ [webView _setPrivateClickMeasurementAppBundleIDForTesting:@"test.bundle.id" completionHandler:^{
+ NSString *html = [NSString stringWithFormat:@"<script>setTimeout(function(){ fetch('%@conversionRequestBeforeRedirect',{mode:'no-cors'}); }, 100);</script>", serverURL];
+ [webView loadHTMLString:html baseURL:exampleURL()];
+ }];
}];
}];
}];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
