Title: [284293] trunk/Source/ThirdParty/ANGLE
- Revision
- 284293
- Author
- [email protected]
- Date
- 2021-10-15 16:57:12 -0700 (Fri, 15 Oct 2021)
Log Message
REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
https://bugs.webkit.org/show_bug.cgi?id=231682
Transform feedback should avoid appending _u for
builtin output variables.
Reviewed by Kimmo Kinnunen.
* src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:
(rx::mtl::GenerateTransformFeedbackVaryingOutput):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (284292 => 284293)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-10-15 23:46:16 UTC (rev 284292)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-10-15 23:57:12 UTC (rev 284293)
@@ -1,3 +1,16 @@
+2021-10-15 Kyle Piddington <[email protected]>
+
+ REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=231682
+
+ Transform feedback should avoid appending _u for
+ builtin output variables.
+
+ Reviewed by Kimmo Kinnunen.
+
+ * src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:
+ (rx::mtl::GenerateTransformFeedbackVaryingOutput):
+
2021-10-14 Kyle Piddington <[email protected]>
https://tankionline.com/play/ html5 engine not working: crashes. (Metal shader not working)
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm (284292 => 284293)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm 2021-10-15 23:46:16 UTC (rev 284292)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm 2021-10-15 23:57:12 UTC (rev 284293)
@@ -258,7 +258,12 @@
<< "] + (gl_VertexID + ANGLE_instanceIdMod * "
<< "ANGLE_" << std::string(sh::kUniformsVar) << ".ANGLE_xfbVerticesPerDraw) * " << stride
<< " + " << offset << "] = " << "as_type<float>" << "("
- << "ANGLE_vertexOut." << kUserDefinedNamePrefix << varying.name;
+ << "ANGLE_vertexOut.";
+ if (!varying.isBuiltIn())
+ {
+ result << kUserDefinedNamePrefix;
+ }
+ result << varying.name;
if (varying.isArray())
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
