Title: [284311] trunk/Source/WebKit
Revision
284311
Author
[email protected]
Date
2021-10-16 02:07:26 -0700 (Sat, 16 Oct 2021)

Log Message

[GTK4] Update signal name to monitor window resize
https://bugs.webkit.org/show_bug.cgi?id=231854

Reviewed by Carlos Garcia Campos.

Using size-changed (previous signal name) makes the MiniBrowser crash
running the WebDriver tests.

The signal name was changed in
https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
as part of GTK 3.99.5.

Covered by existing tests.

* UIProcess/API/glib/WebKitUIClient.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (284310 => 284311)


--- trunk/Source/WebKit/ChangeLog	2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/ChangeLog	2021-10-16 09:07:26 UTC (rev 284311)
@@ -1,3 +1,21 @@
+2021-10-16  Lauro Moura  <[email protected]>
+
+        [GTK4] Update signal name to monitor window resize
+        https://bugs.webkit.org/show_bug.cgi?id=231854
+
+        Reviewed by Carlos Garcia Campos.
+
+        Using size-changed (previous signal name) makes the MiniBrowser crash
+        running the WebDriver tests.
+
+        The signal name was changed in
+        https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
+        as part of GTK 3.99.5.
+
+        Covered by existing tests.
+
+        * UIProcess/API/glib/WebKitUIClient.cpp:
+
 2021-10-15  Alex Christensen  <[email protected]>
 
         Start using adattributiond on iOS

Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (284310 => 284311)


--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp	2021-10-16 09:07:26 UTC (rev 284311)
@@ -208,7 +208,7 @@
 
 #if USE(GTK4)
             auto* surface = gtk_native_get_surface(GTK_NATIVE(window));
-            auto signalID = g_signal_connect(surface, "size-changed", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
+            auto signalID = g_signal_connect(surface, "layout", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
                 if (width == targetGeometry->width && height == targetGeometry->height)
                     RunLoop::current().stop();
             }), &geometry);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to