Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (106726 => 106727)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-02-04 03:50:50 UTC (rev 106726)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-02-04 03:59:10 UTC (rev 106727)
@@ -94,6 +94,20 @@
}
});
+controllers.ExpectedFailures = base.extends(Object, {
+ init: function(model, view, delegate)
+ {
+ this._model = model;
+ this._view = view;
+ this._delegate = delegate;
+ },
+ update: function()
+ {
+ var expectedOrUnexpectedFailures = results.expectedOrUnexpectedFailuresByTest(this._model.resultsByBuilder);
+ this._view.setFailingTests(Object.keys(expectedOrUnexpectedFailures));
+ }
+});
+
var FailureStreamController = base.extends(Object, {
_resultsFilter: null,
_keyFor: function(failureAnalysis) { throw "Not implemented!"; },
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (106726 => 106727)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-02-04 03:50:50 UTC (rev 106726)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-02-04 03:59:10 UTC (rev 106727)
@@ -32,6 +32,7 @@
var g_buildersFailing = null;
var g_unexpectedFailuresController = null;
+var g_failuresController = null;
var g_losingTestCoverageBuilders = null;
@@ -49,6 +50,8 @@
builders.buildersFailingStepRequredForTestCoverage(g_losingTestCoverageBuilders.update.bind(g_losingTestCoverageBuilders));
base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
+ if (g_failuresController)
+ g_failuresController.update();
updating.update('Analyzing test failures ...');
@@ -83,6 +86,7 @@
showResults: function(resultsView)
{
var resultsContainer = onebar.results();
+ console.log(resultsContainer);
$(resultsContainer).empty().append(resultsView);
onebar.select('results');
}
@@ -104,10 +108,11 @@
unexpected.appendChild(g_info);
unexpected.appendChild(unexpectedFailuresView);
- var expected = onebar.expected();
- if (expected) {
- var expectedFailuresView = new ui.failures.List();
- expected.appendChild(expectedFailuresView);
+ var failures = onebar.failures();
+ if (failures) {
+ var failuresView = new ui.failures.List();
+ g_failuresController = new controllers.ExpectedFailures(model.state, failuresView, onebarController);
+ failures.appendChild(failuresView);
}
update();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (106726 => 106727)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2012-02-04 03:50:50 UTC (rev 106726)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2012-02-04 03:59:10 UTC (rev 106727)
@@ -130,7 +130,15 @@
ui.failures.List = base.extends('div', {
init: function()
{
- this.textContent = "TODO: List failures here.";
+ this.textContent = 'Loading...';
+ },
+ setFailingTests: function(failingTestsList)
+ {
+ $(this).empty();
+ var list = this.appendChild(document.createElement('ul'));
+ failingTestsList.sort().forEach(function(failingTest) {
+ list.appendChild(document.createElement('li')).textContent = failingTest;
+ });
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (106726 => 106727)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-02-04 03:50:50 UTC (rev 106726)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js 2012-02-04 03:59:10 UTC (rev 106727)
@@ -64,22 +64,22 @@
this.innerHTML =
'<ul>' +
'<li><a href="" Failures</a></li>' +
- '<li><a href="" Failures</a></li>' +
'<li><a href="" +
'</ul>' +
'<div id="unexpected"></div>' +
- '<div id="expected"></div>' +
+ '<div id="failures"></div>' +
'<div id="results"></div>';
this._tabNames = [
'unexpected',
- 'expected',
'results',
]
this._tabs = $(this).tabs({
- disabled: [2],
+ disabled: [1],
});
- if (!config.kExperimentalFeatures)
- this._tabs.tabs('remove', 1);
+ if (config.kExperimentalFeatures) {
+ this._tabs.tabs('add', '#failures', 'All Failures (experimental)');
+ this._tabNames.push('failures');
+ }
},
attach: function()
{
@@ -87,9 +87,9 @@
},
tabNamed: function(tabName)
{
+ if (this._tabNames.indexOf(tabName) == -1)
+ return null;
tab = document.getElementById(tabName);
- if (!tab)
- return null;
// We perform this sanity check below to make sure getElementById
// hasn't given us a node in some other unrelated part of the document.
// that shouldn't happen normally, but it could happen if an attacker
@@ -102,9 +102,9 @@
{
return this.tabNamed('unexpected');
},
- expected: function()
+ failures: function()
{
- return this.tabNamed('expected');
+ return this.tabNamed('failures');
},
results: function()
{
Modified: trunk/Tools/ChangeLog (106726 => 106727)
--- trunk/Tools/ChangeLog 2012-02-04 03:50:50 UTC (rev 106726)
+++ trunk/Tools/ChangeLog 2012-02-04 03:59:10 UTC (rev 106727)
@@ -1,3 +1,19 @@
+2012-02-03 Adam Barth <[email protected]>
+
+ List of all failures in garden-o-matic should actually list all the failures
+ https://bugs.webkit.org/show_bug.cgi?id=77796
+
+ Reviewed by Eric Seidel.
+
+ This patch wires a bit more data into the new "All Failures" tab. I've
+ also iterated on how we enable this experimental feature. The tab is
+ still just a dumb list, but we'll make it smarter.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+
2012-02-03 Ryosuke Niwa <[email protected]>
Windows build fix after r106692.
