Title: [284515] trunk/Source/WebCore
- Revision
- 284515
- Author
- commit-qu...@webkit.org
- Date
- 2021-10-19 20:03:58 -0700 (Tue, 19 Oct 2021)
Log Message
r284315 can cause build break.
https://bugs.webkit.org/show_bug.cgi?id=231923
Patch by Jigen Zhou <jigen.z...@sony.com> on 2021-10-19
Reviewed by Michael Catanzaro.
Class 'WebCore::RenderBlockFlow' was forward declared in header file
InlineIteratorLogicalOrderTraversal.h, but template
leafBoxesInLogicalOrder that was added by r284315 has access to RenderBlockFLow's method
style() and can cause build break in our local webkit build.
The build can be fixed when the concreate declaration of class
RenderBlockFlow is included in InlineIteratorLogicalOrderTraversal.h.
* layout/integration/InlineIteratorLogicalOrderTraversal.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (284514 => 284515)
--- trunk/Source/WebCore/ChangeLog 2021-10-20 00:58:48 UTC (rev 284514)
+++ trunk/Source/WebCore/ChangeLog 2021-10-20 03:03:58 UTC (rev 284515)
@@ -1,3 +1,20 @@
+2021-10-19 Jigen Zhou <jigen.z...@sony.com>
+
+ r284315 can cause build break.
+ https://bugs.webkit.org/show_bug.cgi?id=231923
+
+ Reviewed by Michael Catanzaro.
+
+ Class 'WebCore::RenderBlockFlow' was forward declared in header file
+ InlineIteratorLogicalOrderTraversal.h, but template
+ leafBoxesInLogicalOrder that was added by r284315 has access to RenderBlockFLow's method
+ style() and can cause build break in our local webkit build.
+
+ The build can be fixed when the concreate declaration of class
+ RenderBlockFlow is included in InlineIteratorLogicalOrderTraversal.h.
+
+ * layout/integration/InlineIteratorLogicalOrderTraversal.h:
+
2021-10-19 Ross Kirsling <ross.kirsl...@sony.com>
[CMake] Align OptionsMac with Xcode build
Modified: trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h (284514 => 284515)
--- trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h 2021-10-20 00:58:48 UTC (rev 284514)
+++ trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h 2021-10-20 03:03:58 UTC (rev 284515)
@@ -27,6 +27,7 @@
#include "InlineIteratorLine.h"
#include "InlineIteratorTextBox.h"
+#include "RenderBlockFlow.h"
namespace WebCore {
namespace InlineIterator {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
