Diff
Modified: trunk/ChangeLog (284602 => 284603)
--- trunk/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,14 @@
+2021-10-21 Chris Lord <[email protected]>
+
+ [WPE][GTK] Enable smooth scrolling by default
+ https://bugs.webkit.org/show_bug.cgi?id=220512
+
+ Reviewed by Carlos Garcia Campos.
+
+ Build smooth scrolling by default on WPE to match other platforms.
+
+ * Source/cmake/OptionsWPE.cmake:
+
2021-10-20 Kimmo Kinnunen <[email protected]>
Add ObjC as supported .clang-format language
Modified: trunk/Source/WTF/ChangeLog (284602 => 284603)
--- trunk/Source/WTF/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WTF/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,14 @@
+2021-10-21 Chris Lord <[email protected]>
+
+ [WPE][GTK] Enable smooth scrolling by default
+ https://bugs.webkit.org/show_bug.cgi?id=220512
+
+ Reviewed by Carlos Garcia Campos.
+
+ Enable smooth scrolling by default on GTK and WPE platforms.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+
2021-10-20 Brady Eidson <[email protected]>
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (284602 => 284603)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1905,10 +1905,10 @@
"PLATFORM(MAC)": true
default: false
WebKit:
- "PLATFORM(MAC)": true
+ "PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)": true
default: false
WebCore:
- "PLATFORM(MAC)": true
+ "PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)": true
default: false
# FIXME: This is handled via WebView SPI rather than WebPreferences for WebKitLegacy. We should change the SPI to lookup the WebPreferences value instead.
Modified: trunk/Source/WebKit/ChangeLog (284602 => 284603)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,15 @@
+2021-10-21 Chris Lord <[email protected]>
+
+ [WPE][GTK] Enable smooth scrolling by default
+ https://bugs.webkit.org/show_bug.cgi?id=220512
+
+ Reviewed by Carlos Garcia Campos.
+
+ Enable smooth scrolling by default on GTK and WPE platforms.
+
+ * UIProcess/API/glib/WebKitSettings.cpp:
+ (webkit_settings_class_init):
+
2021-10-20 Brady Eidson <[email protected]>
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (284602 => 284603)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1252,7 +1252,7 @@
"enable-smooth-scrolling",
_("Enable smooth scrolling"),
_("Whether to enable smooth scrolling"),
- FALSE,
+ TRUE,
readWriteConstructParamFlags);
/**
Modified: trunk/Source/cmake/OptionsWPE.cmake (284602 => 284603)
--- trunk/Source/cmake/OptionsWPE.cmake 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/cmake/OptionsWPE.cmake 2021-10-21 14:09:08 UTC (rev 284603)
@@ -64,7 +64,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
Modified: trunk/Tools/ChangeLog (284602 => 284603)
--- trunk/Tools/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Tools/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,16 @@
+2021-10-21 Chris Lord <[email protected]>
+
+ [WPE][GTK] Enable smooth scrolling by default
+ https://bugs.webkit.org/show_bug.cgi?id=220512
+
+ Reviewed by Carlos Garcia Campos.
+
+ Smooth scrolling is default on on GTK now, so reverse the logic in the
+ test for the efficacy of the related setting.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+ (testWebKitSettings):
+
2021-10-21 Sam Sneddon <[email protected]>
Move layout_test_finder to layout_test_finder_legacy
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (284602 => 284603)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp 2021-10-21 14:09:08 UTC (rev 284603)
@@ -276,10 +276,10 @@
webkit_settings_set_enable_page_cache(settings, FALSE);
g_assert_false(webkit_settings_get_enable_page_cache(settings));
- // By default, smooth scrolling is disabled.
+ // By default, smooth scrolling is enabled.
+ g_assert_true(webkit_settings_get_enable_smooth_scrolling(settings));
+ webkit_settings_set_enable_smooth_scrolling(settings, FALSE);
g_assert_false(webkit_settings_get_enable_smooth_scrolling(settings));
- webkit_settings_set_enable_smooth_scrolling(settings, TRUE);
- g_assert_true(webkit_settings_get_enable_smooth_scrolling(settings));
// By default, writing of console messages to stdout is disabled.
g_assert_false(webkit_settings_get_enable_write_console_messages_to_stdout(settings));
