Title: [284605] trunk/Tools
- Revision
- 284605
- Author
- [email protected]
- Date
- 2021-10-21 09:17:10 -0700 (Thu, 21 Oct 2021)
Log Message
run-webkit-tests --ios-simulator --print-expectations fails
https://bugs.webkit.org/show_bug.cgi?id=232035
Reviewed by Jonathan Bedard.
self._port.supported_device_types(), which _collect_tests() uses (despite its argument)
returns a different set of devices than self._port.DEFAULT_DEVICE_TYPES which caused
using those as hash keys to throw. So have print_expectations() and print_summary()
just use self._port.supported_device_types().
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.print_expectations):
(Manager.print_summary):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284604 => 284605)
--- trunk/Tools/ChangeLog 2021-10-21 14:29:14 UTC (rev 284604)
+++ trunk/Tools/ChangeLog 2021-10-21 16:17:10 UTC (rev 284605)
@@ -1,3 +1,19 @@
+2021-10-21 Simon Fraser <[email protected]>
+
+ run-webkit-tests --ios-simulator --print-expectations fails
+ https://bugs.webkit.org/show_bug.cgi?id=232035
+
+ Reviewed by Jonathan Bedard.
+
+ self._port.supported_device_types(), which _collect_tests() uses (despite its argument)
+ returns a different set of devices than self._port.DEFAULT_DEVICE_TYPES which caused
+ using those as hash keys to throw. So have print_expectations() and print_summary()
+ just use self._port.supported_device_types().
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager.print_expectations):
+ (Manager.print_summary):
+
2021-10-21 Chris Lord <[email protected]>
[WPE][GTK] Enable smooth scrolling by default
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (284604 => 284605)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2021-10-21 14:29:14 UTC (rev 284604)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2021-10-21 16:17:10 UTC (rev 284605)
@@ -756,7 +756,7 @@
self._print_expectation_line_for_test(format_string, test, device_type=device_type)
def print_expectations(self, args):
- device_type_list = self._port.DEFAULT_DEVICE_TYPES or [self._port.DEVICE_TYPE]
+ device_type_list = self._port.supported_device_types()
try:
tests_to_run_by_device, aggregate_tests_to_skip = self._collect_tests(args, device_type_list)
@@ -780,7 +780,7 @@
return 0
def print_summary(self, args):
- device_type_list = self._port.DEFAULT_DEVICE_TYPES or [self._port.DEVICE_TYPE]
+ device_type_list = self._port.supported_device_types()
test_stats = {}
try:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
