Title: [284649] trunk/Source/WebKit
- Revision
- 284649
- Author
- [email protected]
- Date
- 2021-10-21 15:28:30 -0700 (Thu, 21 Oct 2021)
Log Message
PCM: Add temporary logging when isRunningTest() assertion is about to fail to be able to investigate
https://bugs.webkit.org/show_bug.cgi?id=232108
Unreviewed. Just adding logging for test-only functionality.
This patch adds logging to when we are about to fail the assert of isRunningTest() in
WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting)(). This is
added to help investigate https://bugs.webkit.org/show_bug.cgi?id=232048.
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (284648 => 284649)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 21:49:28 UTC (rev 284648)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 22:28:30 UTC (rev 284649)
@@ -1,3 +1,17 @@
+2021-10-21 John Wilander <[email protected]>
+
+ PCM: Add temporary logging when isRunningTest() assertion is about to fail to be able to investigate
+ https://bugs.webkit.org/show_bug.cgi?id=232108
+
+ Unreviewed. Just adding logging for test-only functionality.
+
+ This patch adds logging to when we are about to fail the assert of isRunningTest() in
+ WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting)(). This is
+ added to help investigate https://bugs.webkit.org/show_bug.cgi?id=232048.
+
+ * NetworkProcess/NetworkSession.cpp:
+ (WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
+
2021-10-21 Simon Fraser <[email protected]>
Rare crash under DisplayLink::displayLinkCallback()
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp (284648 => 284649)
--- trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-21 21:49:28 UTC (rev 284648)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-21 22:28:30 UTC (rev 284649)
@@ -455,6 +455,10 @@
void NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting(String&& appBundleIDForTesting)
{
#if PLATFORM(COCOA)
+ // FIXME: Remove this logging once https://bugs.webkit.org/show_bug.cgi?id=232048 has been resolved.
+ auto appBundleID = WebCore::applicationBundleIdentifier();
+ if (!isRunningTest(appBundleID))
+ WTFLogAlways("isRunningTest() returned false. appBundleID is %s.", appBundleID.isEmpty() ? "empty" : appBundleID.utf8().data());
RELEASE_ASSERT(isRunningTest(WebCore::applicationBundleIdentifier()));
#endif
privateClickMeasurement().setPrivateClickMeasurementAppBundleIDForTesting(WTFMove(appBundleIDForTesting));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
