Title: [284694] trunk/Source/WebCore
- Revision
- 284694
- Author
- [email protected]
- Date
- 2021-10-22 11:03:34 -0700 (Fri, 22 Oct 2021)
Log Message
Remove release assertion in MediaResourceClient::responseReceived
https://bugs.webkit.org/show_bug.cgi?id=232121
Patch by Alex Christensen <[email protected]> on 2021-10-22
Reviewed by David Kilzer.
I tried and was unable to reproduce this, even with multipart responses which can call didReceiveResponse multiple times in the same load.
In any case, it's clear where the crash is and that this assertion can be hit. Not continuing with the response is better than crashing.
Keep the debug assertion because if it is hit, we want to notice.
* platform/network/cocoa/RangeResponseGenerator.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (284693 => 284694)
--- trunk/Source/WebCore/ChangeLog 2021-10-22 16:56:35 UTC (rev 284693)
+++ trunk/Source/WebCore/ChangeLog 2021-10-22 18:03:34 UTC (rev 284694)
@@ -1,3 +1,16 @@
+2021-10-22 Alex Christensen <[email protected]>
+
+ Remove release assertion in MediaResourceClient::responseReceived
+ https://bugs.webkit.org/show_bug.cgi?id=232121
+
+ Reviewed by David Kilzer.
+
+ I tried and was unable to reproduce this, even with multipart responses which can call didReceiveResponse multiple times in the same load.
+ In any case, it's clear where the crash is and that this assertion can be hit. Not continuing with the response is better than crashing.
+ Keep the debug assertion because if it is hit, we want to notice.
+
+ * platform/network/cocoa/RangeResponseGenerator.mm:
+
2021-10-22 Antti Koivisto <[email protected]>
Factor style resolver context arguments into a struct
Modified: trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm (284693 => 284694)
--- trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm 2021-10-22 16:56:35 UTC (rev 284693)
+++ trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm 2021-10-22 18:03:34 UTC (rev 284694)
@@ -213,7 +213,7 @@
// These methods should have been called before changing the client to this.
void responseReceived(PlatformMediaResource&, const ResourceResponse&, CompletionHandler<void(ShouldContinuePolicyCheck)>&& completionHandler) final
{
- RELEASE_ASSERT_NOT_REACHED();
+ ASSERT_NOT_REACHED();
completionHandler(ShouldContinuePolicyCheck::No);
}
void redirectReceived(PlatformMediaResource&, ResourceRequest&&, const ResourceResponse&, CompletionHandler<void(ResourceRequest&&)>&& completionHandler) final
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
