Title: [284723] trunk/LayoutTests
- Revision
- 284723
- Author
- [email protected]
- Date
- 2021-10-22 15:53:43 -0700 (Fri, 22 Oct 2021)
Log Message
Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
https://bugs.webkit.org/show_bug.cgi?id=232151
<rdar://problem/84552682>
Reviewed by Ryan Haddad.
The test expects a CONSOLE message to get logged to indicate that a load was blocked.
Rely on `internals.setConsoleMessageListener` to wait for this CONSOLE message instead
of using a timer in order the address the flakiness.
* http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (284722 => 284723)
--- trunk/LayoutTests/ChangeLog 2021-10-22 22:44:33 UTC (rev 284722)
+++ trunk/LayoutTests/ChangeLog 2021-10-22 22:53:43 UTC (rev 284723)
@@ -1,3 +1,19 @@
+2021-10-22 Chris Dumez <[email protected]>
+
+ Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=232151
+ <rdar://problem/84552682>
+
+ Reviewed by Ryan Haddad.
+
+ The test expects a CONSOLE message to get logged to indicate that a load was blocked.
+ Rely on `internals.setConsoleMessageListener` to wait for this CONSOLE message instead
+ of using a timer in order the address the flakiness.
+
+ * http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html:
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+
2021-10-22 Ryan Haddad <[email protected]>
[iOS EWS] imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker.html is a flaky failure
Modified: trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html (284722 => 284723)
--- trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html 2021-10-22 22:44:33 UTC (rev 284722)
+++ trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html 2021-10-22 22:53:43 UTC (rev 284723)
@@ -25,7 +25,13 @@
clickEvent.initEvent("click", true, true);
theLink.dispatchEvent(clickEvent);
- setTimeout(wrapUp, 500);
+ var iframeContentWindow = document.getElementById("theIframe").contentWindow;
+ if (iframeContentWindow.internals) {
+ iframeContentWindow.internals.setConsoleMessageListener((msg) => {
+ setTimeout(wrapUp, 0);
+ });
+ } else
+ setTimeout(wrapUp, 1000);
}
</script>
<iframe _onload_="run()" id="theIframe" sandbox="allow-same-origin allow-popups" src=""
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284722 => 284723)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-22 22:44:33 UTC (rev 284722)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-22 22:53:43 UTC (rev 284723)
@@ -2231,6 +2231,4 @@
webkit.org/b/232120 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html [ Pass Failure DumpJSConsoleLogInStdErr ]
-webkit.org/b/232151 http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Failure ]
-
webkit.org/b/225528 http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ]
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284722 => 284723)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-22 22:44:33 UTC (rev 284722)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-22 22:53:43 UTC (rev 284723)
@@ -1171,9 +1171,6 @@
# <rdar://problem/61463671> [ macOS wk2 ] tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html is a flaky failure
[ Mojave ] tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html [ Pass Failure ]
-# <rdar://problem/61833992> REGRESSION: (20A267) http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html
-[ BigSur+ ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Pass Failure ]
-
# <rdar://problem/63626512> REGRESSION(20A279-20A291a): webrtc/simulcast-h264.html is a constant timeout
webrtc/simulcast-h264.html [ Pass Timeout ]
@@ -1689,4 +1686,3 @@
webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ]
-webkit.org/b/232151 [ BigSur Debug ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes