Title: [284770] trunk/Source/WebCore
- Revision
- 284770
- Author
- [email protected]
- Date
- 2021-10-24 17:04:12 -0700 (Sun, 24 Oct 2021)
Log Message
Fix typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()
https://bugs.webkit.org/show_bug.cgi?id=232194
Reviewed by Darin Adler.
Reset video tracks' properties when video tracks are changing rather
than the audio ones.
There should be no observable changes, resetting the audio track properties
would have been a no-op as AudioTrackPrivateAVFObjC is just a wrapper around
AVPlayerItemTrack and properties are kept in sync thorough playback.
Not calling resetPropertiesFromTrack on the video track wouldn't have mattered
as the operation is called when the track is constructed above in the
determineChangedTracksFromNewTracksAndOldItems method.
So this code only improves readability, and could be removed entirely.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (284769 => 284770)
--- trunk/Source/WebCore/ChangeLog 2021-10-24 22:28:37 UTC (rev 284769)
+++ trunk/Source/WebCore/ChangeLog 2021-10-25 00:04:12 UTC (rev 284770)
@@ -1,3 +1,25 @@
+2021-10-24 Jean-Yves Avenard <[email protected]>
+
+ Fix typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()
+ https://bugs.webkit.org/show_bug.cgi?id=232194
+
+ Reviewed by Darin Adler.
+
+ Reset video tracks' properties when video tracks are changing rather
+ than the audio ones.
+
+ There should be no observable changes, resetting the audio track properties
+ would have been a no-op as AudioTrackPrivateAVFObjC is just a wrapper around
+ AVPlayerItemTrack and properties are kept in sync thorough playback.
+ Not calling resetPropertiesFromTrack on the video track wouldn't have mattered
+ as the operation is called when the track is constructed above in the
+ determineChangedTracksFromNewTracksAndOldItems method.
+ So this code only improves readability, and could be removed entirely.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
+ * platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
+
2021-10-24 Tyler Wilcock <[email protected]>
AX: AccessibilityObject::m_haveChildren and AXCoreObject::hasChildren() are misleadingly named
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (284769 => 284770)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-10-24 22:28:37 UTC (rev 284769)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-10-25 00:04:12 UTC (rev 284770)
@@ -2376,7 +2376,7 @@
if (m_visualGroup)
determineChangedTracksFromNewTracksAndOldItems(m_visualGroup.get(), m_videoTracks, Vector<String>(), &VideoTrackPrivateAVFObjC::create, player(), &MediaPlayer::removeVideoTrack, &MediaPlayer::addVideoTrack);
- for (auto& track : m_audioTracks)
+ for (auto& track : m_videoTracks)
track->resetPropertiesFromTrack();
// In case the video track content changed, we may be able to perform a readback again.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h (284769 => 284770)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h 2021-10-24 22:28:37 UTC (rev 284769)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h 2021-10-25 00:04:12 UTC (rev 284770)
@@ -71,6 +71,7 @@
MediaSelectionOptionAVFObjC* mediaSelectionOption();
private:
+ friend class MediaPlayerPrivateAVFoundationObjC;
explicit VideoTrackPrivateAVFObjC(AVPlayerItemTrack*);
explicit VideoTrackPrivateAVFObjC(AVAssetTrack*);
explicit VideoTrackPrivateAVFObjC(MediaSelectionOptionAVFObjC&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
