Title: [106773] trunk/Source/WebCore
Revision
106773
Author
[email protected]
Date
2012-02-05 20:47:11 -0800 (Sun, 05 Feb 2012)

Log Message

Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* css/CSSStyleDeclaration.idl:
* html/HTMLDocument.idl:
* html/canvas/DataView.idl:
* page/DOMWindow.idl:
* page/MemoryInfo.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DOMWindowWebAudio.idl:
* webaudio/WaveShaperNode.idl:
* websockets/DOMWindowWebSocket.idl:
* workers/WorkerContext.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (106772 => 106773)


--- trunk/Source/WebCore/ChangeLog	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/ChangeLog	2012-02-06 04:47:11 UTC (rev 106773)
@@ -1,3 +1,30 @@
+2012-02-05  Kentaro Hara  <[email protected]>
+
+        Rename [JSCCustom*] IDL to [JSCustom*] IDL
+        https://bugs.webkit.org/show_bug.cgi?id=77844
+
+        Reviewed by Adam Barth.
+
+        Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
+        [JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
+        [JSCustomSetter].
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader):
+        (GenerateImplementation):
+        * css/CSSStyleDeclaration.idl:
+        * html/HTMLDocument.idl:
+        * html/canvas/DataView.idl:
+        * page/DOMWindow.idl:
+        * page/MemoryInfo.idl:
+        * webaudio/ConvolverNode.idl:
+        * webaudio/DOMWindowWebAudio.idl:
+        * webaudio/WaveShaperNode.idl:
+        * websockets/DOMWindowWebSocket.idl:
+        * workers/WorkerContext.idl:
+
 2012-02-05  ChangSeok Oh  <[email protected]>
 
         [EFL] Enable WebGL with glx backend

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (106772 => 106773)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-06 04:47:11 UTC (rev 106773)
@@ -857,9 +857,9 @@
     if ($numAttributes > 0) {
         foreach (@{$dataNode->attributes}) {
             my $attribute = $_;
-            $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"};
-            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"});
-            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"});
+            $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"};
+            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"});
+            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"});
             if ($attribute->signature->extendedAttributes->{"CachedAttribute"}) {
                 push(@headerContent, "    JSC::WriteBarrier<JSC::Unknown> m_" . $attribute->signature->name . ";\n");
                 $numCachedAttributes++;
@@ -878,24 +878,24 @@
         push(@headerContent, "\n    // Custom attributes\n");
 
         foreach my $attribute (@{$dataNode->attributes}) {
-            if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"}) {
+            if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"}) {
                 my $methodName = $codeGenerator->WK_lcfirst($attribute->signature->name);
                 push(@headerContent, "    JSC::JSValue " . $methodName . "(JSC::ExecState*) const;\n");
             }
-            if (($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"}) && $attribute->type !~ /^readonly/) {
+            if (($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"}) && $attribute->type !~ /^readonly/) {
                 push(@headerContent, "    void set" . $codeGenerator->WK_ucfirst($attribute->signature->name) . "(JSC::ExecState*, JSC::JSValue);\n");
             }
         }
     }
 
     foreach my $function (@{$dataNode->functions}) {
-        $numCustomFunctions++ if $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCCustom"};
+        $numCustomFunctions++ if $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCustom"};
     }
 
     if ($numCustomFunctions > 0) {
         push(@headerContent, "\n    // Custom functions\n");
         foreach my $function (@{$dataNode->functions}) {
-            next unless $function->signature->extendedAttributes->{"Custom"} or $function->signature->extendedAttributes->{"JSCCustom"};
+            next unless $function->signature->extendedAttributes->{"Custom"} or $function->signature->extendedAttributes->{"JSCustom"};
             next if $function->{overloads} && $function->{overloadIndex} != 1;
             my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementationFunction"} || $codeGenerator->WK_lcfirst($function->signature->name);
             push(@headerContent, "    JSC::JSValue " . $functionImplementationName . "(JSC::ExecState*);\n");
@@ -1695,7 +1695,7 @@
                     push(@implContent, "        return jsUndefined();\n");
                 }
 
-                if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"}) {
+                if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"}) {
                     push(@implContent, "    return castedThis->$implGetterFunctionName(exec);\n");
                 } elsif ($attribute->signature->extendedAttributes->{"CheckAccessToNode"}) {
                     $implIncludes{"JSDOMBinding.h"} = 1;
@@ -1894,7 +1894,7 @@
                             push(@implContent, "        return;\n");
                         }
 
-                        if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"}) {
+                        if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"}) {
                             push(@implContent, "    static_cast<$className*>(thisObject)->set$implSetterFunctionName(exec, value);\n");
                         } elsif ($type eq "EventListener") {
                             $implIncludes{"JSEventListener.h"} = 1;
@@ -2058,7 +2058,7 @@
         foreach my $function (@{$dataNode->functions}) {
             AddIncludesForTypeInImpl($function->signature->type);
 
-            my $isCustom = $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCCustom"};
+            my $isCustom = $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCustom"};
             my $isOverloaded = $function->{overloads} && @{$function->{overloads}} > 1;
 
             next if $isCustom && $isOverloaded && $function->{overloadIndex} > 1;

Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.idl (106772 => 106773)


--- trunk/Source/WebCore/css/CSSStyleDeclaration.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -34,7 +34,7 @@
                      setter raises(DOMException);
 
         [ConvertNullStringTo=Null] DOMString          getPropertyValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
-        [JSCCustom] CSSValue           getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
+        [JSCustom] CSSValue           getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
         [ConvertNullStringTo=Null] DOMString          removeProperty(in [Optional=CallWithDefaultValue] DOMString propertyName)
             raises(DOMException);
         [ConvertNullStringTo=Null] DOMString          getPropertyPriority(in [Optional=CallWithDefaultValue] DOMString propertyName);

Modified: trunk/Source/WebCore/html/HTMLDocument.idl (106772 => 106773)


--- trunk/Source/WebCore/html/HTMLDocument.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/html/HTMLDocument.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -23,7 +23,7 @@
     interface [
         HasOverridingNameGetter
     ] HTMLDocument : Document {
-        [JSCCustom, V8Custom] void open();
+        [JSCustom, V8Custom] void open();
         void close();
         [Custom] void write(in [Optional=CallWithDefaultValue] DOMString text);
         [Custom] void writeln(in [Optional=CallWithDefaultValue] DOMString text);

Modified: trunk/Source/WebCore/html/canvas/DataView.idl (106772 => 106773)


--- trunk/Source/WebCore/html/canvas/DataView.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/html/canvas/DataView.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -50,9 +50,9 @@
             raises (DOMException);
 
         // Use custom code to handle NaN case for JSC.
-        [JSCCustom, StrictTypeChecking] float getFloat32(in unsigned long byteOffset, in [Optional] boolean littleEndian)
+        [JSCustom, StrictTypeChecking] float getFloat32(in unsigned long byteOffset, in [Optional] boolean littleEndian)
             raises (DOMException);
-        [JSCCustom, StrictTypeChecking] double getFloat64(in unsigned long byteOffset, in [Optional] boolean littleEndian)
+        [JSCustom, StrictTypeChecking] double getFloat64(in unsigned long byteOffset, in [Optional] boolean littleEndian)
             raises (DOMException);
 
         // We have to use custom code because our code generator does not support uint8_t type.

Modified: trunk/Source/WebCore/page/DOMWindow.idl (106772 => 106773)


--- trunk/Source/WebCore/page/DOMWindow.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -44,7 +44,7 @@
     ] DOMWindow {
         // DOM Level 0
         attribute [Replaceable] Screen screen;
-        attribute [Replaceable, DoNotCheckDomainSecurityOnGet, JSCCustomGetter] History history;
+        attribute [Replaceable, DoNotCheckDomainSecurityOnGet, JSCustomGetter] History history;
         attribute [Replaceable] BarInfo locationbar;
         attribute [Replaceable] BarInfo menubar;
         attribute [Replaceable] BarInfo personalbar;
@@ -54,7 +54,7 @@
         attribute [Replaceable] Navigator navigator;
         attribute [Replaceable] Navigator clientInformation;
         readonly attribute Crypto crypto;
-        attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
+        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
 
         attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
 
@@ -472,8 +472,8 @@
         attribute [Conditional=MICRODATA] HTMLPropertiesCollectionConstructor HTMLPropertiesCollection;
         attribute HTMLUnknownElementConstructor HTMLUnknownElement;
 
-        attribute [JSCCustomGetter, CustomConstructor] HTMLImageElementConstructorConstructor Image; // Usable with new operator
-        attribute [JSCCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
+        attribute [JSCustomGetter, CustomConstructor] HTMLImageElementConstructorConstructor Image; // Usable with new operator
+        attribute [JSCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
 
         attribute CanvasPatternConstructor CanvasPattern;
         attribute CanvasGradientConstructor CanvasGradient;
@@ -579,7 +579,7 @@
 #endif
 
 #if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
-        attribute [JSCCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
+        attribute [JSCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
 #endif
 
 #if defined(ENABLE_VIDEO_TRACK) && ENABLE_VIDEO_TRACK
@@ -602,7 +602,7 @@
 
         attribute StorageConstructor Storage;
 
-        attribute [JSCCustomGetter, Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructorConstructor Audio; // Usable with the new operator
+        attribute [JSCustomGetter, Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructorConstructor Audio; // Usable with the new operator
         attribute [Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructor HTMLAudioElement;
         attribute [Conditional=VIDEO, V8EnabledAtRuntime] HTMLMediaElementConstructor HTMLMediaElement;
         attribute [Conditional=VIDEO, V8EnabledAtRuntime] HTMLVideoElementConstructor HTMLVideoElement;

Modified: trunk/Source/WebCore/page/MemoryInfo.idl (106772 => 106773)


--- trunk/Source/WebCore/page/MemoryInfo.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/page/MemoryInfo.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -36,7 +36,7 @@
 
         readonly attribute unsigned long totalJSHeapSize;
         readonly attribute unsigned long usedJSHeapSize;
-        readonly attribute [JSCCustomGetter] unsigned long jsHeapSizeLimit;
+        readonly attribute [JSCustomGetter] unsigned long jsHeapSizeLimit;
 
     };
 

Modified: trunk/Source/WebCore/webaudio/ConvolverNode.idl (106772 => 106773)


--- trunk/Source/WebCore/webaudio/ConvolverNode.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/webaudio/ConvolverNode.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -28,7 +28,7 @@
         Conditional=WEB_AUDIO,
         JSGenerateToJS
     ] ConvolverNode : AudioNode {
-        attribute [JSCCustomSetter] AudioBuffer buffer;
+        attribute [JSCustomSetter] AudioBuffer buffer;
         attribute boolean normalize;
     };
 }

Modified: trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl (106772 => 106773)


--- trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -24,7 +24,7 @@
         Supplemental=DOMWindow
     ] DOMWindowWebAudio {
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
-        attribute [JSCCustomGetter, V8EnabledAtRuntime] AudioContextConstructor webkitAudioContext;
+        attribute [JSCustomGetter, V8EnabledAtRuntime] AudioContextConstructor webkitAudioContext;
         attribute AudioPannerNodeConstructor webkitAudioPannerNode;
         attribute AudioProcessingEventConstructor AudioProcessingEvent;
         attribute OfflineAudioCompletionEventConstructor OfflineAudioCompletionEvent;

Modified: trunk/Source/WebCore/webaudio/WaveShaperNode.idl (106772 => 106773)


--- trunk/Source/WebCore/webaudio/WaveShaperNode.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/webaudio/WaveShaperNode.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -27,6 +27,6 @@
         Conditional=WEB_AUDIO,
         JSGenerateToJS
     ] WaveShaperNode : AudioNode {
-        attribute [JSCCustomSetter] Float32Array curve;
+        attribute [JSCustomSetter] Float32Array curve;
     };
 }

Modified: trunk/Source/WebCore/websockets/DOMWindowWebSocket.idl (106772 => 106773)


--- trunk/Source/WebCore/websockets/DOMWindowWebSocket.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/websockets/DOMWindowWebSocket.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -36,7 +36,7 @@
     ] DOMWindowWebSocket {
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
         attribute CloseEventConstructor CloseEvent;
-        attribute [JSCCustomGetter, V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
+        attribute [JSCustomGetter, V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
 #endif
     };
 

Modified: trunk/Source/WebCore/workers/WorkerContext.idl (106772 => 106773)


--- trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-06 04:01:42 UTC (rev 106772)
+++ trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-06 04:47:11 UTC (rev 106773)
@@ -86,12 +86,12 @@
         attribute WorkerLocationConstructor WorkerLocation;
 
 #if ENABLE_CHANNEL_MESSAGING
-        attribute [JSCCustomGetter] MessageChannelConstructor MessageChannel;
+        attribute [JSCustomGetter] MessageChannelConstructor MessageChannel;
 #endif
-        attribute [JSCCustomGetter] EventSourceConstructor EventSource;
-        attribute [JSCCustomGetter] XMLHttpRequestConstructor XMLHttpRequest;
+        attribute [JSCustomGetter] EventSourceConstructor EventSource;
+        attribute [JSCustomGetter] XMLHttpRequestConstructor XMLHttpRequest;
 #if defined(ENABLE_WEB_SOCKETS) && ENABLE_WEB_SOCKETS
-        attribute [JSCCustomGetter,V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
+        attribute [JSCustomGetter,V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
 #endif
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to