Modified: trunk/LayoutTests/ChangeLog (284773 => 284774)
--- trunk/LayoutTests/ChangeLog 2021-10-25 08:35:23 UTC (rev 284773)
+++ trunk/LayoutTests/ChangeLog 2021-10-25 08:58:38 UTC (rev 284774)
@@ -1,3 +1,15 @@
+2021-10-25 Tim Nguyen <[email protected]>
+
+ Fix imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html flaky failure on macOS wk1
+ https://bugs.webkit.org/show_bug.cgi?id=231647
+
+ Reviewed by Antti Koivisto.
+
+ This only tests a CSS selector feature, use `waitUntilStableAutofocusState()` helper which is more stable on wk1
+ to make this test pass.
+
+ * platform/mac-wk1/TestExpectations:
+
2021-10-25 Ziran Sun <[email protected]>
[css-writing-modes] Fix sizing of orthogonal elements with percentage margins
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284773 => 284774)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-25 08:35:23 UTC (rev 284773)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-25 08:58:38 UTC (rev 284774)
@@ -1,3 +1,15 @@
+2021-10-25 Tim Nguyen <[email protected]>
+
+ Fix imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html flaky failure on macOS wk1
+ https://bugs.webkit.org/show_bug.cgi?id=231647
+
+ Reviewed by Antti Koivisto.
+
+ This only tests a CSS selector feature, use `waitUntilStableAutofocusState()` helper which is more stable on wk1
+ to make this test pass.
+
+ * web-platform-tests/css/selectors/focus-visible-009.html:
+
2021-10-24 Alexey Shvayka <[email protected]>
Assertions in IDBTransaction::request*() methods fail on cross-realm methods
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html (284773 => 284774)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html 2021-10-25 08:35:23 UTC (rev 284773)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html 2021-10-25 08:58:38 UTC (rev 284774)
@@ -7,6 +7,7 @@
<link rel="help" href="" />
<script src=""
<script src=""
+ <script src=""
<style>
@supports not selector(:focus-visible) {
#button:focus {
@@ -33,20 +34,11 @@
<br />
<button id="button" autofocus tabindex="-1">I will be focused automatically.</button>
<script>
- async_test(function(t) {
- button.addEventListener("focus", t.step_func(function() {
- assert_equals(getComputedStyle(button).outlineColor, "rgb(0, 128, 0)", `outlineColor for ${button.tagName}#${button.id} should be green`);
- assert_not_equals(getComputedStyle(button).backgroundColor, "rgb(255, 0, 0)", `backgroundColor for ${button.tagName}#${button.id} should NOT be red`);
- t.done();
- }));
-
- // Handle the case where the button is focused before the test runs.
- if (document.activeElement === button) {
- assert_equals(getComputedStyle(button).outlineColor, "rgb(0, 128, 0)", `outlineColor for ${button.tagName}#${button.id} should be green`);
- assert_not_equals(getComputedStyle(button).backgroundColor, "rgb(255, 0, 0)", `backgroundColor for ${button.tagName}#${button.id} should NOT be red`);
- t.done();
- }
-
+ promise_test(async function() {
+ await waitUntilStableAutofocusState();
+ assert_equals(document.activeElement, button, "Should have correct focused element");
+ assert_equals(getComputedStyle(button).outlineColor, "rgb(0, 128, 0)", `outlineColor for ${button.tagName}#${button.id} should be green`);
+ assert_not_equals(getComputedStyle(button).backgroundColor, "rgb(255, 0, 0)", `backgroundColor for ${button.tagName}#${button.id} should NOT be red`);
}, "Autofocus should match :focus-visible");
</script>
</body>
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (284773 => 284774)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-25 08:35:23 UTC (rev 284773)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-10-25 08:58:38 UTC (rev 284774)
@@ -690,8 +690,6 @@
webkit.org/b/172807 imported/w3c/web-platform-tests/css/selectors/focus-display-none-001.html [ Pass Failure ]
webkit.org/b/172807 imported/w3c/web-platform-tests/css/selectors/focus-within-display-none-001.html [ Pass Failure ]
-webkit.org/b/231647 imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html [ Pass Failure ]
-
webkit.org/b/168409 media/modern-media-controls/airplay-button/airplay-button.html [ Pass Timeout ]
webkit.org/b/168265 media/modern-media-controls/forward-button/forward-button.html [ Pass Timeout ]
