Title: [284798] trunk/Source/WebCore
- Revision
- 284798
- Author
- [email protected]
- Date
- 2021-10-25 11:04:45 -0700 (Mon, 25 Oct 2021)
Log Message
Remove childrenInitialized() from the AXCoreObject interface.
https://bugs.webkit.org/show_bug.cgi?id=232241
<rdar://problem/84613750>
Reviewed by Chris Fleizach.
Follow up to https://bugs.webkit.org/show_bug.cgi?id=232130
AXCoreObject::childrenInitialized is an internal housekeeping method to
the AccessibilityObject class hierarchy, thus it is unnecessary to
expose in the AXCoreObject interface.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenInitialized const):
* accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::isDescendantOfObject const): No need to check
for childrenInitialized in this function.
* accessibility/isolatedtree/AXIsolatedObject.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (284797 => 284798)
--- trunk/Source/WebCore/ChangeLog 2021-10-25 18:00:49 UTC (rev 284797)
+++ trunk/Source/WebCore/ChangeLog 2021-10-25 18:04:45 UTC (rev 284798)
@@ -1,3 +1,24 @@
+2021-10-25 Andres Gonzalez <[email protected]>
+
+ Remove childrenInitialized() from the AXCoreObject interface.
+ https://bugs.webkit.org/show_bug.cgi?id=232241
+ <rdar://problem/84613750>
+
+ Reviewed by Chris Fleizach.
+
+ Follow up to https://bugs.webkit.org/show_bug.cgi?id=232130
+
+ AXCoreObject::childrenInitialized is an internal housekeeping method to
+ the AccessibilityObject class hierarchy, thus it is unnecessary to
+ expose in the AXCoreObject interface.
+
+ * accessibility/AccessibilityObject.h:
+ (WebCore::AccessibilityObject::childrenInitialized const):
+ * accessibility/AccessibilityObjectInterface.h:
+ (WebCore::AXCoreObject::isDescendantOfObject const): No need to check
+ for childrenInitialized in this function.
+ * accessibility/isolatedtree/AXIsolatedObject.h:
+
2021-10-25 Tyler Wilcock <[email protected]>
AX: Keyboard-focusable leaf nodes with labels should be accessible elements on iOS
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (284797 => 284798)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2021-10-25 18:00:49 UTC (rev 284797)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2021-10-25 18:04:45 UTC (rev 284798)
@@ -495,7 +495,6 @@
void insertChild(AXCoreObject*, unsigned, DescendIfIgnored = DescendIfIgnored::Yes) override;
bool canHaveChildren() const override { return true; }
- bool childrenInitialized() const override { return m_childrenInitialized; }
void updateChildrenIfNecessary() override;
void setNeedsToUpdateChildren() override { }
void setNeedsToUpdateSubtree() override { }
@@ -810,6 +809,7 @@
AXID m_id { 0 };
protected: // FIXME: Make the data members private.
+ bool childrenInitialized() const { return m_childrenInitialized; }
AccessibilityChildrenVector m_children;
mutable bool m_childrenInitialized { false };
AccessibilityRole m_role { AccessibilityRole::Unknown };
Modified: trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h (284797 => 284798)
--- trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h 2021-10-25 18:00:49 UTC (rev 284797)
+++ trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h 2021-10-25 18:04:45 UTC (rev 284798)
@@ -1249,7 +1249,6 @@
Vector<AXID> childrenIDs();
virtual bool canHaveChildren() const = 0;
- virtual bool childrenInitialized() const = 0;
virtual void updateChildrenIfNecessary() = 0;
virtual void setNeedsToUpdateChildren() = 0;
virtual void setNeedsToUpdateSubtree() = 0;
@@ -1625,8 +1624,7 @@
inline bool AXCoreObject::isDescendantOfObject(const AXCoreObject* axObject) const
{
- return axObject && axObject->childrenInitialized()
- && Accessibility::findAncestor<AXCoreObject>(*this, false, [axObject] (const AXCoreObject& object) {
+ return axObject && Accessibility::findAncestor<AXCoreObject>(*this, false, [axObject] (const AXCoreObject& object) {
return &object == axObject;
}) != nullptr;
}
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h (284797 => 284798)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h 2021-10-25 18:00:49 UTC (rev 284797)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h 2021-10-25 18:04:45 UTC (rev 284798)
@@ -610,7 +610,6 @@
void addChild(AXCoreObject*, DescendIfIgnored = DescendIfIgnored::Yes) override;
void insertChild(AXCoreObject*, unsigned, DescendIfIgnored = DescendIfIgnored::Yes) override;
bool canHaveChildren() const override;
- bool childrenInitialized() const override { return true; }
void setNeedsToUpdateChildren() override;
void setNeedsToUpdateSubtree() override;
void clearChildren() override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
