Title: [106779] trunk/Source/WebCore
- Revision
- 106779
- Author
- [email protected]
- Date
- 2012-02-05 23:54:53 -0800 (Sun, 05 Feb 2012)
Log Message
Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829
This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106778 => 106779)
--- trunk/Source/WebCore/ChangeLog 2012-02-06 07:52:59 UTC (rev 106778)
+++ trunk/Source/WebCore/ChangeLog 2012-02-06 07:54:53 UTC (rev 106779)
@@ -1,5 +1,18 @@
2012-02-05 Ilya Tikhonovsky <[email protected]>
+ Web Inspector: REGRESSION detached dom nodes aren't highlighted
+ https://bugs.webkit.org/show_bug.cgi?id=77829
+
+ This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/HeapSnapshot.js:
+ (WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
+ (WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
+
+2012-02-05 Ilya Tikhonovsky <[email protected]>
+
Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (106778 => 106779)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-02-06 07:52:59 UTC (rev 106778)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-02-06 07:54:53 UTC (rev 106779)
@@ -576,9 +576,9 @@
return this.name.substr(0, 9) === "DOMWindow";
},
- get isNativeRoot()
+ get isDetachedDOMTreesRoot()
{
- return this.name === "(Native objects)";
+ return this.name === "(Detached DOM trees)";
},
get isDetachedDOMTree()
@@ -1087,19 +1087,19 @@
_markDetachedDOMTreeNodes: function()
{
var flag = this._nodeFlags.detachedDOMTreeNode;
- var nativeRoot;
+ var detachedDOMTreesRoot;
for (var iter = this.rootNode.edges; iter.hasNext(); iter.next()) {
var node = iter.edge.node;
- if (node.isNativeRoot) {
- nativeRoot = node;
+ if (node.isDetachedDOMTreesRoot) {
+ detachedDOMTreesRoot = node;
break;
}
}
- if (!nativeRoot)
+ if (!detachedDOMTreesRoot)
return;
- for (var iter = nativeRoot.edges; iter.hasNext(); iter.next()) {
+ for (var iter = detachedDOMTreesRoot.edges; iter.hasNext(); iter.next()) {
var node = iter.edge.node;
if (node.isDetachedDOMTree) {
for (var edgesIter = node.edges; edgesIter.hasNext(); edgesIter.next())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
