Title: [284818] trunk/LayoutTests
Revision
284818
Author
[email protected]
Date
2021-10-25 13:15:02 -0700 (Mon, 25 Oct 2021)

Log Message

imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=232117

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Merge https://github.com/web-platform-tests/wpt/pull/31359 from upstream WPT to address the timeout and
rebaseline the test now that it is fully passing.

* web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt:
* web-platform-tests/html/semantics/forms/form-submission-0/resources/targetted-form.js:
(populateForm):

LayoutTests:

Unskip test that no longer times out.

* TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (284817 => 284818)


--- trunk/LayoutTests/ChangeLog	2021-10-25 19:30:14 UTC (rev 284817)
+++ trunk/LayoutTests/ChangeLog	2021-10-25 20:15:02 UTC (rev 284818)
@@ -1,5 +1,16 @@
 2021-10-25  Chris Dumez  <[email protected]>
 
+        imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=232117
+
+        Reviewed by Alex Christensen.
+
+        Unskip test that no longer times out.
+
+        * TestExpectations:
+
+2021-10-25  Chris Dumez  <[email protected]>
+
         Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
         https://bugs.webkit.org/show_bug.cgi?id=232151
         <rdar://problem/84552682>

Modified: trunk/LayoutTests/TestExpectations (284817 => 284818)


--- trunk/LayoutTests/TestExpectations	2021-10-25 19:30:14 UTC (rev 284817)
+++ trunk/LayoutTests/TestExpectations	2021-10-25 20:15:02 UTC (rev 284818)
@@ -608,7 +608,6 @@
 imported/w3c/web-platform-tests/dom/events/EventListener-incumbent-global-2.sub.html [ Skip ]
 imported/w3c/web-platform-tests/webmessaging/broadcastchannel/origin.window.html [ Skip ]
 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01.html [ Skip ]
-webkit.org/b/232117 imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html [ Skip ]
 imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_access_details.sub.html [ Skip ]
 imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-disallow-scripts-via-unsandboxed-popup.tentative.html [ Skip ]
 imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.transform.infinity.html [ Skip ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284817 => 284818)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-25 19:30:14 UTC (rev 284817)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-10-25 20:15:02 UTC (rev 284818)
@@ -1,3 +1,17 @@
+2021-10-25  Chris Dumez  <[email protected]>
+
+        imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=232117
+
+        Reviewed by Alex Christensen.
+
+        Merge https://github.com/web-platform-tests/wpt/pull/31359 from upstream WPT to address the timeout and
+        rebaseline the test now that it is fully passing.
+
+        * web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt:
+        * web-platform-tests/html/semantics/forms/form-submission-0/resources/targetted-form.js:
+        (populateForm):
+
 2021-10-25  Alex Christensen  <[email protected]>
 
         WebKit ought to be able to play videos without Content-Length HTTP header fields and without range support

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt (284817 => 284818)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt	2021-10-25 19:30:14 UTC (rev 284817)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm-expected.txt	2021-10-25 20:15:02 UTC (rev 284818)
@@ -6,15 +6,17 @@
 
 
 
-Harness Error (TIMEOUT), message = null
 
-FAIL If constructing entry list flag of form is true, then return assert_equals: expected 1 but got 0
+
+
+PASS If constructing entry list flag of form is true, then return
 PASS If firing submission events flag of form is true, then return
 PASS If form's firing submission events is true, then return; 'invalid' event
 PASS If form's firing submission events is true, then return; 'submit' event
-TIMEOUT firing an event named submit; clicking a submit button Test timed out
-NOTRUN firing an event named submit; form.requestSubmit()
-NOTRUN firing an event named submit; form.requestSubmit(null)
-NOTRUN firing an event named submit; form.requestSubmit(submitter)
+PASS firing an event named submit; clicking a submit button
+PASS firing an event named submit; form.requestSubmit()
+PASS firing an event named submit; form.requestSubmit(null)
+PASS firing an event named submit; form.requestSubmit(submitter)
 PASS Cannot navigate (after constructing the entry list)
+PASS Submission URL should always have a non-null query part
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/resources/targetted-form.js (284817 => 284818)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/resources/targetted-form.js	2021-10-25 19:30:14 UTC (rev 284817)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/resources/targetted-form.js	2021-10-25 20:15:02 UTC (rev 284818)
@@ -3,13 +3,13 @@
 function populateForm(optionalContentHtml) {
   if (!optionalContentHtml)
     optionalContentHtml = '';
+  const frameName = "form-test-target-" + frameCounter++;
   document.body.insertAdjacentHTML(
       'afterbegin',
-      `<iframe name="form-test-target-${frameCounter}"></iframe>` +
+      `<iframe name="${frameName}"></iframe>` +
           `<form action="" target="` +
-          `form-test-target-${frameCounter}">${optionalContentHtml}</form>`);
-  ++frameCounter;
-  return document.body.firstChild.nextSibling;
+          `${frameName}">${optionalContentHtml}</form>`);
+  return document.getElementsByName(frameName)[0].nextSibling;
 }
 
 function submitPromise(form, iframe) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to