Title: [284833] branches/safari-612-branch/Source/WebCore
- Revision
- 284833
- Author
- [email protected]
- Date
- 2021-10-25 14:51:06 -0700 (Mon, 25 Oct 2021)
Log Message
Cherry-pick r284007. rdar://problem/84630339
Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
https://bugs.webkit.org/show_bug.cgi?id=231424
Patch by Kimmo Kinnunen <[email protected]> on 2021-10-12
Reviewed by Dean Jackson.
ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
a texture via eglBindTexImage.
To side-step this performance issue, allocate the gl context with EGLConfig
that disables depth and stencil. The config is used for the video texture
upload context, video texture upload pbuffers as well as other pbuffers.
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (284832 => 284833)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-25 21:51:03 UTC (rev 284832)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-25 21:51:06 UTC (rev 284833)
@@ -1,5 +1,42 @@
2021-10-25 Null <[email protected]>
+ Cherry-pick r284007. rdar://problem/84630339
+
+ Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
+ https://bugs.webkit.org/show_bug.cgi?id=231424
+
+ Patch by Kimmo Kinnunen <[email protected]> on 2021-10-12
+ Reviewed by Dean Jackson.
+
+ ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
+ a texture via eglBindTexImage.
+ To side-step this performance issue, allocate the gl context with EGLConfig
+ that disables depth and stencil. The config is used for the video texture
+ upload context, video texture upload pbuffers as well as other pbuffers.
+
+ * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+ (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-10-12 Kimmo Kinnunen <[email protected]>
+
+ Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
+ https://bugs.webkit.org/show_bug.cgi?id=231424
+
+ Reviewed by Dean Jackson.
+
+ ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
+ a texture via eglBindTexImage.
+ To side-step this performance issue, allocate the gl context with EGLConfig
+ that disables depth and stencil. The config is used for the video texture
+ upload context, video texture upload pbuffers as well as other pbuffers.
+
+ * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+ (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+
+2021-10-25 Null <[email protected]>
+
Cherry-pick r283979. rdar://problem/84630712
WebGL first clear is lost when scissor is used for preserveDrawingBuffer:true in some conditions
Modified: branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm (284832 => 284833)
--- branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-10-25 21:51:03 UTC (rev 284832)
+++ branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-10-25 21:51:06 UTC (rev 284833)
@@ -266,6 +266,8 @@
EGL_GREEN_SIZE, 8,
EGL_BLUE_SIZE, 8,
EGL_ALPHA_SIZE, 8,
+ EGL_DEPTH_SIZE, 0,
+ EGL_STENCIL_SIZE, 0,
EGL_NONE
};
EGLint numberConfigsReturned = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
