Title: [284949] branches/safari-612-branch/Source/ThirdParty/ANGLE
- Revision
- 284949
- Author
- [email protected]
- Date
- 2021-10-27 14:05:54 -0700 (Wed, 27 Oct 2021)
Log Message
Cherry-pick r284293. rdar://problem/84204653
REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
https://bugs.webkit.org/show_bug.cgi?id=231682
Transform feedback should avoid appending _u for
builtin output variables.
Reviewed by Kimmo Kinnunen.
* src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:
(rx::mtl::GenerateTransformFeedbackVaryingOutput):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/ChangeLog (284948 => 284949)
--- branches/safari-612-branch/Source/ThirdParty/ANGLE/ChangeLog 2021-10-27 21:05:51 UTC (rev 284948)
+++ branches/safari-612-branch/Source/ThirdParty/ANGLE/ChangeLog 2021-10-27 21:05:54 UTC (rev 284949)
@@ -1,5 +1,36 @@
2021-10-26 Alan Coon <[email protected]>
+ Cherry-pick r284293. rdar://problem/84204653
+
+ REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=231682
+
+ Transform feedback should avoid appending _u for
+ builtin output variables.
+
+ Reviewed by Kimmo Kinnunen.
+
+ * src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:
+ (rx::mtl::GenerateTransformFeedbackVaryingOutput):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-10-15 Kyle Piddington <[email protected]>
+
+ REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=231682
+
+ Transform feedback should avoid appending _u for
+ builtin output variables.
+
+ Reviewed by Kimmo Kinnunen.
+
+ * src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:
+ (rx::mtl::GenerateTransformFeedbackVaryingOutput):
+
+2021-10-26 Alan Coon <[email protected]>
+
Cherry-pick r283667. rdar://problem/84629931
Shadertoy "truchet district" fails to compile with error: Internal error compiling shader with Metal backend"
Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm (284948 => 284949)
--- branches/safari-612-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm 2021-10-27 21:05:51 UTC (rev 284948)
+++ branches/safari-612-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm 2021-10-27 21:05:54 UTC (rev 284949)
@@ -258,7 +258,12 @@
<< "] + (gl_VertexID + ANGLE_instanceIdMod * "
<< "ANGLE_" << std::string(sh::kUniformsVar) << ".ANGLE_xfbVerticesPerDraw) * " << stride
<< " + " << offset << "] = " << "as_type<float>" << "("
- << "ANGLE_vertexOut." << kUserDefinedNamePrefix << varying.name;
+ << "ANGLE_vertexOut.";
+ if (!varying.isBuiltIn())
+ {
+ result << kUserDefinedNamePrefix;
+ }
+ result << varying.name;
if (varying.isArray())
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
