Title: [285130] trunk/Source
Revision
285130
Author
[email protected]
Date
2021-11-01 14:04:45 -0700 (Mon, 01 Nov 2021)

Log Message

[macOS] Opening local html files is failing
https://bugs.webkit.org/show_bug.cgi?id=232572
<rdar://81330442>

Reviewed by Brent Fulgham.

Source/WebKit:

On some macOS versions, opening local html files is failing. In order for the WebContent process
to successfully issue the file extension to the Networking process, the flags for the extension
in the WebContent process must include the user intent flag when the extension is issued with an
audit token.

* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):

Source/WTF:

Declare sandbox flag.

* wtf/spi/darwin/SandboxSPI.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (285129 => 285130)


--- trunk/Source/WTF/ChangeLog	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WTF/ChangeLog	2021-11-01 21:04:45 UTC (rev 285130)
@@ -1,3 +1,15 @@
+2021-11-01  Per Arne  <[email protected]>
+
+        [macOS] Opening local html files is failing
+        https://bugs.webkit.org/show_bug.cgi?id=232572
+        <rdar://81330442>
+
+        Reviewed by Brent Fulgham.
+
+        Declare sandbox flag.
+
+        * wtf/spi/darwin/SandboxSPI.h:
+
 2021-11-01  Tim Horton  <[email protected]>
 
         Add a testing preference to replay CG display lists manually

Modified: trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h (285129 => 285130)


--- trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2021-11-01 21:04:45 UTC (rev 285130)
@@ -62,6 +62,7 @@
 
 extern const uint32_t SANDBOX_EXTENSION_NO_REPORT;
 extern const uint32_t SANDBOX_EXTENSION_CANONICAL;
+extern const uint32_t SANDBOX_EXTENSION_USER_INTENT;
 
 char *sandbox_extension_issue_file(const char *extension_class, const char *path, uint32_t flags);
 char *sandbox_extension_issue_generic(const char *extension_class, uint32_t flags);

Modified: trunk/Source/WebKit/ChangeLog (285129 => 285130)


--- trunk/Source/WebKit/ChangeLog	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 21:04:45 UTC (rev 285130)
@@ -1,3 +1,19 @@
+2021-11-01  Per Arne  <[email protected]>
+
+        [macOS] Opening local html files is failing
+        https://bugs.webkit.org/show_bug.cgi?id=232572
+        <rdar://81330442>
+
+        Reviewed by Brent Fulgham.
+
+        On some macOS versions, opening local html files is failing. In order for the WebContent process
+        to successfully issue the file extension to the Networking process, the flags for the extension
+        in the WebContent process must include the user intent flag when the extension is issued with an
+        audit token.
+
+        * Shared/Cocoa/SandboxExtensionCocoa.mm:
+        (WebKit::SandboxExtensionImpl::sandboxExtensionForType):
+
 2021-11-01  Fujii Hironori  <[email protected]>
 
         [WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default

Modified: trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm (285129 => 285130)


--- trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm	2021-11-01 21:04:45 UTC (rev 285130)
@@ -115,6 +115,9 @@
         case SandboxExtension::Type::ReadByProcess:
             if (!auditToken)
                 return nullptr;
+#if PLATFORM(MAC)
+            extensionFlags |= SANDBOX_EXTENSION_USER_INTENT;
+#endif
             return sandbox_extension_issue_file_to_process(APP_SANDBOX_READ, path, extensionFlags, *auditToken);
         }
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to