Title: [285150] trunk/Tools
- Revision
- 285150
- Author
- hironori.fu...@sony.com
- Date
- 2021-11-01 19:30:27 -0700 (Mon, 01 Nov 2021)
Log Message
ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
https://bugs.webkit.org/show_bug.cgi?id=232596
Reviewed by Don Olmstead.
Since r284764, MSVC reports the following warning and a suggestion.
> Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
> Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string
* ImageDiff/ImageDiff.cpp:
(processImages): Use %zu for size_t.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (285149 => 285150)
--- trunk/Tools/ChangeLog 2021-11-02 01:14:49 UTC (rev 285149)
+++ trunk/Tools/ChangeLog 2021-11-02 02:30:27 UTC (rev 285150)
@@ -1,3 +1,18 @@
+2021-11-01 Fujii Hironori <hironori.fu...@sony.com>
+
+ ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+ https://bugs.webkit.org/show_bug.cgi?id=232596
+
+ Reviewed by Don Olmstead.
+
+ Since r284764, MSVC reports the following warning and a suggestion.
+
+ > Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+ > Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string
+
+ * ImageDiff/ImageDiff.cpp:
+ (processImages): Use %zu for size_t.
+
2021-11-01 Jonathan Bedard <jbed...@apple.com>
[webkitscmpy] Only respect the latest review
Modified: trunk/Tools/ImageDiff/ImageDiff.cpp (285149 => 285150)
--- trunk/Tools/ImageDiff/ImageDiff.cpp 2021-11-02 01:14:49 UTC (rev 285149)
+++ trunk/Tools/ImageDiff/ImageDiff.cpp 2021-11-02 02:30:27 UTC (rev 285150)
@@ -71,7 +71,7 @@
fprintf(stdout, "diff: %01.8f%%\n", differenceData.percentageDifference);
if (printDifference)
- fprintf(stdout, "maxDifference=%u; totalPixels=%lu\n", differenceData.maxDifference, differenceData.totalPixels);
+ fprintf(stdout, "maxDifference=%u; totalPixels=%zu\n", differenceData.maxDifference, differenceData.totalPixels);
fprintf(stdout, "#EOF\n");
fflush(stdout);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
