Title: [285186] trunk/Source/WebCore
Revision
285186
Author
[email protected]
Date
2021-11-02 14:52:11 -0700 (Tue, 02 Nov 2021)

Log Message

SVG elements should include SVGElementInlines not ElementInlines
https://bugs.webkit.org/show_bug.cgi?id=232637

Reviewed by Yusuke Suzuki.

Replace usages of ElementInlines.h with SVGElementInlines.h in WebCore/svg. Add
SVGElementInlines.h to files that need them when compiled without unified builds.

* svg/SVGAElement.cpp:
* svg/SVGAltGlyphElement.cpp:
* svg/SVGAnimationElement.cpp:
* svg/SVGFEImageElement.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFontFaceNameElement.cpp:
* svg/SVGFontFaceUriElement.cpp:
* svg/SVGHKernElement.cpp:
* svg/SVGImageElement.cpp:
* svg/SVGMaskElement.cpp:
* svg/SVGPatternElement.cpp:
* svg/SVGStyleElement.cpp:
* svg/SVGTRefElement.cpp:
* svg/SVGTSpanElement.cpp:
* svg/SVGTextElement.cpp:
* svg/SVGTextPathElement.cpp:
* svg/SVGVKernElement.cpp:
* svg/animation/SVGSMILElement.cpp:
* svg/properties/SVGAttributeAnimator.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (285185 => 285186)


--- trunk/Source/WebCore/ChangeLog	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/ChangeLog	2021-11-02 21:52:11 UTC (rev 285186)
@@ -1,5 +1,35 @@
 2021-11-02  Don Olmstead  <[email protected]>
 
+        SVG elements should include SVGElementInlines not ElementInlines
+        https://bugs.webkit.org/show_bug.cgi?id=232637
+
+        Reviewed by Yusuke Suzuki.
+
+        Replace usages of ElementInlines.h with SVGElementInlines.h in WebCore/svg. Add
+        SVGElementInlines.h to files that need them when compiled without unified builds.
+
+        * svg/SVGAElement.cpp:
+        * svg/SVGAltGlyphElement.cpp:
+        * svg/SVGAnimationElement.cpp:
+        * svg/SVGFEImageElement.cpp:
+        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
+        * svg/SVGFontFaceNameElement.cpp:
+        * svg/SVGFontFaceUriElement.cpp:
+        * svg/SVGHKernElement.cpp:
+        * svg/SVGImageElement.cpp:
+        * svg/SVGMaskElement.cpp:
+        * svg/SVGPatternElement.cpp:
+        * svg/SVGStyleElement.cpp:
+        * svg/SVGTRefElement.cpp:
+        * svg/SVGTSpanElement.cpp:
+        * svg/SVGTextElement.cpp:
+        * svg/SVGTextPathElement.cpp:
+        * svg/SVGVKernElement.cpp:
+        * svg/animation/SVGSMILElement.cpp:
+        * svg/properties/SVGAttributeAnimator.cpp:
+
+2021-11-02  Don Olmstead  <[email protected]>
+
         [MSVC] Remove unused friend class in filter code
         https://bugs.webkit.org/show_bug.cgi?id=232636
 

Modified: trunk/Source/WebCore/svg/SVGAElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGAElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGAElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -25,7 +25,6 @@
 
 #include "DOMTokenList.h"
 #include "Document.h"
-#include "ElementInlines.h"
 #include "EventHandler.h"
 #include "Frame.h"
 #include "FrameLoader.h"
@@ -39,6 +38,7 @@
 #include "RenderSVGText.h"
 #include "RenderSVGTransformableContainer.h"
 #include "ResourceRequest.h"
+#include "SVGElementInlines.h"
 #include "SVGElementTypeHelpers.h"
 #include "SVGNames.h"
 #include "SVGSMILElement.h"

Modified: trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -23,10 +23,10 @@
 #include "config.h"
 #include "SVGAltGlyphElement.h"
 
-#include "ElementInlines.h"
 #include "RenderInline.h"
 #include "RenderSVGTSpan.h"
 #include "SVGAltGlyphDefElement.h"
+#include "SVGElementInlines.h"
 #include "SVGElementTypeHelpers.h"
 #include "SVGGlyphElement.h"
 #include "SVGNames.h"

Modified: trunk/Source/WebCore/svg/SVGAnimationElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGAnimationElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGAnimationElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -30,11 +30,11 @@
 #include "CSSPropertyNames.h"
 #include "CSSPropertyParser.h"
 #include "Document.h"
-#include "ElementInlines.h"
 #include "FloatConversion.h"
 #include "RenderObject.h"
 #include "SVGAnimateColorElement.h"
 #include "SVGAnimateElement.h"
+#include "SVGElementInlines.h"
 #include "SVGElementTypeHelpers.h"
 #include "SVGNames.h"
 #include "SVGParserUtilities.h"

Modified: trunk/Source/WebCore/svg/SVGFEImageElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGFEImageElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGFEImageElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -30,6 +30,7 @@
 #include "Image.h"
 #include "RenderObject.h"
 #include "RenderSVGResource.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include "SVGPreserveAspectRatioValue.h"
 #include <wtf/IsoMallocInlines.h>

Modified: trunk/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -25,6 +25,7 @@
 
 #include "FilterEffect.h"
 #include "RenderSVGResourceFilterPrimitive.h"
+#include "SVGElementInlines.h"
 #include "SVGFilterBuilder.h"
 #include <wtf/IsoMallocInlines.h>
 #include <wtf/NeverDestroyed.h>

Modified: trunk/Source/WebCore/svg/SVGFontFaceNameElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGFontFaceNameElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGFontFaceNameElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -21,7 +21,7 @@
 #include "SVGFontFaceNameElement.h"
 
 #include "CSSFontFaceSrcValue.h"
-#include "ElementInlines.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include <wtf/IsoMallocInlines.h>
 

Modified: trunk/Source/WebCore/svg/SVGFontFaceUriElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGFontFaceUriElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGFontFaceUriElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -26,7 +26,7 @@
 #include "CachedResourceLoader.h"
 #include "CachedResourceRequest.h"
 #include "Document.h"
-#include "ElementInlines.h"
+#include "SVGElementInlines.h"
 #include "SVGElementTypeHelpers.h"
 #include "SVGFontFaceElement.h"
 #include "SVGNames.h"

Modified: trunk/Source/WebCore/svg/SVGHKernElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGHKernElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGHKernElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -22,7 +22,7 @@
 #include "config.h"
 #include "SVGHKernElement.h"
 
-#include "ElementInlines.h"
+#include "SVGElementInlines.h"
 #include "SVGFontElement.h"
 #include "SVGFontFaceElement.h"
 #include "SVGNames.h"

Modified: trunk/Source/WebCore/svg/SVGImageElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGImageElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGImageElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -25,7 +25,6 @@
 #include "SVGImageElement.h"
 
 #include "CSSPropertyNames.h"
-#include "ElementInlines.h"
 #include "RenderImageResource.h"
 #include "RenderSVGImage.h"
 #include "RenderSVGResource.h"

Modified: trunk/Source/WebCore/svg/SVGMaskElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGMaskElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGMaskElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -26,7 +26,6 @@
 #include "config.h"
 #include "SVGMaskElement.h"
 
-#include "ElementInlines.h"
 #include "RenderSVGResourceMaskerInlines.h"
 #include "SVGElementInlines.h"
 #include "SVGNames.h"

Modified: trunk/Source/WebCore/svg/SVGPatternElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGPatternElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGPatternElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -26,7 +26,6 @@
 
 #include "AffineTransform.h"
 #include "Document.h"
-#include "ElementInlines.h"
 #include "FloatConversion.h"
 #include "GraphicsContext.h"
 #include "ImageBuffer.h"

Modified: trunk/Source/WebCore/svg/SVGStyleElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGStyleElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGStyleElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -25,7 +25,7 @@
 
 #include "CSSStyleSheet.h"
 #include "Document.h"
-#include "ElementInlines.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include <wtf/IsoMallocInlines.h>
 #include <wtf/StdLibExtras.h>

Modified: trunk/Source/WebCore/svg/SVGTRefElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGTRefElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGTRefElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -30,10 +30,11 @@
 #include "RenderSVGInline.h"
 #include "RenderSVGInlineText.h"
 #include "RenderSVGResource.h"
-#include "ShadowRoot.h"
 #include "SVGDocumentExtensions.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include "ScriptDisallowedScope.h"
+#include "ShadowRoot.h"
 #include "StyleInheritedData.h"
 #include "Text.h"
 #include <wtf/IsoMallocInlines.h>

Modified: trunk/Source/WebCore/svg/SVGTSpanElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGTSpanElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGTSpanElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -23,6 +23,7 @@
 
 #include "RenderInline.h"
 #include "RenderSVGTSpan.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include <wtf/IsoMallocInlines.h>
 

Modified: trunk/Source/WebCore/svg/SVGTextElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGTextElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGTextElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -23,6 +23,7 @@
 
 #include "RenderSVGResource.h"
 #include "RenderSVGText.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include "SVGRenderStyle.h"
 #include "SVGTSpanElement.h"

Modified: trunk/Source/WebCore/svg/SVGTextPathElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGTextPathElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGTextPathElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -25,6 +25,7 @@
 #include "RenderSVGResource.h"
 #include "RenderSVGTextPath.h"
 #include "SVGDocumentExtensions.h"
+#include "SVGElementInlines.h"
 #include "SVGNames.h"
 #include <wtf/IsoMallocInlines.h>
 #include <wtf/NeverDestroyed.h>

Modified: trunk/Source/WebCore/svg/SVGVKernElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/SVGVKernElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/SVGVKernElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -20,7 +20,7 @@
 #include "config.h"
 #include "SVGVKernElement.h"
 
-#include "ElementInlines.h"
+#include "SVGElementInlines.h"
 #include "SVGFontElement.h"
 #include "SVGFontFaceElement.h"
 #include "SVGNames.h"

Modified: trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -29,7 +29,6 @@
 #include "AddEventListenerOptions.h"
 #include "CSSPropertyNames.h"
 #include "Document.h"
-#include "ElementInlines.h"
 #include "Event.h"
 #include "EventListener.h"
 #include "EventNames.h"
@@ -38,6 +37,7 @@
 #include "FrameView.h"
 #include "SMILTimeContainer.h"
 #include "SVGDocumentExtensions.h"
+#include "SVGElementInlines.h"
 #include "SVGElementTypeHelpers.h"
 #include "SVGNames.h"
 #include "SVGParserUtilities.h"

Modified: trunk/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp (285185 => 285186)


--- trunk/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp	2021-11-02 21:50:51 UTC (rev 285185)
+++ trunk/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp	2021-11-02 21:52:11 UTC (rev 285186)
@@ -28,7 +28,6 @@
 
 #include "CSSComputedStyleDeclaration.h"
 #include "CSSPropertyParser.h"
-#include "ElementInlines.h"
 #include "SVGElementInlines.h"
 
 namespace WebCore {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to