Title: [285217] trunk/Source/WebKit
- Revision
- 285217
- Author
- [email protected]
- Date
- 2021-11-03 11:26:11 -0700 (Wed, 03 Nov 2021)
Log Message
Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview()
<https://webkit.org/b/232628>
<rdar://problem/84935290>
Reviewed by Brent Fulgham.
* UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::modelElementDidCreatePreview):
- Use adoptNS() to fix the leak.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (285216 => 285217)
--- trunk/Source/WebKit/ChangeLog 2021-11-03 17:59:39 UTC (rev 285216)
+++ trunk/Source/WebKit/ChangeLog 2021-11-03 18:26:11 UTC (rev 285217)
@@ -1,3 +1,15 @@
+2021-11-03 David Kilzer <[email protected]>
+
+ Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview()
+ <https://webkit.org/b/232628>
+ <rdar://problem/84935290>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/Cocoa/ModelElementControllerCocoa.mm:
+ (WebKit::ModelElementController::modelElementDidCreatePreview):
+ - Use adoptNS() to fix the leak.
+
2021-11-03 Kate Cheney <[email protected]>
[iOS] Need API for marking file requests as non-app-initiated
Modified: trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm (285216 => 285217)
--- trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 17:59:39 UTC (rev 285216)
+++ trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-11-03 18:26:11 UTC (rev 285217)
@@ -129,7 +129,8 @@
if (!m_webPageProxy.preferences().modelElementEnabled())
return;
- auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:[[NSUUID alloc] initWithUUIDString:uuid]]);
+ auto uuid = adoptNS([[NSUUID alloc] initWithUUIDString:uuid]);
+ auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]);
LOG(ModelElement, "Created remote preview with UUID %s.", uuid.utf8().data());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
