Title: [285231] trunk/Source/WebCore
- Revision
- 285231
- Author
- [email protected]
- Date
- 2021-11-03 14:58:27 -0700 (Wed, 03 Nov 2021)
Log Message
[ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
https://bugs.webkit.org/show_bug.cgi?id=232676
Patch by Alex Christensen <[email protected]> on 2021-11-03
Reviewed by Eric Carlson.
In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
Remove some unsafe early returns.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer resolveBounds]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (285230 => 285231)
--- trunk/Source/WebCore/ChangeLog 2021-11-03 21:56:42 UTC (rev 285230)
+++ trunk/Source/WebCore/ChangeLog 2021-11-03 21:58:27 UTC (rev 285231)
@@ -1,3 +1,17 @@
+2021-11-03 Alex Christensen <[email protected]>
+
+ [ iOS ] TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=232676
+
+ Reviewed by Eric Carlson.
+
+ In r284743 we changed types from raw pointers to WeakPtr, but accessing them in layoutSublayers is not thread safe.
+ Remove some unsafe early returns.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (-[WebAVPlayerLayer layoutSublayers]):
+ (-[WebAVPlayerLayer resolveBounds]):
+
2021-11-03 Chris Dumez <[email protected]>
Clicking a link should preconnect to destination as first party
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (285230 => 285231)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2021-11-03 21:56:42 UTC (rev 285230)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2021-11-03 21:58:27 UTC (rev 285231)
@@ -289,9 +289,6 @@
if ([_videoSublayer superlayer] != self)
return;
- if (![_avPlayerController delegate])
- return;
-
[_videoSublayer setPosition:CGPointMake(CGRectGetMidX(self.bounds), CGRectGetMidY(self.bounds))];
if (self.videoDimensions.height <= 0 || self.videoDimensions.width <= 0)
@@ -328,8 +325,6 @@
- (void)resolveBounds
{
[NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(resolveBounds) object:nil];
- if (![_avPlayerController delegate])
- return;
if ([_videoSublayer superlayer] != self)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
