Title: [285400] trunk/Source/WebCore
- Revision
- 285400
- Author
- [email protected]
- Date
- 2021-11-08 07:43:34 -0800 (Mon, 08 Nov 2021)
Log Message
newAudioChunkPushed callback should take the total number of audio samples as parameter
https://bugs.webkit.org/show_bug.cgi?id=232808
Reviewed by Eric Carlson.
Update code according review.
This is a refactoring, no change of behavior.
* platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.cpp:
(WebCore::IncomingAudioMediaStreamTrackRendererUnit::newAudioChunkPushed):
* platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.h:
* platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::pollFromSource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (285399 => 285400)
--- trunk/Source/WebCore/ChangeLog 2021-11-08 13:56:36 UTC (rev 285399)
+++ trunk/Source/WebCore/ChangeLog 2021-11-08 15:43:34 UTC (rev 285400)
@@ -1,3 +1,19 @@
+2021-11-08 Youenn Fablet <[email protected]>
+
+ newAudioChunkPushed callback should take the total number of audio samples as parameter
+ https://bugs.webkit.org/show_bug.cgi?id=232808
+
+ Reviewed by Eric Carlson.
+
+ Update code according review.
+ This is a refactoring, no change of behavior.
+
+ * platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.cpp:
+ (WebCore::IncomingAudioMediaStreamTrackRendererUnit::newAudioChunkPushed):
+ * platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.h:
+ * platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
+ (WebCore::LibWebRTCAudioModule::pollFromSource):
+
2021-11-08 Andres Gonzalez <[email protected]>
WTR::AccessibilityController::focusedElement() cannot get the focused object via WKAccessibilityFocusedObject in isolated tree mode.
Modified: trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.cpp (285399 => 285400)
--- trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.cpp 2021-11-08 13:56:36 UTC (rev 285399)
+++ trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.cpp 2021-11-08 15:43:34 UTC (rev 285400)
@@ -154,10 +154,10 @@
});
}
-void IncomingAudioMediaStreamTrackRendererUnit::newAudioChunkPushed()
+void IncomingAudioMediaStreamTrackRendererUnit::newAudioChunkPushed(uint64_t currentAudioSampleCount)
{
DisableMallocRestrictionsForCurrentThreadScope disableMallocRestrictions;
- postTask([this, currentAudioSampleCount = m_audioModule.currentAudioSampleCount()] {
+ postTask([this, currentAudioSampleCount] {
renderAudioChunk(currentAudioSampleCount);
});
}
Modified: trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.h (285399 => 285400)
--- trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.h 2021-11-08 13:56:36 UTC (rev 285399)
+++ trunk/Source/WebCore/platform/mediastream/cocoa/IncomingAudioMediaStreamTrackRendererUnit.h 2021-11-08 15:43:34 UTC (rev 285400)
@@ -58,7 +58,7 @@
explicit IncomingAudioMediaStreamTrackRendererUnit(LibWebRTCAudioModule&);
~IncomingAudioMediaStreamTrackRendererUnit();
- void newAudioChunkPushed();
+ void newAudioChunkPushed(uint64_t);
private:
void start();
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp (285399 => 285400)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp 2021-11-08 13:56:36 UTC (rev 285399)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp 2021-11-08 15:43:34 UTC (rev 285400)
@@ -142,7 +142,7 @@
m_audioTransport->PullRenderData(LibWebRTCAudioFormat::sampleByteSize * 8, LibWebRTCAudioFormat::sampleRate, channels, LibWebRTCAudioFormat::chunkSampleCount, data, &elapsedTime, &ntpTime);
#if PLATFORM(COCOA)
if (m_isRenderingIncomingAudio)
- m_incomingAudioMediaStreamTrackRendererUnit->newAudioChunkPushed();
+ m_incomingAudioMediaStreamTrackRendererUnit->newAudioChunkPushed(m_currentAudioSampleCount);
m_currentAudioSampleCount += LibWebRTCAudioFormat::chunkSampleCount;
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
