Title: [285482] trunk
- Revision
- 285482
- Author
- [email protected]
- Date
- 2021-11-09 00:05:39 -0800 (Tue, 09 Nov 2021)
Log Message
A mask or isolation should set transform-style to flat
https://bugs.webkit.org/show_bug.cgi?id=232491
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Update test results showing newly passing test.
* web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt:
Source/WebCore:
Tests: transforms/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
transforms/preserve-3d-flat-webkit-grouping-properties.html: Added.
This is covered by an existing WPT test:
imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html
Ensure that values of `mask-image` other than `none`, `mask-border-source` other than `none`,
and `isolation: isolate` all force used style of `preserve-3d: flat`.
* style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
LayoutTests:
* transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
* transforms/3d/preserve-3d-flat-webkit-grouping-properties.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (285481 => 285482)
--- trunk/LayoutTests/ChangeLog 2021-11-09 07:39:20 UTC (rev 285481)
+++ trunk/LayoutTests/ChangeLog 2021-11-09 08:05:39 UTC (rev 285482)
@@ -1,3 +1,13 @@
+2021-11-09 Martin Robinson <[email protected]>
+
+ A mask or isolation should set transform-style to flat
+ https://bugs.webkit.org/show_bug.cgi?id=232491
+
+ Reviewed by Simon Fraser.
+
+ * transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
+ * transforms/3d/preserve-3d-flat-webkit-grouping-properties.html: Added.
+
2021-11-08 Said Abou-Hallawa <[email protected]>
[GPU Process] Remove non-platform code form the FEImage class
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285481 => 285482)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-09 07:39:20 UTC (rev 285481)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-09 08:05:39 UTC (rev 285482)
@@ -1,3 +1,14 @@
+2021-11-09 Martin Robinson <[email protected]>
+
+ A mask or isolation should set transform-style to flat
+ https://bugs.webkit.org/show_bug.cgi?id=232491
+
+ Reviewed by Simon Fraser.
+
+ Update test results showing newly passing test.
+
+ * web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt:
+
2021-11-08 Patrick Griffis <[email protected]>
Implement nonce-hiding
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt (285481 => 285482)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt 2021-11-09 07:39:20 UTC (rev 285481)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt 2021-11-09 08:05:39 UTC (rev 285482)
@@ -7,6 +7,6 @@
PASS Preserve-3d element flattened due to mix-blend-mode
PASS Preserve-3d element flattened due to clip CSS
PASS Preserve-3d element flattened due to clip-path
-FAIL Preserve-3d element flattened due to isolation assert_not_equals: got disallowed value 0
-FAIL Preserve-3d element flattened due to mask assert_not_equals: got disallowed value 0
+PASS Preserve-3d element flattened due to isolation
+PASS Preserve-3d element flattened due to mask
Added: trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt (0 => 285482)
--- trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt (rev 0)
+++ trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt 2021-11-09 08:05:39 UTC (rev 285482)
@@ -0,0 +1,7 @@
+PASS nonflat.getBoundingClientRect().width is nonflatWidth
+PASS document.getElementById('webkit-mask-box-image').getBoundingClientRect().width is not nonflatWidth
+PASS document.getElementById('webkit-mask-box-image-source').getBoundingClientRect().width is not nonflatWidth
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties.html (0 => 285482)
--- trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties.html (rev 0)
+++ trunk/LayoutTests/transforms/3d/preserve-3d-flat-webkit-grouping-properties.html 2021-11-09 08:05:39 UTC (rev 285482)
@@ -0,0 +1,41 @@
+<!doctype HTML>
+<link rel="author" title="Chris Harrelson" href=""
+<link rel="help" href=""
+<script src=""
+
+<style>
+ div {
+ width: 200px;
+ height: 200px;
+ }
+ .parent {
+ transform-style: preserve-3d;
+ transform: rotateY(45deg)
+ }
+
+ .child {
+ transform: rotateY(45deg);
+ background: lightblue
+ }
+</style>
+
+<div class=parent>
+ <div id=nonflat class=child></div>
+</div>
+<div class=parent style="-webkit-mask-box-image: url(data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==) 75 75 75 75 / auto / calc(100px) 0;">
+ <div id="webkit-mask-box-image" class=child></div>
+</div>
+
+<div class=parent style="-webkit-mask-box-image-source: url(data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==);">
+ <div id="webkit-mask-box-image-source" class=child></div>
+</div>
+
+<script>
+ var nonflatWidth = nonflat.getBoundingClientRect().width;
+ shouldBe("nonflat.getBoundingClientRect().width", "nonflatWidth");
+ shouldNotBe("document.getElementById('webkit-mask-box-image').getBoundingClientRect().width", "nonflatWidth");
+ shouldNotBe("document.getElementById('webkit-mask-box-image-source').getBoundingClientRect().width", "nonflatWidth");
+</script>
+
+<script src=""
+
Modified: trunk/Source/WebCore/ChangeLog (285481 => 285482)
--- trunk/Source/WebCore/ChangeLog 2021-11-09 07:39:20 UTC (rev 285481)
+++ trunk/Source/WebCore/ChangeLog 2021-11-09 08:05:39 UTC (rev 285482)
@@ -1,3 +1,22 @@
+2021-11-09 Martin Robinson <[email protected]>
+
+ A mask or isolation should set transform-style to flat
+ https://bugs.webkit.org/show_bug.cgi?id=232491
+
+ Reviewed by Simon Fraser.
+
+ Tests: transforms/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
+ transforms/preserve-3d-flat-webkit-grouping-properties.html: Added.
+
+ This is covered by an existing WPT test:
+ imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html
+
+ Ensure that values of `mask-image` other than `none`, `mask-border-source` other than `none`,
+ and `isolation: isolate` all force used style of `preserve-3d: flat`.
+
+ * style/StyleAdjuster.cpp:
+ (WebCore::Style::Adjuster::adjust const):
+
2021-11-08 Said Abou-Hallawa <[email protected]>
[GPU Process] Remove non-platform code form the FEImage class
Modified: trunk/Source/WebCore/style/StyleAdjuster.cpp (285481 => 285482)
--- trunk/Source/WebCore/style/StyleAdjuster.cpp 2021-11-09 07:39:20 UTC (rev 285481)
+++ trunk/Source/WebCore/style/StyleAdjuster.cpp 2021-11-09 08:05:39 UTC (rev 285482)
@@ -505,6 +505,8 @@
|| style.hasClip()
|| style.clipPath()
|| style.hasFilter()
+ || style.hasIsolation()
+ || style.hasMask()
#if ENABLE(FILTERS_LEVEL_2)
|| style.hasBackdropFilter()
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
