Title: [285534] trunk
- Revision
- 285534
- Author
- [email protected]
- Date
- 2021-11-09 14:19:54 -0800 (Tue, 09 Nov 2021)
Log Message
BroadcastChannel is still disabled in service workers
https://bugs.webkit.org/show_bug.cgi?id=232855
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
* web-platform-tests/webmessaging/broadcastchannel/service-worker.https-expected.txt:
Source/WebKit:
No new tests, rebaselined existing test.
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
Make sure BroadcastChannel is functional is Service Workers by setting up proper
BroadcastChannelRegistry on the PageConfiguration we use to construct the service
worker's dummy page.
Source/WTF:
Turn on BroadcastChannel experimental feature in WebCore since this is the value that Service Workers
end up using. We only need to disable it in WebKitLegacy.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285533 => 285534)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-09 22:19:54 UTC (rev 285534)
@@ -1,3 +1,14 @@
+2021-11-09 Chris Dumez <[email protected]>
+
+ BroadcastChannel is still disabled in service workers
+ https://bugs.webkit.org/show_bug.cgi?id=232855
+
+ Reviewed by Darin Adler.
+
+ Rebaseline WPT test that is now passing.
+
+ * web-platform-tests/webmessaging/broadcastchannel/service-worker.https-expected.txt:
+
2021-11-09 Rob Buis <[email protected]>
Import css/css-sizing/aspect-ratio tests from WPT
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt (285533 => 285534)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt 2021-11-09 22:19:54 UTC (rev 285534)
@@ -1,3 +1,3 @@
-FAIL Send and receive messages using a broadcast channel in an iframe, dedicated worker and service worker. assert_equals: The message target must receive a "broadcast-channel-created" message response. expected (string) "broadcast-channel-created" but got (undefined) undefined
+FAIL Send and receive messages using a broadcast channel in an iframe, dedicated worker and service worker. promise_test: Unhandled rejection with value: object "NotSupportedError: getFile is not implemented"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/service-worker.https-expected.txt (285533 => 285534)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/service-worker.https-expected.txt 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/service-worker.https-expected.txt 2021-11-09 22:19:54 UTC (rev 285534)
@@ -1,3 +1,3 @@
-FAIL BroadcastChannel works in service workers promise_test: Unhandled rejection with value: object "TypeError: ReferenceError: Can't find variable: BroadcastChannel"
+PASS BroadcastChannel works in service workers
Modified: trunk/Source/WTF/ChangeLog (285533 => 285534)
--- trunk/Source/WTF/ChangeLog 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/Source/WTF/ChangeLog 2021-11-09 22:19:54 UTC (rev 285534)
@@ -1,3 +1,15 @@
+2021-11-09 Chris Dumez <[email protected]>
+
+ BroadcastChannel is still disabled in service workers
+ https://bugs.webkit.org/show_bug.cgi?id=232855
+
+ Reviewed by Darin Adler.
+
+ Turn on BroadcastChannel experimental feature in WebCore since this is the value that Service Workers
+ end up using. We only need to disable it in WebKitLegacy.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
2021-11-09 Zan Dobersek <[email protected]>
[RISCV64] Add assembly, disassembly infrastructure
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (285533 => 285534)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-11-09 22:19:54 UTC (rev 285534)
@@ -127,7 +127,7 @@
WebKit:
default: true
WebCore:
- default: false
+ default: true
BroadcastChannelOriginPartitioningEnabled:
type: bool
Modified: trunk/Source/WebKit/ChangeLog (285533 => 285534)
--- trunk/Source/WebKit/ChangeLog 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/Source/WebKit/ChangeLog 2021-11-09 22:19:54 UTC (rev 285534)
@@ -1,3 +1,18 @@
+2021-11-09 Chris Dumez <[email protected]>
+
+ BroadcastChannel is still disabled in service workers
+ https://bugs.webkit.org/show_bug.cgi?id=232855
+
+ Reviewed by Darin Adler.
+
+ No new tests, rebaselined existing test.
+
+ * WebProcess/Storage/WebSWContextManagerConnection.cpp:
+ (WebKit::WebSWContextManagerConnection::installServiceWorker):
+ Make sure BroadcastChannel is functional is Service Workers by setting up proper
+ BroadcastChannelRegistry on the PageConfiguration we use to construct the service
+ worker's dummy page.
+
2021-11-09 Antoine Quint <[email protected]>
REGRESSION(r272201): Safari showed red distortion on webview after using Web Inspector, returning from another app
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp (285533 => 285534)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp 2021-11-09 21:56:05 UTC (rev 285533)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp 2021-11-09 22:19:54 UTC (rev 285534)
@@ -36,6 +36,7 @@
#include "RTCDataChannelRemoteManager.h"
#include "ServiceWorkerFetchTaskMessages.h"
#include "ServiceWorkerInitializationData.h"
+#include "WebBroadcastChannelRegistry.h"
#include "WebCacheStorageProvider.h"
#include "WebCompiledContentRuleListData.h"
#include "WebCoreArgumentCoders.h"
@@ -148,6 +149,7 @@
pageConfiguration.databaseProvider = WebDatabaseProvider::getOrCreate(m_pageGroupID);
pageConfiguration.socketProvider = WebSocketProvider::create(m_webPageProxyID);
+ pageConfiguration.broadcastChannelRegistry = WebProcess::singleton().broadcastChannelRegistry();
pageConfiguration.userContentProvider = m_userContentController;
#if ENABLE(WEB_RTC)
pageConfiguration.libWebRTCProvider = makeUniqueRef<ServiceWorkerLibWebRTCProvider>();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
