Title: [285672] trunk/Tools
- Revision
- 285672
- Author
- [email protected]
- Date
- 2021-11-11 15:08:24 -0800 (Thu, 11 Nov 2021)
Log Message
REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=233016
<rdar://problem/85315536>
Reviewed by Brent Fulgham.
In r285594, I have the browser entitlement to TestWebKit API to make my new API test work
on iOS. However, it turns out that 26 InAppBrowserPrivacy API tests rely on the browser
entitlement not being present. I am therefore reverting this part of my change.
* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (285671 => 285672)
--- trunk/Tools/ChangeLog 2021-11-11 22:46:30 UTC (rev 285671)
+++ trunk/Tools/ChangeLog 2021-11-11 23:08:24 UTC (rev 285672)
@@ -1,3 +1,18 @@
+2021-11-11 Chris Dumez <[email protected]>
+
+ REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=233016
+ <rdar://problem/85315536>
+
+ Reviewed by Brent Fulgham.
+
+ In r285594, I have the browser entitlement to TestWebKit API to make my new API test work
+ on iOS. However, it turns out that 26 InAppBrowserPrivacy API tests rely on the browser
+ entitlement not being present. I am therefore reverting this part of my change.
+
+ * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2021-11-11 Andres Gonzalez <[email protected]>
Fix for thread deadlocks during layout tests in isolated tree mode.
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements (285671 => 285672)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements 2021-11-11 22:46:30 UTC (rev 285671)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements 2021-11-11 23:08:24 UTC (rev 285672)
@@ -10,7 +10,5 @@
<true/>
<key>com.apple.Pasteboard.paste-unchecked</key>
<true/>
- <key>com.apple.developer.web-browser</key>
- <true/>
</dict>
</plist>
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (285671 => 285672)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-11 22:46:30 UTC (rev 285671)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-11 23:08:24 UTC (rev 285672)
@@ -7625,6 +7625,10 @@
runCOOPProcessSwapTest("same-origin-allow-popup", "unsafe-none", "unsafe-none", "unsafe-none", IsSameOrigin::No, DoServerSideRedirect::No, ExpectSwap::No);
}
+// On iOS, toggling the captive portal mode requires the browser entitlement, which TestWebKit API doesn't have.
+// Also, some API tests rely on the browser entitlement not being present.
+#if !PLATFORM(IOS)
+
static bool isJITEnabled(WKWebView *webView)
{
__block bool gotResponse = false;
@@ -7781,3 +7785,5 @@
checkSettingsControlledByCaptivePortalMode(webView2.get(), ShouldBeEnabled::Yes);
EXPECT_EQ(pid2, [webView2 _webProcessIdentifier]);
}
+
+#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
