Title: [285677] trunk/Tools
- Revision
- 285677
- Author
- [email protected]
- Date
- 2021-11-11 15:38:33 -0800 (Thu, 11 Nov 2021)
Log Message
Fix for crash in LayoutTests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=233014
Reviewed by Chris Fleizach.
This fixes the following tests in isolated tree mode:
accessibility/image-link-inline-cont.html [ Crash ]
accessibility/image-link.html [ Crash ]
accessibility/internal-link-anchors2.html [ Crash ]
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::allAttributes):
Need to retain the pointer returned by
AccessibilityUIElement::descriptionOfValue.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (285676 => 285677)
--- trunk/Tools/ChangeLog 2021-11-11 23:36:00 UTC (rev 285676)
+++ trunk/Tools/ChangeLog 2021-11-11 23:38:33 UTC (rev 285677)
@@ -1,3 +1,20 @@
+2021-11-11 Andres Gonzalez <[email protected]>
+
+ Fix for crash in LayoutTests in isolated tree mode.
+ https://bugs.webkit.org/show_bug.cgi?id=233014
+
+ Reviewed by Chris Fleizach.
+
+ This fixes the following tests in isolated tree mode:
+ accessibility/image-link-inline-cont.html [ Crash ]
+ accessibility/image-link.html [ Crash ]
+ accessibility/internal-link-anchors2.html [ Crash ]
+
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::allAttributes):
+ Need to retain the pointer returned by
+ AccessibilityUIElement::descriptionOfValue.
+
2021-11-11 Chris Dumez <[email protected]>
REGRESSION: 26 InAppBrowserPrivacy API failures on iOS
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (285676 => 285677)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2021-11-11 23:36:00 UTC (rev 285676)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2021-11-11 23:38:33 UTC (rev 285677)
@@ -578,8 +578,8 @@
|| [attribute isEqualToString:@"AXRelativeFrame"])
continue;
- NSString *value = descriptionOfValue(attributeValue(attribute).get());
- [values appendFormat:@"%@: %@\n", attribute, value];
+ RetainPtr<NSString> value = descriptionOfValue(attributeValue(attribute).get());
+ [values appendFormat:@"%@: %@\n", attribute, value.get()];
}
return [values createJSStringRef];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
