Title: [285686] trunk/Source/WebCore
Revision
285686
Author
[email protected]
Date
2021-11-11 15:50:20 -0800 (Thu, 11 Nov 2021)

Log Message

AX: Add missing AXID variant to AXPropertyValueVariant
https://bugs.webkit.org/show_bug.cgi?id=233004

Patch by Tyler Wilcock <[email protected]> on 2021-11-11
Reviewed by Chris Fleizach.

In AXIsolatedObject::setObjectProperty, we set property values to be
AXIDs. However, there is no AXID variant in AXPropertyValueVariant,
so none of these property lookups ever returned values.

This patch adds AXID as a variant to AXPropertyValueVariant, fixing
~15 text-only failures.

* accessibility/isolatedtree/AXIsolatedTree.h:
Add AXID as a variant to AXPropertyValueVariant.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (285685 => 285686)


--- trunk/Source/WebCore/ChangeLog	2021-11-11 23:48:14 UTC (rev 285685)
+++ trunk/Source/WebCore/ChangeLog	2021-11-11 23:50:20 UTC (rev 285686)
@@ -1,3 +1,20 @@
+2021-11-11  Tyler Wilcock  <[email protected]>
+
+        AX: Add missing AXID variant to AXPropertyValueVariant
+        https://bugs.webkit.org/show_bug.cgi?id=233004
+
+        Reviewed by Chris Fleizach.
+
+        In AXIsolatedObject::setObjectProperty, we set property values to be
+        AXIDs. However, there is no AXID variant in AXPropertyValueVariant,
+        so none of these property lookups ever returned values.
+
+        This patch adds AXID as a variant to AXPropertyValueVariant, fixing
+        ~15 text-only failures.
+
+        * accessibility/isolatedtree/AXIsolatedTree.h:
+        Add AXID as a variant to AXPropertyValueVariant.
+
 2021-11-11  Wenson Hsieh  <[email protected]>
 
         [Live Text] Augment TextRecognitionResult with a new type of text recognition data

Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h (285685 => 285686)


--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h	2021-11-11 23:48:14 UTC (rev 285685)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h	2021-11-11 23:50:20 UTC (rev 285686)
@@ -319,7 +319,7 @@
     WebArea,
 };
 
-using AXPropertyValueVariant = std::variant<std::nullptr_t, String, bool, int, unsigned, double, float, uint64_t, Color, URL, LayoutRect, FloatRect, PAL::SessionID, IntPoint, OptionSet<SpeakAs>, std::pair<unsigned, unsigned>, Vector<AccessibilityText>, Vector<AXID>, Vector<std::pair<AXID, AXID>>, Vector<String>, Path, OptionSet<AXAncestorFlag>>;
+using AXPropertyValueVariant = std::variant<std::nullptr_t, AXID, String, bool, int, unsigned, double, float, uint64_t, Color, URL, LayoutRect, FloatRect, PAL::SessionID, IntPoint, OptionSet<SpeakAs>, std::pair<unsigned, unsigned>, Vector<AccessibilityText>, Vector<AXID>, Vector<std::pair<AXID, AXID>>, Vector<String>, Path, OptionSet<AXAncestorFlag>>;
 using AXPropertyMap = HashMap<AXPropertyName, AXPropertyValueVariant, IntHash<AXPropertyName>, WTF::StrongEnumHashTraits<AXPropertyName>>;
 
 struct AXPropertyChange {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to