[webkit-changes] [285694] trunk/Source

Thu, 11 Nov 2021 17:21:48 -0800

Title: [285694] trunk/Source
Revision
285694
Author
[email protected]
Date
2021-11-11 17:20:59 -0800 (Thu, 11 Nov 2021)

Log Message

Misc compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=232989

Patch by Michael Catanzaro <[email protected]> on 2021-11-11
Reviewed by Darin Adler.

Source/WebCore:

* contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::parse):
* platform/graphics/transforms/ScaleTransformOperation.cpp:
(WebCore::blendScaleComponent):
* style/CascadeLevel.h:
(WebCore::Style::operator--):

Source/WebKit:

* UIProcess/WebPageProxy.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (285693 => 285694)


--- trunk/Source/WebCore/ChangeLog	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 01:20:59 UTC (rev 285694)
@@ -1,3 +1,18 @@
+2021-11-11  Michael Catanzaro  <[email protected]>
+
+        Misc compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=232989
+
+        Reviewed by Darin Adler.
+
+        * contentextensions/ContentExtensionActions.cpp:
+        (WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):
+        (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::parse):
+        * platform/graphics/transforms/ScaleTransformOperation.cpp:
+        (WebCore::blendScaleComponent):
+        * style/CascadeLevel.h:
+        (WebCore::Style::operator--):
+
 2021-11-11  Mark Lam  <[email protected]>
 
         Add VM::writeBarrier() and VM::mutatorFence().

Modified: trunk/Source/WebCore/contentextensions/ContentExtensionActions.cpp (285693 => 285694)


--- trunk/Source/WebCore/contentextensions/ContentExtensionActions.cpp	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionActions.cpp	2021-11-12 01:20:59 UTC (rev 285694)
@@ -360,7 +360,7 @@
         action.queryTransform = *parsedQueryTransform;
     } else
         action.queryTransform = transform.getString("query");
-    return WTFMove(action);
+    return action;
 }
 
 auto RedirectAction::URLTransformAction::isolatedCopy() const -> URLTransformAction
@@ -553,7 +553,7 @@
         parsedQueryTransform.addOrReplaceParams = WTFMove(keyValues);
     }
 
-    return WTFMove(parsedQueryTransform);
+    return parsedQueryTransform;
 }
 
 auto RedirectAction::URLTransformAction::QueryTransform::isolatedCopy() const -> QueryTransform

Modified: trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp (285693 => 285694)


--- trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp	2021-11-12 01:20:59 UTC (rev 285694)
@@ -47,6 +47,7 @@
         ASSERT(context.progress == 1.0);
         return from + to - 1;
     }
+    RELEASE_ASSERT_NOT_REACHED();
 }
 
 Ref<TransformOperation> ScaleTransformOperation::blend(const TransformOperation* from, const BlendingContext& context, bool blendToIdentity)

Modified: trunk/Source/WebCore/style/CascadeLevel.h (285693 => 285694)


--- trunk/Source/WebCore/style/CascadeLevel.h	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebCore/style/CascadeLevel.h	2021-11-12 01:20:59 UTC (rev 285694)
@@ -47,6 +47,7 @@
         ASSERT_NOT_REACHED();
         return level;
     }
+    RELEASE_ASSERT_NOT_REACHED();
 }
 
 }

Modified: trunk/Source/WebKit/ChangeLog (285693 => 285694)


--- trunk/Source/WebKit/ChangeLog	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 01:20:59 UTC (rev 285694)
@@ -1,3 +1,12 @@
+2021-11-11  Michael Catanzaro  <[email protected]>
+
+        Misc compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=232989
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/WebPageProxy.cpp:
+
 2021-11-11  Per Arne  <[email protected]>
 
         [macOS] Add required methods to IOKit message filter

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (285693 => 285694)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-11-12 01:10:03 UTC (rev 285693)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2021-11-12 01:20:59 UTC (rev 285694)
@@ -5254,6 +5254,7 @@
         originalRequest, WTFMove(request), WTFMove(requestBody), WTFMove(redirectResponse), userData, WTFMove(sender));
 }
 
+#if PLATFORM(COCOA)
 // https://html.spec.whatwg.org/#hand-off-to-external-software
 static bool frameSandboxAllowsOpeningExternalCustomProtocols(SandboxFlags sandboxFlags, bool hasUserGesture)
 {
@@ -5262,6 +5263,7 @@
 
     return !(sandboxFlags & SandboxTopNavigationByUserActivation) && hasUserGesture;
 }
+#endif
 
 void WebPageProxy::decidePolicyForNavigationAction(Ref<WebProcessProxy>&& process, PageIdentifier webPageID, WebFrameProxy& frame, FrameInfoData&& frameInfo, uint64_t navigationID,
     NavigationActionData&& navigationActionData, FrameInfoData&& originatingFrameInfoData, std::optional<WebPageProxyIdentifier> originatingPageID, const WebCore::ResourceRequest& originalRequest, WebCore::ResourceRequest&& request,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to