Title: [106874] trunk/Source/WebCore
- Revision
- 106874
- Author
- [email protected]
- Date
- 2012-02-06 16:41:31 -0800 (Mon, 06 Feb 2012)
Log Message
postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893
Patch by Greg Simon <[email protected]> on 2012-02-06
Reviewed by Adam Barth.
Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106873 => 106874)
--- trunk/Source/WebCore/ChangeLog 2012-02-07 00:38:43 UTC (rev 106873)
+++ trunk/Source/WebCore/ChangeLog 2012-02-07 00:41:31 UTC (rev 106874)
@@ -1,3 +1,16 @@
+2012-02-06 Greg Simon <[email protected]>
+
+ postMessage leaks MemoryEvent object
+ https://bugs.webkit.org/show_bug.cgi?id=77893
+
+ Reviewed by Adam Barth.
+
+ Changed from PassRefPtr().leakRef() to RefPtr.get() when
+ calling into FrameLoaderClient to stop +1 extra ref.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::postMessageTimerFired):
+
2012-02-06 Ehsan Akhgari <[email protected]>
WebGL conformance test misc/functions-returning-strings.html fails
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (106873 => 106874)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2012-02-07 00:38:43 UTC (rev 106873)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2012-02-07 00:41:31 UTC (rev 106874)
@@ -874,7 +874,7 @@
// Give the embedder a chance to intercept this postMessage because this
// DOMWindow might be a proxy for another in browsers that support
// postMessage calls across WebKit instances.
- if (isCurrentlyDisplayedInFrame() && m_frame->loader()->client()->willCheckAndDispatchMessageEvent(timer->targetOrigin(), PassRefPtr<MessageEvent>(event).leakRef()))
+ if (isCurrentlyDisplayedInFrame() && m_frame->loader()->client()->willCheckAndDispatchMessageEvent(timer->targetOrigin(), event.get()))
return;
if (timer->targetOrigin()) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
