Title: [106877] trunk/Source/WebKit/gtk
Revision
106877
Author
[email protected]
Date
2012-02-06 16:53:23 -0800 (Mon, 06 Feb 2012)

Log Message

Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.

Reviewed by Martin Robinson.

* tests/test_utils.c:
(testutils_relative_chdir):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (106876 => 106877)


--- trunk/Source/WebKit/gtk/ChangeLog	2012-02-07 00:52:02 UTC (rev 106876)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-02-07 00:53:23 UTC (rev 106877)
@@ -1,5 +1,16 @@
 2012-02-06  Gustavo Noronha Silva  <[email protected]>
 
+        Do not try to chdir to the directory where the executable is in
+        only if the path is absolute. This makes tests runnable from
+        anywhere.
+
+        Reviewed by Martin Robinson.
+
+        * tests/test_utils.c:
+        (testutils_relative_chdir):
+
+2012-02-06  Gustavo Noronha Silva  <[email protected]>
+
         Unreviewed fix for the new API test that is failing -
         WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
         builds.

Modified: trunk/Source/WebKit/gtk/tests/test_utils.c (106876 => 106877)


--- trunk/Source/WebKit/gtk/tests/test_utils.c	2012-02-07 00:52:02 UTC (rev 106876)
+++ trunk/Source/WebKit/gtk/tests/test_utils.c	2012-02-07 00:53:23 UTC (rev 106877)
@@ -29,10 +29,8 @@
     if (repoPath) {
         if (g_chdir(repoPath))
             return -1;
-    } else if (g_path_is_absolute(executablePath)) {
-        if (g_chdir(g_path_get_dirname(executablePath)))
+    } else if (g_chdir(g_path_get_dirname(executablePath)))
             return -1;
-    }
 
     while (!g_file_test(targetFilename, G_FILE_TEST_EXISTS)) {
         gchar *pathName;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to