Title: [285800] trunk
- Revision
- 285800
- Author
- pgrif...@igalia.com
- Date
- 2021-11-15 00:42:39 -0800 (Mon, 15 Nov 2021)
Log Message
CSP: Fix missing lineNumber and columnNumber in inline violation reports
https://bugs.webkit.org/show_bug.cgi?id=233102
Reviewed by Carlos Garcia Campos.
LayoutTests/imported/w3c:
Update expectations as passing.
* web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt:
Source/WebCore:
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285799 => 285800)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-15 07:17:34 UTC (rev 285799)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-15 08:42:39 UTC (rev 285800)
@@ -1,3 +1,14 @@
+2021-11-15 Patrick Griffis <pgrif...@igalia.com>
+
+ CSP: Fix missing lineNumber and columnNumber in inline violation reports
+ https://bugs.webkit.org/show_bug.cgi?id=233102
+
+ Reviewed by Carlos Garcia Campos.
+
+ Update expectations as passing.
+
+ * web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt:
+
2021-11-14 Tim Nguyen <n...@apple.com>
Modal dialogs should make the root element unfocusable
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt (285799 => 285800)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt 2021-11-15 07:17:34 UTC (rev 285799)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt 2021-11-15 08:42:39 UTC (rev 285800)
@@ -1,3 +1,3 @@
-FAIL Inline violations have a blockedURI of 'inline' assert_equals: expected 15 but got 0
+PASS Inline violations have a blockedURI of 'inline'
Modified: trunk/Source/WebCore/ChangeLog (285799 => 285800)
--- trunk/Source/WebCore/ChangeLog 2021-11-15 07:17:34 UTC (rev 285799)
+++ trunk/Source/WebCore/ChangeLog 2021-11-15 08:42:39 UTC (rev 285800)
@@ -1,3 +1,13 @@
+2021-11-15 Patrick Griffis <pgrif...@igalia.com>
+
+ CSP: Fix missing lineNumber and columnNumber in inline violation reports
+ https://bugs.webkit.org/show_bug.cgi?id=233102
+
+ Reviewed by Carlos Garcia Campos.
+
+ * page/csp/ContentSecurityPolicy.cpp:
+ (WebCore::ContentSecurityPolicy::reportViolation const):
+
2021-11-14 Simon Fraser <simon.fra...@apple.com>
Fingers down on the trackpad should stop an animated scroll
Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp (285799 => 285800)
--- trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp 2021-11-15 07:17:34 UTC (rev 285799)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp 2021-11-15 08:42:39 UTC (rev 285800)
@@ -751,6 +751,8 @@
auto blockedURL = URL(URL(), blockedURLString);
info.documentURI = m_documentURL ? m_documentURL.value().strippedForUseAsReferrer() : deprecatedURLForReporting(blockedURL);
+ info.lineNumber = sourcePosition.m_line.oneBasedInt();
+ info.columnNumber = sourcePosition.m_column.oneBasedInt();
if (m_client)
m_client->willSendCSPViolationReport(info);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes