Title: [106890] trunk
Revision
106890
Author
[email protected]
Date
2012-02-06 18:21:09 -0800 (Mon, 06 Feb 2012)

Log Message

Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/js/config.js:
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.get):

Modified Paths

Diff

Modified: trunk/ChangeLog (106889 => 106890)


--- trunk/ChangeLog	2012-02-07 02:04:09 UTC (rev 106889)
+++ trunk/ChangeLog	2012-02-07 02:21:09 UTC (rev 106890)
@@ -1,3 +1,19 @@
+2012-02-06  Ryosuke Niwa  <[email protected]>
+
+        Perf-o-matic should show min/max/stdev on graphs
+        https://bugs.webkit.org/show_bug.cgi?id=77702
+
+        Reviewed by Andreas Kling.
+
+        Include min/max/stdev in test runs when available to be shown on the perf-o-matic.
+
+        Also merge a change to config.js and increment the version number by 1 (unreviewed).
+
+        * Websites/webkit-perf.appspot.com/app.yaml:
+        * Websites/webkit-perf.appspot.com/js/config.js:
+        * Websites/webkit-perf.appspot.com/runs_handler.py:
+        (RunsHandler.get):
+
 2012-02-06  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Update NEWS and configure.ac for 1.7.5 release

Modified: trunk/Websites/webkit-perf.appspot.com/app.yaml (106889 => 106890)


--- trunk/Websites/webkit-perf.appspot.com/app.yaml	2012-02-07 02:04:09 UTC (rev 106889)
+++ trunk/Websites/webkit-perf.appspot.com/app.yaml	2012-02-07 02:21:09 UTC (rev 106890)
@@ -1,5 +1,5 @@
 application: webkit-perf
-version: 10
+version: 11
 runtime: python27
 api_version: 1
 threadsafe: false

Modified: trunk/Websites/webkit-perf.appspot.com/js/config.js (106889 => 106890)


--- trunk/Websites/webkit-perf.appspot.com/js/config.js	2012-02-07 02:04:09 UTC (rev 106889)
+++ trunk/Websites/webkit-perf.appspot.com/js/config.js	2012-02-07 02:21:09 UTC (rev 106890)
@@ -15,9 +15,11 @@
 // server for static dashboard images
 var IMAGE_SERVER = SERVER;
 
-var LIGHT_COLORS = $.map(COLORS, function(color) {
-    return $.color.parse(color).add('a', -.5).toString();
-});
+if ($.color) {
+    var LIGHT_COLORS = $.map(COLORS, function(color) {
+        return $.color.parse(color).add('a', -.5).toString();
+    });
+}
 
 var PLOT_OPTIONS = {
     xaxis: { mode: 'time' },

Modified: trunk/Websites/webkit-perf.appspot.com/runs_handler.py (106889 => 106890)


--- trunk/Websites/webkit-perf.appspot.com/runs_handler.py	2012-02-07 02:04:09 UTC (rev 106889)
+++ trunk/Websites/webkit-perf.appspot.com/runs_handler.py	2012-02-07 02:21:09 UTC (rev 106890)
@@ -85,9 +85,14 @@
             for result in results:
                 builderId = build.builder.key().id()
                 posixTimestamp = mktime(build.timestamp.timetuple())
+                statistics = None
+                if result.valueStdev != None and result.valueMin != None and result.valueMax != None:
+                    statistics = {'stdev': result.valueStdev, 'min': result.valueMin, 'max': result.valueMax}
                 test_runs.append([result.key().id(),
                     [build.key().id(), build.buildNumber, build.revision],
-                    posixTimestamp, result.value, 0, [], builderId])
+                    posixTimestamp, result.value, 0,  # runNumber
+                    [],  # annotations
+                    builderId, statistics])
                 # FIXME: Calculate the average; in practice, we wouldn't have more than one value for a given revision
                 averages[build.revision] = result.value
                 values.append(result.value)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to