Title: [285975] trunk/Source/WebInspectorUI
- Revision
- 285975
- Author
- [email protected]
- Date
- 2021-11-17 19:46:53 -0800 (Wed, 17 Nov 2021)
Log Message
Web Inspector: assertion failures in `WI.GridOverlayConfigurationDiagnosticEventRecorder`
https://bugs.webkit.org/show_bug.cgi?id=233298
Reviewed by Patrick Angle.
* UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (285974 => 285975)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-11-18 03:28:23 UTC (rev 285974)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-11-18 03:46:53 UTC (rev 285975)
@@ -1,5 +1,15 @@
2021-11-17 Devin Rousso <[email protected]>
+ Web Inspector: assertion failures in `WI.GridOverlayConfigurationDiagnosticEventRecorder`
+ https://bugs.webkit.org/show_bug.cgi?id=233298
+
+ Reviewed by Patrick Angle.
+
+ * UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:
+ (WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):
+
+2021-11-17 Devin Rousso <[email protected]>
+
Web Inspector: allow left docking when in LTR and right docking when in RTL
https://bugs.webkit.org/show_bug.cgi?id=233294
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js (285974 => 285975)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js 2021-11-18 03:28:23 UTC (rev 285974)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js 2021-11-18 03:46:53 UTC (rev 285975)
@@ -64,8 +64,8 @@
window.removeEventListener("blur", this, options);
window.removeEventListener("keydown", this, options);
window.removeEventListener("mousedown", this, options);
- WI.overlayManager.addEventListener(WI.OverlayManager.Event.GridOverlayShown, this._handleGridOverlayShown, this);
- WI.overlayManager.addEventListener(WI.OverlayManager.Event.GridOverlayHidden, this._handleGridOverlayHidden, this);
+ WI.overlayManager.removeEventListener(WI.OverlayManager.Event.GridOverlayShown, this._handleGridOverlayShown, this);
+ WI.overlayManager.removeEventListener(WI.OverlayManager.Event.GridOverlayHidden, this._handleGridOverlayHidden, this);
this._stopEventSamplingTimerIfNeeded();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
