Title: [286141] trunk/Tools
- Revision
- 286141
- Author
- [email protected]
- Date
- 2021-11-23 19:47:06 -0800 (Tue, 23 Nov 2021)
Log Message
[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
https://bugs.webkit.org/show_bug.cgi?id=233452
Reviewed by Michael Catanzaro.
GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
being used as the max value, while GdkRGBA expects the value to be
between 0.0 and 1.0, per the official docs [1][2].
[1] https://docs.gtk.org/gdk3/struct.RGBA.html
[2] https://docs.gtk.org/gdk4/struct.RGBA.html
* MiniBrowser/gtk/BrowserWindow.c:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (286140 => 286141)
--- trunk/Tools/ChangeLog 2021-11-24 01:34:33 UTC (rev 286140)
+++ trunk/Tools/ChangeLog 2021-11-24 03:47:06 UTC (rev 286141)
@@ -1,3 +1,19 @@
+2021-11-23 Lauro Moura <[email protected]>
+
+ [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
+ https://bugs.webkit.org/show_bug.cgi?id=233452
+
+ Reviewed by Michael Catanzaro.
+
+ GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
+ being used as the max value, while GdkRGBA expects the value to be
+ between 0.0 and 1.0, per the official docs [1][2].
+
+ [1] https://docs.gtk.org/gdk3/struct.RGBA.html
+ [2] https://docs.gtk.org/gdk4/struct.RGBA.html
+
+ * MiniBrowser/gtk/BrowserWindow.c:
+
2021-11-23 Carlos Garcia Campos <[email protected]>
[GTK] Change hardware-acceleration-policy setting default value to always
Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (286140 => 286141)
--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2021-11-24 01:34:33 UTC (rev 286140)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2021-11-24 03:47:06 UTC (rev 286141)
@@ -1332,8 +1332,8 @@
static void browser_window_init(BrowserWindow *window)
{
- window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 255;
- window->backgroundColor.alpha = 1;
+ window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 1.0;
+ window->backgroundColor.alpha = 1.0;
gtk_window_set_title(GTK_WINDOW(window), defaultWindowTitle);
gtk_window_set_default_size(GTK_WINDOW(window), 1024, 768);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
