Title: [286165] trunk/LayoutTests
- Revision
- 286165
- Author
- [email protected]
- Date
- 2021-11-25 04:02:28 -0800 (Thu, 25 Nov 2021)
Log Message
[GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=142489
Reviewed by Philippe Normand.
The test was failing with a timeout even after properly calling TestRunner.notifyDone()
internally because there was still an injectedBundle.topLoadingFrame() in InjectedBundlePage,
which means that the web page hadn't completely finished to be downloaded. This was caused
by the stalled video download that the test wants to exercise.
The solution is to set the video src to empty in order to convince TestRunner that the page
has finished downloading.
* http/tests/media/video-play-waiting.html: Set the video src to empty.
* platform/mac/TestExpectations: The test now just fails (for reasons unrelated to this fix) on mac instead of timing out.
* platform/glib/TestExpectations: Unskipped test.
* platform/win/TestExpectations: Unskipped test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (286164 => 286165)
--- trunk/LayoutTests/ChangeLog 2021-11-25 11:44:44 UTC (rev 286164)
+++ trunk/LayoutTests/ChangeLog 2021-11-25 12:02:28 UTC (rev 286165)
@@ -1,3 +1,23 @@
+2021-11-25 Enrique Ocaña González <[email protected]>
+
+ [GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=142489
+
+ Reviewed by Philippe Normand.
+
+ The test was failing with a timeout even after properly calling TestRunner.notifyDone()
+ internally because there was still an injectedBundle.topLoadingFrame() in InjectedBundlePage,
+ which means that the web page hadn't completely finished to be downloaded. This was caused
+ by the stalled video download that the test wants to exercise.
+
+ The solution is to set the video src to empty in order to convince TestRunner that the page
+ has finished downloading.
+
+ * http/tests/media/video-play-waiting.html: Set the video src to empty.
+ * platform/mac/TestExpectations: The test now just fails (for reasons unrelated to this fix) on mac instead of timing out.
+ * platform/glib/TestExpectations: Unskipped test.
+ * platform/win/TestExpectations: Unskipped test.
+
2021-11-24 Ziran Sun <[email protected]>
[css-grid] Track sizing algorithm not repeated even if used flex fraction would change
Modified: trunk/LayoutTests/http/tests/media/video-play-waiting.html (286164 => 286165)
--- trunk/LayoutTests/http/tests/media/video-play-waiting.html 2021-11-25 11:44:44 UTC (rev 286164)
+++ trunk/LayoutTests/http/tests/media/video-play-waiting.html 2021-11-25 12:02:28 UTC (rev 286165)
@@ -9,7 +9,11 @@
waitForEvent('durationchange');
waitForEvent('loadedmetadata');
waitForEvent('loadeddata');
- waitForEventAndEnd('waiting');
+ waitForEventAndEnd('waiting', function() {
+ // TestRunner waits for the complete frame download before finishing, so having the video load stalled
+ // prevents TestRunner from finishing. Changing the src will abort the download and let the test finish.
+ video.src = ""
+ });
waitForEvent('canplay', function () {
run("video.play()");
Modified: trunk/LayoutTests/platform/glib/TestExpectations (286164 => 286165)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-11-25 11:44:44 UTC (rev 286164)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-11-25 12:02:28 UTC (rev 286165)
@@ -2356,7 +2356,6 @@
webkit.org/b/137698 media/video-controls-drag.html [ Timeout ]
webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ]
-webkit.org/b/142489 http/tests/media/video-play-waiting.html [ Timeout ]
webkit.org/b/130971 media/track/track-remove-track.html [ Timeout ]
webkit.org/b/113127 media/track/track-prefer-captions.html [ Timeout ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (286164 => 286165)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-11-25 11:44:44 UTC (rev 286164)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-11-25 12:02:28 UTC (rev 286165)
@@ -745,8 +745,7 @@
webkit.org/b/136708 http/tests/media/video-play-stall-seek.html
webkit.org/b/136708 media/media-fullscreen-not-in-document.html
-webkit.org/b/140639 http/tests/media/video-play-waiting.html [ Pass Timeout ]
-
+webkit.org/b/140639 http/tests/media/video-play-waiting.html [ Failure ]
# This test requires generation of progress events during loading
webkit.org/b/100984 media/progress-events-generated-correctly.html [ Failure ]
Modified: trunk/LayoutTests/platform/win/TestExpectations (286164 => 286165)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-11-25 11:44:44 UTC (rev 286164)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-11-25 12:02:28 UTC (rev 286165)
@@ -1097,7 +1097,6 @@
# HTTP Timeouts
http/tests/media/hls/video-cookie.html [ Skip ] # Timeout
http/tests/media/video-buffered-range-contains-currentTime.html [ Skip ] # Timeout
-http/tests/media/video-play-waiting.html [ Skip ] # Timeout
# Extra whitespace in the output
#media/W3C/video/canPlayType/canPlayType_codecs_order_2.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
