Title: [286300] trunk
Revision
286300
Author
[email protected]
Date
2021-11-30 08:32:15 -0800 (Tue, 30 Nov 2021)

Log Message

Move TransformStreamAPIEnabled flag to Settings
https://bugs.webkit.org/show_bug.cgi?id=233524

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing tests.

* Modules/streams/TransformStream.idl:
* Modules/streams/TransformStreamDefaultController.idl:
* dom/TextDecoderStream.idl:
* dom/TextDecoderStreamDecoder.idl:
* dom/TextEncoderStream.idl:
* dom/TextEncoderStreamEncoder.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::readableByteStreamAPIEnabled const):
(WebCore::RuntimeEnabledFeatures::setTransformStreamAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::transformStreamAPIEnabled const): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

* platform/win/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
* platform/win/streams/reference-implementation/transform-stream-expected.txt: Removed.
* platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
* platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Removed.

Modified Paths

Removed Paths

  • trunk/LayoutTests/platform/win/streams/
  • trunk/LayoutTests/platform/wincairo/streams/

Diff

Modified: trunk/LayoutTests/ChangeLog (286299 => 286300)


--- trunk/LayoutTests/ChangeLog	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/LayoutTests/ChangeLog	2021-11-30 16:32:15 UTC (rev 286300)
@@ -1,5 +1,17 @@
 2021-11-30  Youenn Fablet  <[email protected]>
 
+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        * platform/win/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
+        * platform/win/streams/reference-implementation/transform-stream-expected.txt: Removed.
+        * platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Removed.
+        * platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Removed.
+
+2021-11-30  Youenn Fablet  <[email protected]>
+
         ServiceWorkerContainer does not respond well to network process crash
         https://bugs.webkit.org/show_bug.cgi?id=233626
 

Modified: trunk/Source/WTF/ChangeLog (286299 => 286300)


--- trunk/Source/WTF/ChangeLog	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WTF/ChangeLog	2021-11-30 16:32:15 UTC (rev 286300)
@@ -1,3 +1,12 @@
+2021-11-30  Youenn Fablet  <[email protected]>
+
+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2021-11-29  Chris Dumez  <[email protected]>
 
         Add initial implementation for the Web Lock API

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286299 => 286300)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-11-30 16:32:15 UTC (rev 286300)
@@ -1334,8 +1334,9 @@
   type: bool
   humanReadableName: "TransformStream API"
   humanReadableDescription: "Enable Transform Stream API"
-  webcoreBinding: RuntimeEnabledFeatures
   defaultValue:
+    WebCore:
+      default: true
     WebKitLegacy:
       default: true
     WebKit:

Modified: trunk/Source/WebCore/ChangeLog (286299 => 286300)


--- trunk/Source/WebCore/ChangeLog	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/ChangeLog	2021-11-30 16:32:15 UTC (rev 286300)
@@ -1,5 +1,25 @@
 2021-11-30  Youenn Fablet  <[email protected]>
 
+        Move TransformStreamAPIEnabled flag to Settings
+        https://bugs.webkit.org/show_bug.cgi?id=233524
+
+        Reviewed by Chris Dumez.
+
+        Covered by existing tests.
+
+        * Modules/streams/TransformStream.idl:
+        * Modules/streams/TransformStreamDefaultController.idl:
+        * dom/TextDecoderStream.idl:
+        * dom/TextDecoderStreamDecoder.idl:
+        * dom/TextEncoderStream.idl:
+        * dom/TextEncoderStreamEncoder.idl:
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::readableByteStreamAPIEnabled const):
+        (WebCore::RuntimeEnabledFeatures::setTransformStreamAPIEnabled): Deleted.
+        (WebCore::RuntimeEnabledFeatures::transformStreamAPIEnabled const): Deleted.
+
+2021-11-30  Youenn Fablet  <[email protected]>
+
         ServiceWorkerContainer does not respond well to network process crash
         https://bugs.webkit.org/show_bug.cgi?id=233626
 

Modified: trunk/Source/WebCore/Modules/streams/TransformStream.idl (286299 => 286300)


--- trunk/Source/WebCore/Modules/streams/TransformStream.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/Modules/streams/TransformStream.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
  */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     JSBuiltin,
     PrivateIdentifier,

Modified: trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl (286299 => 286300)


--- trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/Modules/streams/TransformStreamDefaultController.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
  */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     JSBuiltin,
     PrivateIdentifier,

Modified: trunk/Source/WebCore/dom/TextDecoderStream.idl (286299 => 286300)


--- trunk/Source/WebCore/dom/TextDecoderStream.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextDecoderStream.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
  */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     JSBuiltin,
 ] interface TextDecoderStream {

Modified: trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl (286299 => 286300)


--- trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextDecoderStreamDecoder.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
  */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     ImplementationLacksVTable,
     PrivateIdentifier,

Modified: trunk/Source/WebCore/dom/TextEncoderStream.idl (286299 => 286300)


--- trunk/Source/WebCore/dom/TextEncoderStream.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextEncoderStream.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
 */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     JSBuiltin,
 ] interface TextEncoderStream {

Modified: trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl (286299 => 286300)


--- trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/dom/TextEncoderStreamEncoder.idl	2021-11-30 16:32:15 UTC (rev 286300)
@@ -24,7 +24,7 @@
  */
 
 [
-    EnabledAtRuntime=TransformStreamAPIEnabled,
+    EnabledBySetting=TransformStreamAPIEnabled,
     Exposed=(Window,Worker),
     ImplementationLacksVTable,
     PrivateIdentifier,

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (286299 => 286300)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-11-30 16:27:07 UTC (rev 286299)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2021-11-30 16:32:15 UTC (rev 286300)
@@ -167,8 +167,6 @@
 
     void setReadableByteStreamAPIEnabled(bool isEnabled) { m_isReadableByteStreamAPIEnabled = isEnabled; }
     bool readableByteStreamAPIEnabled() const { return m_isReadableByteStreamAPIEnabled; }
-    void setTransformStreamAPIEnabled(bool isEnabled) { m_isTransformStreamAPIEnabled = isEnabled; }
-    bool transformStreamAPIEnabled() const { return m_isTransformStreamAPIEnabled; }
 
 #if ENABLE(SERVICE_WORKER)
     bool pushAPIEnabled() const { return m_pushAPIEnabled; }
@@ -332,7 +330,6 @@
 #endif
 
     bool m_isReadableByteStreamAPIEnabled { false };
-    bool m_isTransformStreamAPIEnabled { false };
 
 #if ENABLE(SERVICE_WORKER)
     bool m_pushAPIEnabled { false };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to