Title: [286316] trunk
Revision
286316
Author
[email protected]
Date
2021-11-30 12:39:07 -0800 (Tue, 30 Nov 2021)

Log Message

Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
https://bugs.webkit.org/show_bug.cgi?id=233604

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt:

Source/WebCore:

Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks.
Per the specification and to match the behavior of Blink & Gecko, ValidityState properties such as
`validity.typeMismatch` should return true in case of mismatch even if the control is disabled (and thus
willValidate() returns false).

No new tests, rebaselined existing tests.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::tooShort const):
(WebCore::HTMLInputElement::tooLong const):
(WebCore::HTMLInputElement::typeMismatch const):
(WebCore::HTMLInputElement::hasBadInput const):
(WebCore::HTMLInputElement::rangeUnderflow const):
(WebCore::HTMLInputElement::rangeOverflow const):
(WebCore::HTMLInputElement::stepMismatch const):

LayoutTests:

Rebaseline WPT tests now that more checks are passing.

* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (286315 => 286316)


--- trunk/LayoutTests/ChangeLog	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/ChangeLog	2021-11-30 20:39:07 UTC (rev 286316)
@@ -1,3 +1,16 @@
+2021-11-30  Chris Dumez  <[email protected]>
+
+        Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
+        https://bugs.webkit.org/show_bug.cgi?id=233604
+
+        Reviewed by Darin Adler.
+
+        Rebaseline WPT tests now that more checks are passing.
+
+        * platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
+        * platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
+        * platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
+
 2021-11-30  Youenn Fablet  <[email protected]>
 
         Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC

Modified: trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -42,7 +42,7 @@
 PASS http://www.&#10;google.&#13;com is a correct valid url.
 PASS http://host+ is a correct valid url.
 PASS http://myurl! is a correct valid url.
-PASS invalid is a correct valid url when disabled.
+PASS invalid is a correct invalid url.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-url.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -77,7 +77,7 @@
 expectValid('http://myurl!');
 
 // Disabled
-expectValid('invalid', true);
+expectInvalid('invalid', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01-27" overflows the maximum value "2010-01-26".
 PASS The value "9999-01-01" overflows the maximum value "2010-12-31".
 PASS The value "2010-01-27" overflows the maximum value "2010-01-26".
-PASS The value "9999-01-01" doesn't overflow the maximum value "2010-12-31" when disabled.
+PASS The value "9999-01-01" overflows the maximum value "2010-12-31" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-rangeOverflow-date.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -67,7 +67,7 @@
 checkOverflow('2010-01-27', '2010-01-26');
 
 // Disabled
-checkNotOverflow('9999-01-01', '2010-12-31', true);
+checkOverflow('9999-01-01', '2010-12-31', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01-27" undeflows the minimum value "2010-01-28".
 PASS The value "9999-01-01" undeflows the minimum value "10000-12-31".
 PASS The value "2010-01-27" undeflows the minimum value "2010-02-01".
-PASS The value "9999-01-01" doesn't underflow the minimum value "10000-12-31" when disabled.
+PASS The value "9999-01-01" undeflows the minimum value "10000-12-31" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-rangeUnderflow-date.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -69,7 +69,7 @@
 checkUnderflow('2010-01-27', '2010-02-01');
 
 // Disabled
-checkNotUnderflow('9999-01-01', '10000-12-31', true);
+checkUnderflow('9999-01-01', '10000-12-31', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -29,7 +29,7 @@
 Special step value
 PASS stepMismatchFor("2010-02-10", "any", "2010-02-09") is false
 Disabled
-PASS stepMismatchFor("2010-02-10", "2", "2010-02-09", true) is false
+PASS stepMismatchFor("2010-02-10", "2", "2010-02-09", true) is true
 
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/date/ValidityState-stepMismatch-date.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -47,7 +47,7 @@
 debug('Special step value');
 shouldBeFalse('stepMismatchFor("2010-02-10", "any", "2010-02-09")');
 debug('Disabled');
-shouldBeFalse('stepMismatchFor("2010-02-10", "2", "2010-02-09", true)');
+shouldBeTrue('stepMismatchFor("2010-02-10", "2", "2010-02-09", true)');
 
 debug('');
 </script>

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01-27T12:34" overflows the maximum value "2010-01-26T12:33:59.999".
 PASS The value "9999-01-01T23:59" overflows the maximum value "2010-12-31T00:00".
 PASS The value "2010-01-27T12:34" overflows the maximum value "2010-01-26T12:34".
-PASS The value "9999-01-01T23:59" doesn't overflow the maximum value "2010-12-31T00:00" when disabled.
+PASS The value "9999-01-01T23:59" overflows the maximum value "2010-12-31T00:00" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -67,7 +67,7 @@
 checkOverflow('2010-01-27T12:34', '2010-01-26T12:34');
 
 // Disabled
-checkNotOverflow('9999-01-01T23:59', '2010-12-31T00:00', true);
+checkOverflow('9999-01-01T23:59', '2010-12-31T00:00', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01-27T12:34" undeflows the minimum value "2010-01-27T13:00".
 PASS The value "9999-01-01T12:00" undeflows the minimum value "10000-12-31T12:00".
 PASS The value "2010-01-27T12:00" undeflows the minimum value "2010-02-01T12:00".
-PASS The value "9999-01-01T12:00" doesn't underflow the minimum value "10000-12-31T12:00" when disabled.
+PASS The value "9999-01-01T12:00" undeflows the minimum value "10000-12-31T12:00" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -69,7 +69,7 @@
 checkUnderflow('2010-01-27T12:00', '2010-02-01T12:00');
 
 // Disabled
-checkNotUnderflow('9999-01-01T12:00', '10000-12-31T12:00', true);
+checkUnderflow('9999-01-01T12:00', '10000-12-31T12:00', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -32,7 +32,7 @@
 Special step value
 PASS stepMismatchFor("2010-02-09T12:34", "any", "2010-02-09T12:34") is false
 Disabled
-PASS stepMismatchFor("2010-02-09T12:34:55.001", "1", "2010-02-09T12:34:56", true) is false
+PASS stepMismatchFor("2010-02-09T12:34:55.001", "1", "2010-02-09T12:34:56", true) is true
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -50,7 +50,7 @@
 debug('Special step value');
 shouldBeFalse('stepMismatchFor("2010-02-09T12:34", "any", "2010-02-09T12:34")');
 debug('Disabled');
-shouldBeFalse('stepMismatchFor("2010-02-09T12:34:55.001", "1", "2010-02-09T12:34:56", true)');
+shouldBeTrue('stepMismatchFor("2010-02-09T12:34:55.001", "1", "2010-02-09T12:34:56", true)');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01" overflows the maximum value "2009-12".
 PASS The value "9999-01" overflows the maximum value "2010-12".
 PASS The value "2010-01" overflows the maximum value "2009-12".
-PASS The value "9999-01" doesn't overflow the maximum value "2010-12" when disabled.
+PASS The value "9999-01" overflows the maximum value "2010-12" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-rangeOverflow-month.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -67,7 +67,7 @@
 checkOverflow('2010-01', '2009-12');
 
 // Disabled
-checkNotOverflow('9999-01', '2010-12', true);
+checkOverflow('9999-01', '2010-12', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-01" undeflows the minimum value "2010-02".
 PASS The value "9999-01" undeflows the minimum value "10000-12".
 PASS The value "2010-01" undeflows the minimum value "2010-02".
-PASS The value "9999-01" doesn't underflow the minimum value "10000-12" when disabled.
+PASS The value "9999-01" undeflows the minimum value "10000-12" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-rangeUnderflow-month.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -69,7 +69,7 @@
 checkUnderflow('2010-01', '2010-02');
 
 // Disabled
-checkNotUnderflow('9999-01', '10000-12', true);
+checkUnderflow('9999-01', '10000-12', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -29,7 +29,7 @@
 Special step value
 PASS stepMismatchFor("2010-03", "any", "2010-02") is false
 Disabled
-PASS stepMismatchFor("2010-03", "2", "2010-02", true) is false
+PASS stepMismatchFor("2010-03", "2", "2010-02", true) is true
 
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -47,7 +47,7 @@
 debug('Special step value');
 shouldBeFalse('stepMismatchFor("2010-03", "any", "2010-02")');
 debug('Disabled');
-shouldBeFalse('stepMismatchFor("2010-03", "2", "2010-02", true)');
+shouldBeTrue('stepMismatchFor("2010-03", "2", "2010-02", true)');
 
 debug('');
 </script>

Modified: trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -17,7 +17,7 @@
 PASS The value "-99" overflows the maximum value "-100".
 PASS The value "101" overflows the maximum value "1E+2".
 PASS The value "101" overflows the maximum value "100".
-PASS The value "101" doesn't overflow the maximum value "1E+2" when disabled.
+PASS The value "101" overflows the maximum value "1E+2" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-rangeoverflow.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -61,7 +61,7 @@
 checkOverflow('101', '100');
 
 // Disabled
-checkNotOverflow('101', '1E+2', true);
+checkOverflow('101', '1E+2', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -17,7 +17,7 @@
 PASS The value "-101" undeflows the minimum value "-100".
 PASS The value "99" undeflows the minimum value "1E+2".
 PASS The value "101" undeflows the minimum value "200".
-PASS The value "99" doesn't underflow the minimum value "1E+2" when disabled.
+PASS The value "99" undeflows the minimum value "1E+2" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-rangeunderflow.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -63,7 +63,7 @@
 checkUnderflow('101', '200');
 
 // Disabled
-checkNotUnderflow('99', '1E+2', true);
+checkUnderflow('99', '1E+2', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -31,7 +31,7 @@
 Rounding
 PASS stepMismatchFor("5.005", "0.005", "4") is false
 Disabled
-PASS stepMismatchFor("1", "2", "0", true) is false
+PASS stepMismatchFor("1", "2", "0", true) is true
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/number/number-validity-stepmismatch.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -48,7 +48,7 @@
 debug('Rounding');
 shouldBe('stepMismatchFor("5.005", "0.005", "4")', 'false');
 debug('Disabled');
-shouldBe('stepMismatchFor("1", "2", "0", true)', 'false');
+shouldBe('stepMismatchFor("1", "2", "0", true)', 'true');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -13,7 +13,7 @@
 PASS The value "13:16" overflows the maximum value "13:15".
 PASS The value "23:59:59.999" overflows the maximum value "13:16".
 PASS The value "13:16" overflows the maximum value "12:00".
-PASS The value "23:59:59.999" doesn't overflow the maximum value "13:16" when disabled.
+PASS The value "23:59:59.999" overflows the maximum value "13:16" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeoverflow.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -66,7 +66,7 @@
 checkOverflow('13:16', '12:00');
 
 // Disabled
-checkNotOverflow('23:59:59.999', '13:16', true);
+checkOverflow('23:59:59.999', '13:16', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "13:16" undeflows the minimum value "13:17".
 PASS The value "23:59" undeflows the minimum value "23:59:30".
 PASS The value "13:16" undeflows the minimum value "14:00".
-PASS The value "23:59" doesn't underflow the minimum value "23:59:30" when disabled.
+PASS The value "23:59" undeflows the minimum value "23:59:30" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-rangeunderflow.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -67,7 +67,7 @@
 checkUnderflow('13:16', '14:00');
 
 // Disabled
-checkNotUnderflow('23:59', '23:59:30', true);
+checkUnderflow('23:59', '23:59:30', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -30,7 +30,7 @@
 Special step value
 PASS stepMismatchFor("12:35", "any", "12:34") is false
 Disabled
-PASS stepMismatchFor("12:34:55.001", "1", "12:34:56", true) is false
+PASS stepMismatchFor("12:34:55.001", "1", "12:34:56", true) is true
 
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/time/time-validity-stepmismatch.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -48,7 +48,7 @@
 debug('Special step value');
 shouldBeFalse('stepMismatchFor("12:35", "any", "12:34")');
 debug('Disabled');
-shouldBeFalse('stepMismatchFor("12:34:55.001", "1", "12:34:56", true)');
+shouldBeTrue('stepMismatchFor("12:34:55.001", "1", "12:34:56", true)');
 
 debug('');
 </script>

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -15,7 +15,7 @@
 PASS The value "2010-W01" overflows the maximum value "2009-W12".
 PASS The value "9999-W01" overflows the maximum value "2010-W12".
 PASS The value "2010-W01" overflows the maximum value "2009-W50".
-PASS The value "9999-W01" doesn't overflow the maximum value "2010-W12" when disabled.
+PASS The value "9999-W01" overflows the maximum value "2010-W12" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-rangeOverflow-week.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -68,7 +68,7 @@
 checkOverflow('2010-W01', '2009-W50');
 
 // Disabled
-checkNotOverflow('9999-W01', '2010-W12', true);
+checkOverflow('9999-W01', '2010-W12', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -14,7 +14,7 @@
 PASS The value "2010-W01" undeflows the minimum value "2010-W02".
 PASS The value "9999-W01" undeflows the minimum value "10000-W12".
 PASS The value "2010-W01" undeflows the minimum value "2010-W02".
-PASS The value "9999-W01" doesn't underflow the minimum value "10000-W12" when disabled.
+PASS The value "9999-W01" undeflows the minimum value "10000-W12" when disabled.
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-rangeUnderflow-week.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -69,7 +69,7 @@
 checkUnderflow('2010-W01', '2010-W02');
 
 // Disabled
-checkNotUnderflow('9999-W01', '10000-W12', true);
+checkUnderflow('9999-W01', '10000-W12', true);
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week-expected.txt (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -31,7 +31,7 @@
 Special step value
 PASS stepMismatchFor("2010-W03", "any", "2010-W02") is false
 Disabled
-PASS stepMismatchFor("2010-W03", "2", "2010-W02", true) is false
+PASS stepMismatchFor("2010-W03", "2", "2010-W02", true) is true
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week.html (286315 => 286316)


--- trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week.html	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/fast/forms/week/ValidityState-stepMismatch-week.html	2021-11-30 20:39:07 UTC (rev 286316)
@@ -49,7 +49,7 @@
 debug('Special step value');
 shouldBeFalse('stepMismatchFor("2010-W03", "any", "2010-W02")');
 debug('Disabled');
-shouldBeFalse('stepMismatchFor("2010-W03", "2", "2010-W02", true)');
+shouldBeTrue('stepMismatchFor("2010-W03", "2", "2010-W02", true)');
 </script>
 <script src=""
 </body>

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286315 => 286316)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-30 20:39:07 UTC (rev 286316)
@@ -1,5 +1,16 @@
 2021-11-30  Chris Dumez  <[email protected]>
 
+        Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
+        https://bugs.webkit.org/show_bug.cgi?id=233604
+
+        Reviewed by Darin Adler.
+
+        Rebaseline WPT tests now that more checks are passing.
+
+        * web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt:
+
+2021-11-30  Chris Dumez  <[email protected]>
+
         html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing
         https://bugs.webkit.org/show_bug.cgi?id=233601
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -10,8 +10,8 @@
 PASS [INPUT in NUMBER status] The max is greater than value(floating number)
 PASS [INPUT in NUMBER status] The max equals to value
 PASS [INPUT in NUMBER status] The value is not a number
-FAIL [INPUT in NUMBER status] The value is greater than max(integer) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(floating number) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(special floating number) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(scientific notation) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value is greater than max(integer)
+PASS [INPUT in NUMBER status] The value is greater than max(floating number)
+PASS [INPUT in NUMBER status] The value is greater than max(special floating number)
+PASS [INPUT in NUMBER status] The value is greater than max(scientific notation)
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -10,8 +10,8 @@
 PASS [INPUT in NUMBER status] The min is less than value(floating number)
 PASS [INPUT in NUMBER status] The min equals to value
 PASS [INPUT in NUMBER status] The value is not a number
-FAIL [INPUT in NUMBER status] The value is less than min(integer) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(floating number) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(special floating number) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(scientific notation) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value is less than min(integer)
+PASS [INPUT in NUMBER status] The value is less than min(floating number)
+PASS [INPUT in NUMBER status] The value is less than min(special floating number)
+PASS [INPUT in NUMBER status] The value is less than min(scientific notation)
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt (286315 => 286316)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -5,11 +5,11 @@
 FAIL [INPUT in TIME status] The time type must be supported. assert_equals: The time type should be supported. expected "time" but got "text"
 FAIL [INPUT in DATETIME-LOCAL status] The datetime-local type must be supported. assert_equals: The datetime-local type should be supported. expected "datetime-local" but got "text"
 PASS [INPUT in NUMBER status] The step attribute is not set
-FAIL [INPUT in NUMBER status] The step attribute is not set and the value attribute is a floating number assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The step attribute is not set and the value attribute is a floating number
 PASS [INPUT in NUMBER status] The value attribute is empty string
 PASS [INPUT in NUMBER status] The value must match the step
-FAIL [INPUT in NUMBER status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value must mismatch the step
 PASS [INPUT in NUMBER status] No step mismatch when step is a floating number and value is its integral multiple
 PASS [INPUT in NUMBER status] No step mismatch when step is a floating number in exponent format and value is its integral multiple
-FAIL [INPUT in NUMBER status] Step mismatch when step is a very small floating number and value is not its integral multiple assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] Step mismatch when step is a very small floating number and value is not its integral multiple
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt (286315 => 286316)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -2,12 +2,12 @@
 PASS [INPUT in EMAIL status] The value is empty
 PASS [INPUT in EMAIL status] The value is a valid email address
 PASS [INPUT in EMAIL status] The value is a valid email address with some white spaces.
-FAIL [INPUT in EMAIL status] The value is not an email address assert_true: The validity.typeMismatch should be true, when control is disabled. expected true got false
-FAIL [INPUT in EMAIL status] The value contains multiple email addresses assert_true: The validity.typeMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in EMAIL status] The value is not an email address
+PASS [INPUT in EMAIL status] The value contains multiple email addresses
 PASS [INPUT in EMAIL status] The value is valid email addresses
-FAIL [INPUT in EMAIL status] The value contains invalid separator assert_true: The validity.typeMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in EMAIL status] The value contains invalid separator
 PASS [INPUT in URL status] The value is empty
 PASS [INPUT in URL status] The value is a valid url
 PASS [INPUT in URL status] The value is a valid url with some white spaces.
-FAIL [INPUT in URL status] The value is not an url assert_true: The validity.typeMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in URL status] The value is not an url
 

Modified: trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -5,11 +5,11 @@
 PASS [INPUT in DATETIME-LOCAL status] The max attribute is greater than the value attribute
 PASS [INPUT in DATETIME-LOCAL status] The value is an invalid local date time string(hour is greater than 23)
 PASS [INPUT in DATETIME-LOCAL status] The value if an invalid local date time string(year is two digits)
-FAIL [INPUT in DATETIME-LOCAL status] The value is greater than max assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 1 digit) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 2 digits) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 3 digits) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is greater than max(Year is 10000 should be valid) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in DATETIME-LOCAL status] The value is greater than max
+PASS [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 1 digit)
+PASS [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 2 digits)
+PASS [INPUT in DATETIME-LOCAL status] The value is greater than max(with millisecond in 3 digits)
+PASS [INPUT in DATETIME-LOCAL status] The value is greater than max(Year is 10000 should be valid)
 PASS [INPUT in DATE status] The max attribute is not set
 PASS [INPUT in DATE status] Value is empty string
 PASS [INPUT in DATE status] The max attribute is an invalid date
@@ -18,8 +18,8 @@
 PASS [INPUT in DATE status] The value is an invalid date(month is greater than 12)
 PASS [INPUT in DATE status] The value is an invalid date(date is greater than 29 for Feb)
 PASS [INPUT in DATE status] The max attribute is greater than value attribute
-FAIL [INPUT in DATE status] The value attribute is greater than max attribute assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATE status] The value attribute is greater than max attribute(Year is 10000 should be valid) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in DATE status] The value attribute is greater than max attribute
+PASS [INPUT in DATE status] The value attribute is greater than max attribute(Year is 10000 should be valid)
 PASS [INPUT in MONTH status] The max attribute is not set
 PASS [INPUT in MONTH status] Value is empty string
 PASS [INPUT in MONTH status] The max attribute is an invalid month string
@@ -27,8 +27,8 @@
 PASS [INPUT in MONTH status] The value is an invalid month string(year is three digits)
 PASS [INPUT in MONTH status] The value is an invalid month string(month is greater than 12)
 PASS [INPUT in MONTH status] The max attribute is greater than value attribute
-FAIL [INPUT in MONTH status] The value attribute is greater than max attribute assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in MONTH status] The value attribute is greater than max attribute(Year is 10000 should be valid) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in MONTH status] The value attribute is greater than max attribute
+PASS [INPUT in MONTH status] The value attribute is greater than max attribute(Year is 10000 should be valid)
 PASS [INPUT in WEEK status] The max attribute is not set
 PASS [INPUT in WEEK status] Value is empty string
 PASS [INPUT in WEEK status] The max attribute is an invalid week string
@@ -37,8 +37,8 @@
 PASS [INPUT in WEEK status] The value is an invalid week string(year is three digits)
 PASS [INPUT in WEEK status] The value is an invalid week string(week is too greater)
 PASS [INPUT in WEEK status] The max attribute is greater than value attribute
-FAIL [INPUT in WEEK status] The value attribute is greater than max attribute assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in WEEK status] The value attribute is greater than max attribute(Year is 10000 should be valid) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in WEEK status] The value attribute is greater than max attribute
+PASS [INPUT in WEEK status] The value attribute is greater than max attribute(Year is 10000 should be valid)
 PASS [INPUT in TIME status] The max attribute is not set
 PASS [INPUT in TIME status] Value is empty string
 PASS [INPUT in TIME status] The max attribute is an invalid time string
@@ -48,13 +48,13 @@
 PASS [INPUT in TIME status] The value attribute is an invalid time string(second is greater than 59)
 PASS [INPUT in TIME status] The max attribute is greater than value attribute
 PASS [INPUT in TIME status] The time missing second and minute parts is invalid
-FAIL [INPUT in TIME status] The value attribute is greater than max attribute assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is greater than max(with millisecond in 1 digit) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is greater than max(with millisecond in 2 digit) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is greater than max(with millisecond in 3 digit) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The time missing second part is valid assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in TIME status] The value attribute is greater than max attribute
+PASS [INPUT in TIME status] The value is greater than max(with millisecond in 1 digit)
+PASS [INPUT in TIME status] The value is greater than max(with millisecond in 2 digit)
+PASS [INPUT in TIME status] The value is greater than max(with millisecond in 3 digit)
+PASS [INPUT in TIME status] The time missing second part is valid
 PASS [INPUT in TIME status] The time is max for reversed range
-FAIL [INPUT in TIME status] The time is outside the accepted range for reversed range assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in TIME status] The time is outside the accepted range for reversed range
 FAIL [INPUT in TIME status] The time is min for reversed range assert_false: The validity.rangeOverflow should be false. expected false got true
 FAIL [INPUT in TIME status] The time is inside the accepted range for reversed range assert_false: The validity.rangeOverflow should be false. expected false got true
 PASS [INPUT in NUMBER status] The max attribute is not set
@@ -63,8 +63,8 @@
 PASS [INPUT in NUMBER status] The max is greater than value(floating number)
 PASS [INPUT in NUMBER status] The max equals to value
 PASS [INPUT in NUMBER status] The value is not a number
-FAIL [INPUT in NUMBER status] The value is greater than max(integer) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(floating number) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(special floating number) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is greater than max(scientific notation) assert_true: The validity.rangeOverflow should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value is greater than max(integer)
+PASS [INPUT in NUMBER status] The value is greater than max(floating number)
+PASS [INPUT in NUMBER status] The value is greater than max(special floating number)
+PASS [INPUT in NUMBER status] The value is greater than max(scientific notation)
 

Modified: trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt (286315 => 286316)


--- trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -5,11 +5,11 @@
 PASS [INPUT in DATETIME-LOCAL status] The min attribute is less than the value attribute
 PASS [INPUT in DATETIME-LOCAL status] The value is an invalid local date time string(hour is greater than 23)
 PASS [INPUT in DATETIME-LOCAL status] The value is an invalid local date time string(year is two digits)
-FAIL [INPUT in DATETIME-LOCAL status] The value is less than min assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 1 digit) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 2 digits) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 3 digits) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATETIME-LOCAL status] The value is less than min(Year is 10000 should be valid) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in DATETIME-LOCAL status] The value is less than min
+PASS [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 1 digit)
+PASS [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 2 digits)
+PASS [INPUT in DATETIME-LOCAL status] The value is less than min(with millisecond in 3 digits)
+PASS [INPUT in DATETIME-LOCAL status] The value is less than min(Year is 10000 should be valid)
 PASS [INPUT in DATETIME-LOCAL status] The value is greater than max
 PASS [INPUT in DATE status] The min attribute is not set
 PASS [INPUT in DATE status] Value is empty string
@@ -19,8 +19,8 @@
 PASS [INPUT in DATE status] The value is an invalid date(month is less than 12)
 PASS [INPUT in DATE status] The value is an invalid date(date is less than 29 for Feb)
 PASS [INPUT in DATE status] The min attribute is less than value attribute
-FAIL [INPUT in DATE status] The value attribute is less than min attribute assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in DATE status] The value attribute is less than min attribute(Year is 10000 should be valid) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in DATE status] The value attribute is less than min attribute
+PASS [INPUT in DATE status] The value attribute is less than min attribute(Year is 10000 should be valid)
 PASS [INPUT in MONTH status] The min attribute is not set
 PASS [INPUT in MONTH status] Value is empty string
 PASS [INPUT in MONTH status] The min attribute is an invalid month string
@@ -28,8 +28,8 @@
 PASS [INPUT in MONTH status] The value is an invalid month string(year is three digits)
 PASS [INPUT in MONTH status] The value is an invalid month string(month is less than 12)
 PASS [INPUT in MONTH status] The min attribute is less than value attribute
-FAIL [INPUT in MONTH status] The value attribute is less than min attribute assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in MONTH status] The value attribute is less than min attribute(Year is 10000 should be valid) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in MONTH status] The value attribute is less than min attribute
+PASS [INPUT in MONTH status] The value attribute is less than min attribute(Year is 10000 should be valid)
 PASS [INPUT in WEEK status] The min attribute is not set
 PASS [INPUT in WEEK status] Value is empty string
 PASS [INPUT in WEEK status] The min attribute is an invalid week string
@@ -38,8 +38,8 @@
 PASS [INPUT in WEEK status] The value is an invalid week string(year is three digits)
 PASS [INPUT in WEEK status] The value is an invalid week string(week is too greater)
 PASS [INPUT in WEEK status] The min attribute is less than value attribute
-FAIL [INPUT in WEEK status] The value attribute is less than min attribute assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in WEEK status] The value attribute is less than min attribute(Year is 10000 should be valid) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in WEEK status] The value attribute is less than min attribute
+PASS [INPUT in WEEK status] The value attribute is less than min attribute(Year is 10000 should be valid)
 PASS [INPUT in TIME status] The min attribute is not set
 PASS [INPUT in TIME status] Value is empty string
 PASS [INPUT in TIME status] The min attribute is an invalid time string
@@ -46,13 +46,13 @@
 PASS [INPUT in TIME status] The value attribute is an invalid time string
 PASS [INPUT in TIME status] The min attribute is less than value attribute
 PASS [INPUT in TIME status] The time missing second and minute parts is invalid
-FAIL [INPUT in TIME status] The value attribute is less than min attribute assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is less than min(with millisecond in 1 digit) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is less than min(with millisecond in 2 digit) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The value is less than min(with millisecond in 3 digit) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in TIME status] The time missing second part is valid assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in TIME status] The value attribute is less than min attribute
+PASS [INPUT in TIME status] The value is less than min(with millisecond in 1 digit)
+PASS [INPUT in TIME status] The value is less than min(with millisecond in 2 digit)
+PASS [INPUT in TIME status] The value is less than min(with millisecond in 3 digit)
+PASS [INPUT in TIME status] The time missing second part is valid
 FAIL [INPUT in TIME status] The time is max for reversed range assert_false: The validity.rangeUnderflow should be false. expected false got true
-FAIL [INPUT in TIME status] The time is outside the accepted range for reversed range assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in TIME status] The time is outside the accepted range for reversed range
 PASS [INPUT in TIME status] The time is min for reversed range
 PASS [INPUT in TIME status] The time is inside the accepted range for reversed range
 PASS [INPUT in NUMBER status] The min attribute is not set
@@ -61,8 +61,8 @@
 PASS [INPUT in NUMBER status] The min is less than value(floating number)
 PASS [INPUT in NUMBER status] The min equals to value
 PASS [INPUT in NUMBER status] The value is not a number
-FAIL [INPUT in NUMBER status] The value is less than min(integer) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(floating number) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(special floating number) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
-FAIL [INPUT in NUMBER status] The value is less than min(scientific notation) assert_true: The validity.rangeUnderflow should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value is less than min(integer)
+PASS [INPUT in NUMBER status] The value is less than min(floating number)
+PASS [INPUT in NUMBER status] The value is less than min(special floating number)
+PASS [INPUT in NUMBER status] The value is less than min(scientific notation)
 

Modified: trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt (286315 => 286316)


--- trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt	2021-11-30 20:39:07 UTC (rev 286316)
@@ -2,29 +2,29 @@
 PASS [INPUT in DATE status] The step attribute is not set
 PASS [INPUT in DATE status] The value attibute is empty string
 PASS [INPUT in DATE status] The value must match the step
-FAIL [INPUT in DATE status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in DATE status] The value must mismatch the step
 PASS [INPUT in MONTH status] The step attribute is not set
 PASS [INPUT in MONTH status] The value attibute is empty string
 PASS [INPUT in MONTH status] The value must match the step
-FAIL [INPUT in MONTH status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in MONTH status] The value must mismatch the step
 PASS [INPUT in WEEK status] The step attribute is not set
 PASS [INPUT in WEEK status] The value attibute is empty string
 PASS [INPUT in WEEK status] The value must match the step
-FAIL [INPUT in WEEK status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in WEEK status] The value must mismatch the step
 PASS [INPUT in TIME status] The step attribute is not set
 PASS [INPUT in TIME status] The value attibute is empty string
 PASS [INPUT in TIME status] The value must match the step
-FAIL [INPUT in TIME status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in TIME status] The value must mismatch the step
 PASS [INPUT in DATETIME-LOCAL status] The step attribute is not set
 PASS [INPUT in DATETIME-LOCAL status] The value attibute is empty string
 PASS [INPUT in DATETIME-LOCAL status] The value must match the step
-FAIL [INPUT in DATETIME-LOCAL status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in DATETIME-LOCAL status] The value must mismatch the step
 PASS [INPUT in NUMBER status] The step attribute is not set
-FAIL [INPUT in NUMBER status] The step attribute is not set and the value attribute is a floating number assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The step attribute is not set and the value attribute is a floating number
 PASS [INPUT in NUMBER status] The value attribute is empty string
 PASS [INPUT in NUMBER status] The value must match the step
-FAIL [INPUT in NUMBER status] The value must mismatch the step assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] The value must mismatch the step
 PASS [INPUT in NUMBER status] No step mismatch when step is a floating number and value is its integral multiple
 PASS [INPUT in NUMBER status] No step mismatch when step is a floating number in exponent format and value is its integral multiple
-FAIL [INPUT in NUMBER status] Step mismatch when step is a very small floating number and value is not its integral multiple assert_true: The validity.stepMismatch should be true, when control is disabled. expected true got false
+PASS [INPUT in NUMBER status] Step mismatch when step is a very small floating number and value is not its integral multiple
 

Modified: trunk/Source/WebCore/ChangeLog (286315 => 286316)


--- trunk/Source/WebCore/ChangeLog	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/Source/WebCore/ChangeLog	2021-11-30 20:39:07 UTC (rev 286316)
@@ -1,5 +1,28 @@
 2021-11-30  Chris Dumez  <[email protected]>
 
+        Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
+        https://bugs.webkit.org/show_bug.cgi?id=233604
+
+        Reviewed by Darin Adler.
+
+        Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks.
+        Per the specification and to match the behavior of Blink & Gecko, ValidityState properties such as
+        `validity.typeMismatch` should return true in case of mismatch even if the control is disabled (and thus
+        willValidate() returns false).
+
+        No new tests, rebaselined existing tests.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::tooShort const):
+        (WebCore::HTMLInputElement::tooLong const):
+        (WebCore::HTMLInputElement::typeMismatch const):
+        (WebCore::HTMLInputElement::hasBadInput const):
+        (WebCore::HTMLInputElement::rangeUnderflow const):
+        (WebCore::HTMLInputElement::rangeOverflow const):
+        (WebCore::HTMLInputElement::stepMismatch const):
+
+2021-11-30  Chris Dumez  <[email protected]>
+
         html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing
         https://bugs.webkit.org/show_bug.cgi?id=233601
 

Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (286315 => 286316)


--- trunk/Source/WebCore/html/HTMLInputElement.cpp	2021-11-30 20:38:24 UTC (rev 286315)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp	2021-11-30 20:39:07 UTC (rev 286316)
@@ -286,17 +286,17 @@
 
 bool HTMLInputElement::tooShort() const
 {
-    return willValidate() && tooShort(value(), CheckDirtyFlag);
+    return tooShort(value(), CheckDirtyFlag);
 }
 
 bool HTMLInputElement::tooLong() const
 {
-    return willValidate() && tooLong(value(), CheckDirtyFlag);
+    return tooLong(value(), CheckDirtyFlag);
 }
 
 bool HTMLInputElement::typeMismatch() const
 {
-    return willValidate() && m_inputType->typeMismatch();
+    return m_inputType->typeMismatch();
 }
 
 bool HTMLInputElement::valueMissing() const
@@ -306,7 +306,7 @@
 
 bool HTMLInputElement::hasBadInput() const
 {
-    return willValidate() && m_inputType->hasBadInput();
+    return m_inputType->hasBadInput();
 }
 
 bool HTMLInputElement::patternMismatch() const
@@ -355,12 +355,12 @@
 
 bool HTMLInputElement::rangeUnderflow() const
 {
-    return willValidate() && m_inputType->rangeUnderflow(value());
+    return m_inputType->rangeUnderflow(value());
 }
 
 bool HTMLInputElement::rangeOverflow() const
 {
-    return willValidate() && m_inputType->rangeOverflow(value());
+    return m_inputType->rangeOverflow(value());
 }
 
 String HTMLInputElement::validationMessage() const
@@ -386,7 +386,7 @@
 
 bool HTMLInputElement::stepMismatch() const
 {
-    return willValidate() && m_inputType->stepMismatch(value());
+    return m_inputType->stepMismatch(value());
 }
 
 bool HTMLInputElement::isValid() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to