Title: [286439] trunk
- Revision
- 286439
- Author
- [email protected]
- Date
- 2021-12-02 11:35:49 -0800 (Thu, 02 Dec 2021)
Log Message
Unreviewed, reverting r285570.
Broke StarD build
Reverted changeset:
"Fix crash in GraphicsContextCG::endTransparencyLayer"
https://bugs.webkit.org/show_bug.cgi?id=230230
https://commits.webkit.org/r285570
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (286438 => 286439)
--- trunk/LayoutTests/ChangeLog 2021-12-02 19:19:01 UTC (rev 286438)
+++ trunk/LayoutTests/ChangeLog 2021-12-02 19:35:49 UTC (rev 286439)
@@ -1,3 +1,15 @@
+2021-12-02 Robert Jenner <[email protected]>
+
+ Unreviewed, reverting r285570.
+
+ Broke StarD build
+
+ Reverted changeset:
+
+ "Fix crash in GraphicsContextCG::endTransparencyLayer"
+ https://bugs.webkit.org/show_bug.cgi?id=230230
+ https://commits.webkit.org/r285570
+
2021-12-02 Tyler Wilcock <[email protected]>
AX Isolated Tree: Document links should be stored in web areas, not the root
Deleted: trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt (286438 => 286439)
--- trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt 2021-12-02 19:19:01 UTC (rev 286438)
+++ trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash-expected.txt 2021-12-02 19:35:49 UTC (rev 286439)
@@ -1 +0,0 @@
-PASS if this doesn't crash
Deleted: trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html (286438 => 286439)
--- trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html 2021-12-02 19:19:01 UTC (rev 286438)
+++ trunk/LayoutTests/fast/layers/top-layer-ancestor-opacity-and-transform-crash.html 2021-12-02 19:35:49 UTC (rev 286439)
@@ -1,9 +0,0 @@
-<style>
-* { opacity: 0.1; translate: 1px; }
-</style>
-<dialog>PASS if this doesn't crash</dialog>
-<script>
- document.querySelector("dialog").showModal();
- if (testRunner)
- testRunner.dumpAsText();
-</script>
Modified: trunk/Source/WebCore/ChangeLog (286438 => 286439)
--- trunk/Source/WebCore/ChangeLog 2021-12-02 19:19:01 UTC (rev 286438)
+++ trunk/Source/WebCore/ChangeLog 2021-12-02 19:35:49 UTC (rev 286439)
@@ -1,3 +1,15 @@
+2021-12-02 Robert Jenner <[email protected]>
+
+ Unreviewed, reverting r285570.
+
+ Broke StarD build
+
+ Reverted changeset:
+
+ "Fix crash in GraphicsContextCG::endTransparencyLayer"
+ https://bugs.webkit.org/show_bug.cgi?id=230230
+ https://commits.webkit.org/r285570
+
2021-12-02 Antti Koivisto <[email protected]>
[:has() pseudo-class] Invalidation in non-subject position
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (286438 => 286439)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-12-02 19:19:01 UTC (rev 286438)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-12-02 19:35:49 UTC (rev 286439)
@@ -2089,9 +2089,9 @@
if (isComposited())
return nullptr;
- for (RenderLayer* curr = stackingContext(); curr; curr = curr->stackingContext()) {
+ for (RenderLayer* curr = parent(); curr; curr = curr->parent()) {
if (curr->isComposited())
- break;
+ return nullptr;
if (curr->isTransparent())
return curr;
}
@@ -3061,8 +3061,7 @@
// If we have a transparency layer enclosing us and we are the root of a transform, then we need to establish the transparency
// layer from the parent now, assuming there is a parent
if (paintFlags & PaintLayerFlag::HaveTransparency) {
- // Top layer elements are not affected by ancestor opacities
- if (!establishesTopLayer() && parent())
+ if (parent())
parent()->beginTransparencyLayers(context, paintingInfo, paintingInfo.paintDirtyRect);
else
beginTransparencyLayers(context, paintingInfo, paintingInfo.paintDirtyRect);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
