Title: [286470] trunk/Source/WebKit
Revision
286470
Author
commit-qu...@webkit.org
Date
2021-12-02 17:42:15 -0800 (Thu, 02 Dec 2021)

Log Message

Make enum values consisten in ApplicationManifest::Icon::Purpose
and _WKApplicationManifestIconPurpose
https://bugs.webkit.org/show_bug.cgi?id=233764
rdar://85976270

Patch by Rachel Ginsberg <rginsb...@apple.com> on 2021-12-02
Reviewed by Brent Fulgham.

The ApplicationManifest tests already check for 1, 2, and 4 respectively.

* UIProcess/API/Cocoa/_WKApplicationManifest.h:
Set the _WKApplicationManifestIconPurpose enum values to
1, 2, 4 to match the enum values set in ApplicationManifest::Icon::Purpose.
Those values are used in ApplicationManifest because an
OptionSet is used.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (286469 => 286470)


--- trunk/Source/WebKit/ChangeLog	2021-12-03 01:14:02 UTC (rev 286469)
+++ trunk/Source/WebKit/ChangeLog	2021-12-03 01:42:15 UTC (rev 286470)
@@ -1,3 +1,21 @@
+2021-12-02  Rachel Ginsberg  <rginsb...@apple.com>
+
+        Make enum values consisten in ApplicationManifest::Icon::Purpose
+        and _WKApplicationManifestIconPurpose
+        https://bugs.webkit.org/show_bug.cgi?id=233764
+        rdar://85976270
+
+        Reviewed by Brent Fulgham.
+
+        The ApplicationManifest tests already check for 1, 2, and 4 respectively.
+
+        * UIProcess/API/Cocoa/_WKApplicationManifest.h:
+        Set the _WKApplicationManifestIconPurpose enum values to 
+        1, 2, 4 to match the enum values set in ApplicationManifest::Icon::Purpose.
+        Those values are used in ApplicationManifest because an
+        OptionSet is used.
+
+
 2021-12-02  Per Arne Vollan  <pvol...@apple.com>
 
         [WP][iOS] Add telemetry to determine which system calls are only used on process launch

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h (286469 => 286470)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h	2021-12-03 01:14:02 UTC (rev 286469)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h	2021-12-03 01:42:15 UTC (rev 286470)
@@ -43,9 +43,9 @@
 } WK_API_AVAILABLE(macos(10.13.4), ios(11.3));
 
 typedef NS_ENUM(NSInteger, _WKApplicationManifestIconPurpose) {
-    _WKApplicationManifestIconPurposeAny,
-    _WKApplicationManifestIconPurposeMonochrome,
-    _WKApplicationManifestIconPurposeMaskable,
+    _WKApplicationManifestIconPurposeAny = (1 << 0),
+    _WKApplicationManifestIconPurposeMonochrome = (1 << 1),
+    _WKApplicationManifestIconPurposeMaskable = (1 << 2),
 } WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 WK_CLASS_AVAILABLE(macos(10.13.4), ios(11.3))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to