Title: [286554] trunk
- Revision
- 286554
- Author
- [email protected]
- Date
- 2021-12-06 11:22:54 -0800 (Mon, 06 Dec 2021)
Log Message
Update GPU Process feature flags
https://bugs.webkit.org/show_bug.cgi?id=232547
rdar://83905400
Reviewed by Wenson Hsieh.
Source/WTF:
Move features enabled by default to internal. DOM and WebGL are experimental.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
* Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Update features that are set when using `run-webkit-tests --use-gpu-process`.
* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults): Turn off DOM Rendering on layout test bots for the time being.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (286553 => 286554)
--- trunk/Source/WTF/ChangeLog 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Source/WTF/ChangeLog 2021-12-06 19:22:54 UTC (rev 286554)
@@ -1,3 +1,16 @@
+2021-12-06 Jon Lee <[email protected]>
+
+ Update GPU Process feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=232547
+ rdar://83905400
+
+ Reviewed by Wenson Hsieh.
+
+ Move features enabled by default to internal. DOM and WebGL are experimental.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+ * Scripts/Preferences/WebPreferencesInternal.yaml:
+
2021-12-06 Nikolas Zimmermann <[email protected]>
[LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286553 => 286554)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-06 19:22:54 UTC (rev 286554)
@@ -361,17 +361,6 @@
WebCore:
default: false
-CaptureVideoInGPUProcessEnabled:
- type: bool
- humanReadableName: "GPU Process: Video Capture"
- humanReadableDescription: "Enable video capture in GPU Process"
- webcoreBinding: none
- condition: ENABLE(MEDIA_STREAM)
- exposed: [ WebKit ]
- defaultValue:
- WebKit:
- default: WebKit::defaultCaptureVideoInGPUProcessEnabled()
-
ContactPickerAPIEnabled:
type: bool
humanReadableName: "Contact Picker API"
@@ -1372,28 +1361,17 @@
WebKit:
default: true
-UseGPUProcessForCanvasRenderingEnabled:
+UseGPUProcessForDOMRenderingEnabled:
type: bool
- humanReadableName: "GPU Process: Canvas Rendering"
- humanReadableDescription: "Enable canvas rendering in GPU Process"
+ humanReadableName: "GPU Process: DOM Rendering"
+ humanReadableDescription: "Enable DOM rendering in GPU Process"
webcoreBinding: none
- condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE))
+ condition: ENABLE(GPU_PROCESS)
exposed: [ WebKit ]
defaultValue:
WebKit:
- default: defaultUseGPUProcessForCanvasRenderingEnabled()
+ default: defaultUseGPUProcessForDOMRenderingEnabled()
-UseGPUProcessForMediaEnabled:
- type: bool
- humanReadableName: "GPU Process: Media"
- humanReadableDescription: "Do all media loading and playback in the GPU Process"
- webcoreBinding: none
- condition: ENABLE(GPU_PROCESS) && !USE(GSTREAMER)
- exposed: [ WebKit ]
- defaultValue:
- WebKit:
- default: WebKit::defaultUseGPUProcessForMediaEnabled()
-
UseGPUProcessForWebGLEnabled:
type: bool
humanReadableName: "GPU Process: WebGL"
@@ -1640,20 +1618,6 @@
WebCore:
default: false
-# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
-WebRTCPlatformCodecsInGPUProcessEnabled:
- type: bool
- humanReadableName: "WebRTC Platform Codecs in GPU Process"
- humanReadableDescription: "Enable WebRTC Platform Codecs in GPU Process"
- condition: ENABLE(WEB_RTC)
- defaultValue:
- WebKitLegacy:
- default: false
- WebKit:
- default: WebKit::defaultWebRTCCodecsInGPUProcess()
- WebCore:
- default: false
-
WebRTCPlatformTCPSocketsEnabled:
type: bool
humanReadableName: "WebRTC Platform TCP Sockets"
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (286553 => 286554)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-12-06 19:22:54 UTC (rev 286554)
@@ -154,6 +154,17 @@
WebKit:
default: WebKit::defaultCaptureAudioInUIProcessEnabled()
+CaptureVideoInGPUProcessEnabled:
+ type: bool
+ humanReadableName: "GPU Process: Video Capture"
+ humanReadableDescription: "Enable video capture in GPU Process"
+ webcoreBinding: none
+ condition: ENABLE(MEDIA_STREAM)
+ exposed: [ WebKit ]
+ defaultValue:
+ WebKit:
+ default: WebKit::defaultCaptureVideoInGPUProcessEnabled()
+
CaptureVideoInUIProcessEnabled:
type: bool
humanReadableName: "Capture video in UI Process"
@@ -833,17 +844,28 @@
WebKit:
default: true
-UseGPUProcessForDOMRenderingEnabled:
+UseGPUProcessForCanvasRenderingEnabled:
type: bool
- humanReadableName: "GPU Process: DOM Rendering"
- humanReadableDescription: "Enable DOM rendering in GPU Process"
+ humanReadableName: "GPU Process: Canvas Rendering"
+ humanReadableDescription: "Enable canvas rendering in GPU Process"
webcoreBinding: none
- condition: ENABLE(GPU_PROCESS)
+ condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE))
exposed: [ WebKit ]
defaultValue:
WebKit:
- default: defaultUseGPUProcessForDOMRenderingEnabled()
+ default: defaultUseGPUProcessForCanvasRenderingEnabled()
+UseGPUProcessForMediaEnabled:
+ type: bool
+ humanReadableName: "GPU Process: Media"
+ humanReadableDescription: "Do all media loading and playback in the GPU Process"
+ webcoreBinding: none
+ condition: ENABLE(GPU_PROCESS) && !USE(GSTREAMER)
+ exposed: [ WebKit ]
+ defaultValue:
+ WebKit:
+ default: WebKit::defaultUseGPUProcessForMediaEnabled()
+
UseSceneKitForModel:
type: bool
humanReadableName: "Use SceneKit for <model>"
@@ -929,6 +951,20 @@
WebKit:
default: true
+# FIXME: This is not relevant for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
+WebRTCPlatformCodecsInGPUProcessEnabled:
+ type: bool
+ humanReadableName: "GPU Process: WebRTC Platform Codecs"
+ humanReadableDescription: "Enable WebRTC Platform Codecs in GPU Process"
+ condition: ENABLE(WEB_RTC)
+ defaultValue:
+ WebKitLegacy:
+ default: false
+ WebKit:
+ default: WebKit::defaultWebRTCCodecsInGPUProcess()
+ WebCore:
+ default: false
+
WebSQLEnabled:
type: bool
humanReadableName: "Enable WebSQL"
Modified: trunk/Tools/ChangeLog (286553 => 286554)
--- trunk/Tools/ChangeLog 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Tools/ChangeLog 2021-12-06 19:22:54 UTC (rev 286554)
@@ -1,3 +1,16 @@
+2021-12-06 Jon Lee <[email protected]>
+
+ Update GPU Process feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=232547
+ rdar://83905400
+
+ Reviewed by Wenson Hsieh.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args): Update features that are set when using `run-webkit-tests --use-gpu-process`.
+ * WebKitTestRunner/TestOptions.cpp:
+ (WTR::TestOptions::defaults): Turn off DOM Rendering on layout test bots for the time being.
+
2021-12-06 Matt Gilligan <[email protected]>
[iOS] Allow WKWebView clients to override undoManager
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (286553 => 286554)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2021-12-06 19:22:54 UTC (rev 286554)
@@ -374,14 +374,14 @@
options.additional_expectations.insert(0, host.filesystem.join(host.scm().checkout_root, 'LayoutTests/gpu-process/TestExpectations'))
if not options.internal_feature:
options.internal_feature = []
- options.internal_feature.append('UseGPUProcessForMediaEnabled')
options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
options.internal_feature.append('CaptureVideoInGPUProcessEnabled')
options.internal_feature.append('UseGPUProcessForCanvasRenderingEnabled')
- options.internal_feature.append('UseGPUProcessForDOMRenderingEnabled')
+ options.internal_feature.append('UseGPUProcessForMediaEnabled')
+ options.internal_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled')
if not options.experimental_feature:
options.experimental_feature = []
- options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled')
+ options.experimental_feature.append('UseGPUProcessForDOMRenderingEnabled')
options.experimental_feature.append('UseGPUProcessForWebGLEnabled')
if options.result_report_flavor:
raise RuntimeError('--use-gpu-process implicitly sets the result flavor, this should not be overridden')
Modified: trunk/Tools/WebKitTestRunner/TestOptions.cpp (286553 => 286554)
--- trunk/Tools/WebKitTestRunner/TestOptions.cpp 2021-12-06 19:13:26 UTC (rev 286553)
+++ trunk/Tools/WebKitTestRunner/TestOptions.cpp 2021-12-06 19:22:54 UTC (rev 286554)
@@ -124,6 +124,9 @@
#if PLATFORM(IOS_FAMILY_SIMULATOR)
{ "VP9DecoderEnabled", false },
#endif
+#if ENABLE(GPU_PROCESS)
+ { "UseGPUProcessForDOMRenderingEnabled", false },
+#endif
#if ENABLE(GPU_PROCESS) && ENABLE(WEBGL)
{ "UseGPUProcessForWebGLEnabled", false },
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
